Repository navigation
test(minimal): T21 — Specs, types and entries inspected, end to end - #3338
Conversation
One test scaffolds and appends entries with min init, lists and shows the types, renders entry and box specs over a test daemon, and checks that each render's span names the expansion it read.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Approved: 1 finding, none above this repo's threshold at Nothing to do. Clobber: none. |
There was a problem hiding this comment.
arch-review: CONDITIONS · 1 condition · the full ruling
The test conforms for min init, min type and the stored-spec render. It also records a design gap: min box spec <entry> does not apply the Box Type defaults layer. Lines 1231 and 1281 of architecture.md put that layer in every expansion. The test comment calls the gap an interim, but no issue tracks it. Make the change in C1: file the issue, link it in the comment and the PR body, and state the flip assertion.
Ruled at 4e5e320 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
…s-and-entries-inspected-end-to-end
Name the code that skips the Box Type defaults layer, and the needle to add for web when that layer lands.
|
Round 1 of 10 on the runtime's review findings, pushed as
Verify Converted to a draft: something above needs a person before review. Review threads the coder judged:
One test in crates/minimal/src/tests.rs runs the whole flow against a test daemon. It scaffolds and appends entries with Notes from the agent: Revise round 1. Thread PRRT_kwDOPdfcxM622MBf asks for a filed issue. This box has no gh credential, so I could not file one. The test comment now names the gap ( |
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 2 unresolved threads — minimal-arch[bot] crates/minimal/src/tests.rs, minimal-foundry[bot] crates/minimal/src/tests.rs:18427. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
There was a problem hiding this comment.
arch-review: CONDITIONS · 2 conditions · the full ruling
The test is in the correct layer and proves min init, min type list and both min box spec forms. Two things block it. The Box Type defaults layer (architecture.md line 1231) is missing from the CLI expansion. The test calls this an interim, but no issue tracks it. File the issue and link it in the comment, as C1 says. The proof also says that min type show rust-dev names the source of each default and constraint, but the test asserts only the header. Add the needles in C2.
Ruled at d256b3c against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
/revise Head 1. C1: the interim names its issue. 2. C2: the proof asserts the sources. Reply on the arch threads with the commit. |
…s-and-entries-inspected-end-to-end
…s-and-entries-inspected-end-to-end
|
Round 2 of 10 on a /revise note, pushed as
Verify Converted to a draft: something above needs a person before review. Review threads the coder judged:
A person can run the end-to-end test. It scaffolds and appends entries with Notes from the agent: Commit 90e1b3a addresses arch ruling 1210 C1 and C2, and changes nothing else. The constraint line that the test asserts is |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
This change conforms to the design. The test proves min init, min type list, min type show and both forms of min box spec against architecture.md lines 448, 463 and 476-477. The product still omits the Box Type defaults layer (lines 1228-1231). The test does not assert that layer. It names #3340 and the needle to add when the layer lands. The start limits are residuals with #3140 and #3204. Make sure that #3340 exists. I could not check it from the sandbox.
Ruled at 5257ba8 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 4 unresolved threads — minimal-arch[bot] crates/minimal/src/tests.rs, minimal-foundry[bot] crates/minimal/src/tests.rs:18448, minimal-arch[bot] crates/minimal/src/tests.rs, minimal-arch[bot] crates/minimal/src/tests.rs:18299. 1 finding, 1 inline.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
There was a problem hiding this comment.
minimal-review — approved
Verdict APPROVE — every review thread is resolved; @agent-137 closed the last one. The review of 5257ba84b489 withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.
…s-and-entries-inspected-end-to-end # Conflicts: # crates/minimal/src/tests.rs
|
A merge of main before round 3, not counted against the cap (2 of 3), pushed as Resolved conflicts in:
Verify Converted to a draft: something above needs a person before review. The end-to-end test renders an entry's and a box's expanded spec with the layer and type of each value, lists and shows the types, and scaffolds and appends entries with Notes from the agent: Conflict round. Both sides appended a new test at the end of crates/minimal/src/tests.rs: this branch added spec_type_init_end_to_end, and main added box_rename_native_host_prints_no_vm_host_warning. The resolution keeps both tests and closes the T21 function before the T42 test. The merge commit is a37ec29. |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The change since the last PASS is a merge of main only. The T21 test lines are the same as at 5257ba8. The test drives min init, min type and min box spec as architecture.md lines 448, 463 and 476-477 give them. The missing type-defaults layer (line 1281) is an interim with issue #3340. The ruling stays PASS, with three filed residuals.
Ruled at a37ec29 against gominimal/arch@15b603e6afb8 by claude-opus-5-5.
|
/revise Head |
|
Round 3 of 10 on a /revise note: the coder changed nothing. The merge of origin/main is already on the branch as a37ec29, and origin has it too. It resolves the conflict in crates/minimal/src/tests.rs and keeps both sides. |
T21 — Specs, types and entries inspected, end to end
slice: S5
kind: integration
covers: none
size: S
est: 20 code, 100 tests
executor: agent
difficulty: routine
model: light
diagnostics: when the end-to-end test fails, it prints each command it ran with that command's stdout, stderr and exit code
observability: the test run's spans show the expansion each render reads
layers:
- tests:
- crates/minimal/src/tests.rs: the slice's end-to-end test over a test daemon
test: cargo nextest run -p minimal spec_type_init_end_to_end
produces: none
consumes: none
proof: Render an entry's or a box's expanded spec with the layer and type of each value, list and show the types, and scaffold or append entries with
min init.depends on:
- blocked by #2906
- blocked by #2899
- blocked by #2893
Proof
In one test run over a test daemon, a person can see these steps. Bare min init scaffolds minimal.toml. min init --type appends the entries default (session), build (task) and web (the project type rust-dev). min type list shows the six built-in types and rust-dev with source project. min type show rust-dev names the source of each default and constraint. min box spec dev and min box spec web render the expanded spec with the entry's type in the header and the layer of each value, for example packages from [defaults.session]. min box spec -o json renders the spec stored with a box created on the daemon. The log shows each render inside the test span, with the entry or box id it read. On a failure, the test prints each command with its stdout, stderr and exit code.
Notes from the agent: Gaps found, outside this task's layers. The test asserts only what the branch delivers. (1) min box spec does not apply the type-defaults layer: expand_entry in crates/minimal/src/cmd/box_spec.rs builds Layers with no type_defaults. So the timeout = "30m" that [box_types.rust-dev.defaults] sets does not appear in min box spec web, although min type show rust-dev lists it. The label 'type defaults' is therefore never printed. The start path in crates/minimal/src/cmd/boxes/create.rs also does not apply the layer, so the render and the start agree. (2) min session start web, for an entry of a project type, is refused: the start cannot tell whether it is a session entry. (3) A session start by name takes only the entry 'default'. So the box form is proven with a box created from a 'default' entry that min init appends. The proof says 'the layer and type of each value'. The entry's type is in the render header, and the layer is beside each value. A per-value type label needs gap (1) fixed first. clippy -p minimal --all-targets reported nothing on the new lines.
Tests
cargo nextest run -p minimal spec_type_init_end_to_endVerify
min task run agent-verifyexited 100, so this PR is a draft.Closes #2914