Skip to content

fix(minimal,minimal-client,minimald): a resume that minvmd refuses shows minvmd's reason, and the - #3482

Merged
norrietaylor merged 11 commits into
mainfrom
agent/3477-a-resume-that-minvmd-refuses-shows-minvmd-s-reas
Nov 17, 2026
Merged

norrietaylor merged 11 commits into
mainfrom
agent/3477-a-resume-that-minvmd-refuses-shows-minvmd-s-reas

Conversation

@minimal-foundry

Copy link
Copy Markdown
Contributor

Defect

Fixes #3477

  • Epic: none; not charged to an epic
  • Size: M; estimated 110 code, 150 tests
  • May touch:
    • crates/minimal-client/src/attach.rs
    • crates/minimal-client/src/box_registration.rs
    • crates/minimal/src/cmd/boxes/attach.rs
    • crates/minimal/src/cmd/boxes/vm_host.rs
    • crates/minimald/src/connection.rs
    • crates/minimald/src/box_actor/attach.rs
    • crates/minimal/src/tests.rs
Task marker
### D3475 — A resume that minvmd refuses shows minvmd's reason, and the error of bare min stays on screen
  kind: task
  size: M
  est: 110 code, 150 tests
  executor: agent
  defect: bug
  layers:
    - client:
      - crates/minimal-client/src/attach.rs: resume_box_row_at returns minvmd's BoxControlReply::Error refusal as a typed error that carries its reason, in place of a warn line and Ok(false)
      - crates/minimal-client/src/box_registration.rs: resume_box_row fails the attach or exec with minvmd's refusal reason, for example the NO_ANSWERER text that names min finalize-install --show. Update the doc comment and add a test
      - crates/minimal/src/cmd/boxes/attach.rs: callers of resume_box_row print minvmd's refusal. interactive_attach keeps an attach error on screen after the terminal unwind
      - crates/minimal/src/cmd/boxes/vm_host.rs: add a fake VM host test where the resume is refused, and assert that the error carries minvmd's reason
      test: cargo nextest run -p minimal-client resume_refusal_carries_the_vm_host_reason
      test: cargo nextest run -p minimal resume_refused_by_vm_host_names_its_reason
    - daemon:
      - crates/minimald/src/connection.rs: send an exit status with each attach refusal, so ssh does not exit 255 and the blind unwind does not move the cursor over the error
      - crates/minimald/src/box_actor/attach.rs: AttachError::exit_code gives an exit status for BoxHostRowEnded and the other refusals. BoxHostRowEnded text stays for a row that minvmd released
      - crates/minimal/src/tests.rs: add a test: an attach that the daemon refuses leaves its error line on screen after the TerminalUnwind runs
      test: cargo nextest run -p minimald attach_refusal_sends_an_exit_status
      test: cargo nextest run -p minimal attach_error_stays_on_screen_after_the_unwind
  proof: With the DNS service stopped, bare min and min box attach on a stopped own_ip box both print minvmd's reason that names min finalize-install --show, and the error stays on screen.

Proof

When minvmd refuses the resume of a stopped own_ip box, for example because the DNS service is stopped, bare min and min box attach (and min box exec, and the dashboard attach) now end before they take the terminal. They print error: the running VM refused to restore the network addresses of box <name>: <minvmd's reason>, and that reason names min finalize-install --show. A refusal from the in-VM daemon now sends an exit status, so ssh does not end with 255, and no blind cursor restore moves the cursor over the error line.

Notes from the agent: Nobody ran the proof against a live VM with the DNS service stopped. Fake VM hosts and a fake terminal pin it in the tests. New printed text: the running VM refused to restore the network addresses of box <name>, the prefix to minvmd's reason. Daemon attach refusals other than a refused resume now end with exit status 1. Before this change ssh ended with 255. A resume refusal is now a typed error, minimal_client::box_registration::HostRefusal, and it fails min box exec and the dashboard attach too, through their existing ?. A minimald older than this branch still sends no exit status, and the client then still writes its blind unwind on 255. This task did not change interactive_attach code for that case. Only its doc comment changed, because TERMINAL_UNWIND lives in crates/minimal/src/attach.rs, which is outside the layers. Clippy on minimal, minimald and minimal-client with --all-targets is clean. Other tests run: the resume tests in minimal-client and minimal, minimal dash::rpc, and minimald connection::. All of them pass.

Tests

line exit tail
cargo nextest run -p minimal-client resume_refusal_carries_the_vm_host_reason 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new
cargo nextest run -p minimal resume_refused_by_vm_host_names_its_reason 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new
cargo nextest run -p minimald attach_refusal_sends_an_exit_status 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new
cargo nextest run -p minimal attach_error_stays_on_screen_after_the_unwind 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new

Verify

min task run agent-verify exited 101, so this PR is a draft.

3427ac3159,libsame_file-0d4c610508a69e8c,libnutype-2060fd37b9d379f2,libclient_config-b967f21a883cbf40,libtoml-2aea33601fef026d,libtoml_writer-14581a9d8fee7cd3,libtoml_parser-9d71f9449b11f073,libwinnow-0b86322c90e7afd1,libserde_spanned-d96ed742cfb92972,libtoml_datetime-be2b7a398aebdb67,libtracing-83feaaf26e80a884,libtracing_core-84f58f17c6893e81,libonce_cell-9a2fd160c1da4076,libportable_atomic-0dd514cc30f274c2,libpaths-38d338f2d2882e54,libdirs-460e2d244a8fc274,libdirs_sys-5e8776d10c678365,liboption_ext-b0ea52c3b95d09a1,libthiserror-d936554554fa5dac,libcamino-0c63145602122330,libuuid-2ad4c678aa627cb6,libgetrandom-3bfdefd1957f2b79,librand_core-d44f5774360f5730,libtokio-13fd64194b408f82,libsignal_hook_registry-60ebd8ada6df02c9,liberrno-1e4b1b28d80f8540,libsocket2-fc4ed66d87c4ac8d,libbytes-0bf3479143915ee4,libmio-6731274e08199f17,liblog-438092e92453965a,libparking_lot-e10cfa7068c27153,libparking_lot_core-651ad44aebfee548,libsmallvec-463b7668d74ea315,liblock_api-56b5536424e00cb8,libscopeguard-49a31dfd7f08b4b8,libpin_project_lite-965c2dcbe863fe30,libserde-a2d31a39ef0e3ca2,libnix-7ebd9b01737ef144,libmemoffset-f0df7639bcafa05a,libbitflags-3b49cf15bc6cb9e2,libserde_core-149b29d4f6c47ae0,libcfg_if-5af2d58a3df8aa54,liblibc-4f2d736fc0e30dce}.rlib" "<sysroot>/lib64/rustlib/x86_64-unknown-linux-gnu/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/work/build-cache/cargo-home/build/debug/deps/rustclIAvZN/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/work/build-cache/cargo-home/build/debug/build/tree-sitter-6abcf750100a3ada/out" "-L" "/work/build-cache/cargo-home/build/debug/build/tree-sitter-nickel-4d55240ed02e956b/out" "-L" "/work/build-cache/cargo-home/build/debug/build/zstd-sys-0d91391d9ed43bde/out" "-L" "/work/build-cache/cargo-home/build/debug/build/ring-43aedddb25fbb121/out" "-L" "/work/build-cache/cargo-home/build/debug/build/aws-lc-sys-467e076f78a0a3c4/out" "-L" "/work/build-cache/cargo-home/build/debug/build/blake3-493bdc0df5a171ff/out" "-L" "<sysroot>/lib64/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/work/build-cache/cargo-home/build/debug/deps/minimald-5a6511c21bd0c772" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: /usr/bin/ld: final link failed: No space left on device
          collect2: error: ld returned 1 exit status
          

error: could not compile `minimald` (lib test) due to 1 previous error
error: command `/usr/bin/cargo '--color=auto' test --no-run --message-format json-render-diagnostics --package minimal --package minimal-client --package minimald --locked` exited with code 101

Base

The base branch moved while the coder worked; it was merged in before the tests ran.

Without one, ssh exits 255, the client reads that as a dropped
connection, and its blind terminal unwind moves the cursor over the
refusal text.
…reason

A refused box row resume was a warn line, and the attach went on to a
launch refusal that hid the cause. It is now a HostRefusal error that
carries the VM host's reason.
Pin that a resume the VM host refuses fails the attach with its reason,
and that a refused attach writes no blind unwind over its error line.
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 64629320-ca3f-4d28-890d-d0721c80c09a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@norrietaylor

Copy link
Copy Markdown
Member

/revise

Review of head 09c548c. Fix these. Keep every change inside the plan's files, plus docs/reference/cli-min.md for item 4.

  1. Only a refusal that names a remedy is fatal.
    • crates/minimal-client/src/attach.rs (about 885-890) turns every BoxControlReply::Error into HostRefusal.
    • minvmd's other ResumeError cases (NoCreation, NotTheHandedPair, NotTheBoxId, LoopbackMoved) carry internal text and no next step. Before this PR they reached the guest's BoxHostRowEnded, which names min session destroy / min session activate.
    • Make fatal the refusals whose text gives the user a runnable step: the NO_ANSWERER "could not give the box an address" case. Keep the old behaviour for the rest, or give each one a next step the user can run.
  2. An older minvmd must not block attach.
    • minvmd answers a request it cannot parse with BoxControlReply::Error, so a daemon from before ResumeBox now fails every own_ip attach, exec and dash resume.
    • The new doc comment (about line 845) says such a daemon gives "a reply that is not … a refusal". That is not true.
    • Treat an unknown-request reply as the warn line it was before. Fix the doc comment.
  3. Print the reason once, in the user's words.
    • The new tracing::warn! (about attach.rs 886) prints by default on stderr, so the reason shows twice, once with "host row resume".
    • Drop it, or log it at debug.
    • The user-facing text now reads "the running VM refused to restore the network addresses of box : could not give the box an address: the running VM cannot reach …". Remove the repetition, and do not say the VM refused when the host daemon refused.
  4. The exit code.
    • Attach refusals now exit 1 where min session attach and bare min gave 255 and min box attach gave 7.
    • Keep 1 if that is intended, and document it in docs/reference/cli-min.md (the exit-code table, about line 306). Otherwise give refusals a code that a shell's own exit 1 cannot be confused with.
  5. Tests that fail without the fix.
    • attach_error_stays_on_screen_after_the_unwind (crates/minimal/src/tests.rs about 7848) passes on the tree before this PR. interactive_attach is unchanged, and the stub returns exit 1 itself.
    • attach_refusal_sends_an_exit_status (crates/minimald/src/connection.rs about 1050) tests only the (line, code) helper. Add a test that drives the handler (about connection.rs 495-503) and checks that the exit status is sent before close.
    • The resume tests hand-copy a truncated reason. Pin the real wire text: the "could not give the box an address: " prefix plus NO_ANSWERER.

…hat-minvmd-refuses-shows-minvmd-s-reas

# Conflicts:
#	crates/minimald/src/connection.rs
minvmd's other refusals, and the parse refusal of a minvmd from before
the resume, stay a warn line as before. The reason prints once, after
the box name, and logs at debug.
The test drives a refused attach through the SSH handler and checks
that the exit status arrives before the channel closes.
Also show in the unwind test what the daemon's exit status prevents: a
refusal that ends with ssh's 255 gets the blind unwind after it.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as cf729201481d.

Resolved conflicts in: crates/minimald/src/connection.rs

line exit tail
cargo nextest run -p minimal-client resume_refusal_carries_the_vm_host_reason 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new
cargo nextest run -p minimal resume_refused_by_vm_host_names_its_reason 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new
cargo nextest run -p minimald attach_refusal_sends_an_exit_status 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new
cargo nextest run -p minimal attach_error_stays_on_screen_after_the_unwind 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new

Verify min task run agent-verify timed out after 1800s.

Checking common v0.0.1 (/workbench/crates/common)
    Checking switch v0.0.1 (/workbench/crates/switch)
    Checking diagnostics v0.0.1 (/workbench/crates/diagnostics)
    Checking boxes v0.0.1 (/workbench/crates/boxes)
    Checking sandbox v0.0.1 (/workbench/crates/sandbox)
    Checking mlog v0.0.1 (/workbench/crates/mlog)
    Checking async-dialog v0.0.1 (/workbench/crates/async-dialog)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
    Checking mfile v0.0.1 (/workbench/crates/mfile)
    Checking minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
    Checking minimal-client v0.8.0 (/workbench/crates/minimal-client)
    Checking decode v0.0.1 (/workbench/crates/decode)
    Checking checkouts v0.0.1 (/workbench/crates/checkouts)
    Checking graph v0.0.1 (/workbench/crates/graph)
    Checking lcache v0.0.1 (/workbench/crates/lcache)
    Checking rcache v0.0.1 (/workbench/crates/rcache)
    Checking op v0.0.1 (/workbench/crates/op)
    Checking check v0.0.1 (/workbench/crates/check)
    Checking orchestrator v0.0.1 (/workbench/crates/orchestrator)
    Checking mctx v0.0.1 (/workbench/crates/mctx)
    Checking minimald v0.8.0 (/workbench/crates/minimald)
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 1m 16s
   Compiling opentelemetry v0.33.1
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling serial_test v4.0.1
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Outside the task's layers::

  • docs/reference/cli-min.md

Converted to a draft: something above needs a person before review.

When minvmd refuses to give an own_ip box an address, for example with the DNS service stopped, bare min, min box attach and min box exec fail and print 'box : the running VM cannot reach Minimal's DNS service for box names, ... run min finalize-install --show ...' once. The command exits 1. Every attach that minimald refuses now ends with an exit status, so the refusal line stays on screen and the blind unwind does not run. Other minvmd refusals, and an older minvmd that cannot parse the resume, stay a warn line and the attach goes on as before.

Notes from the agent: Conflict round: the merge of origin/main conflicted only in crates/minimald/src/connection.rs. The resolution keeps this branch's exit status for every refusal (AttachError::exit_code returns u32). It also takes main's refusal line 'Cannot attach to the box: ' (BCLI-068), with main's attach_refusal_line test. The REFUSAL constant in crates/minimal/src/tests.rs now uses that new text. Directive items: (1)+(2) resume_box_row_at now fails only on a reply that starts with 'could not give the box an address: ' (new pub const NO_ADDRESS_REFUSAL). All other BoxControlReply::Error replies, including a parse error from a minvmd from before ResumeBox, fall back to the earlier warn line and Ok(false). The doc comments now say this. (3) The tracing::warn on the refusal is now debug. HostRefusal carries the reason without the prefix, and the context is only 'box '. The printed text is 'box web: the running VM cannot reach ...'. (4) The exit code stays 1. This round documents it in docs/reference/cli-min.md under session attach. That file is outside the plan layers, but the directive allowed it. vale is not installed on this box, so just lint-prose did not run on that file. (5) The new handler-driven test attach_refusal_sends_an_exit_status_before_the_close sends a real refused attach through the SSH handler. It checks ExitStatus(1) before the close. With the exit_status_request…[truncated]

@norrietaylor
norrietaylor marked this pull request as ready for review November 17, 2026 15:19
@norrietaylor
norrietaylor requested a review from a team as a code owner November 17, 2026 15:19
@minimal-foundry

minimal-foundry Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

Reviewed: no findings; approval withheld, 1 thread unresolved at e49b92b4a853.

APPROVE withheld: 1 unresolved thread — minimal-foundry[bot] crates/minimal-client/src/attach.rs:853. Resolving the last thread releases the approval on this head.

Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen in the touched hunks.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment on lines +840 to +843
/// The prefix minvmd puts on its refusal to give a box an address
/// (`allocate_box_address_keeping`). The reason after it names the step the
/// user can run, so a resume that it refuses fails the attach (NET-138).
pub const NO_ADDRESS_REFUSAL: &str = "could not give the box an address: ";

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW · correctness · confidence 0.60 · in NO_ADDRESS_REFUSAL

NO_ADDRESS_REFUSAL copies the literal that minvmd writes in allocate_box_address_keeping (crates/minvmd/src/control.rs:2437). The client uses it to choose between failing the attach and a warn line. If someone rewords the minvmd text, the resume silently goes back to the old warn-and-continue path. The new client test builds its wire text from the constant, so it cannot catch this drift. Share the constant, or add a test in minvmd that asserts the prefix. Also, that prefix covers every allocator refusal (quarantine, range probe), not only the DNS case. The doc comment says each reason names a step the user can take. Check that this holds.

What the reviewer checked

control.rs:2437 error: format!("could not give the box an address: {reason}"); attach.rs:843 pub const NO_ADDRESS_REFUSAL: &str = "could not give the box an address: ";

Hand this to an agent
Act on a code-review finding.

File:       crates/minimal-client/src/attach.rs
Lines:      840-843
Category:   correctness
Severity:   low (reviewer confidence 0.60)

Finding:
`NO_ADDRESS_REFUSAL` copies the literal that minvmd writes in `allocate_box_address_keeping` (crates/minvmd/src/control.rs:2437). The client uses it to choose between failing the attach and a warn line. If someone rewords the minvmd text, the resume silently goes back to the old warn-and-continue path. The new client test builds its wire text from the constant, so it cannot catch this drift. Share the constant, or add a test in minvmd that asserts the prefix. Also, that prefix covers every allocator refusal (quarantine, range probe), not only the DNS case. The doc comment says each reason names a step the user can take. Check that this holds.

First verify this against the code yourself. It is model output and
may be wrong. If it is wrong, or the tradeoff was deliberate, say so
and change nothing.

👍 useful · 👎 noise — react to tell the reviewer. Replying works too, and says more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 6e1096f8b808: Added resume_refusal_carries_the_vm_host_reason_prefix_minvmd_writes, which reads minvmd's control.rs and fails on drift. Sharing the constant needs minimald-rpc and minvmd, outside this task's layers. The doc comments no longer claim that every allocator reason names a step.

NO_ADDRESS_REFUSAL copies the literal minvmd writes. A test now reads
minvmd's control.rs and fails when the two drift. The doc comments no
longer claim that every allocator reason names a step for the user.
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on the runtime's review findings, pushed as 6e1096f8b808.

line exit tail
cargo nextest run -p minimal-client resume_refusal_carries_the_vm_host_reason 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new
cargo nextest run -p minimal resume_refused_by_vm_host_names_its_reason 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new
cargo nextest run -p minimald attach_refusal_sends_an_exit_status 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new
cargo nextest run -p minimal attach_error_stays_on_screen_after_the_unwind 0 warning: unknown fields in task runtime-implement-test-0: network warning: unknown fields in task runtime-implement-test-1: network warning: unknown fields in task runtime-implement-test-2: network warning: unknown fields in task runtime-implement-test-3: network help: do you need to update to a new

Verify min task run agent-verify exited 101.

t=/work/build-cache/cargo-home/build/debug/deps/libproptest-44d491d1a8aa49a0.rlib --extern ratatui=/work/build-cache/cargo-home/build/debug/deps/libratatui-1fc20dde22a8a62b.rlib --extern reqwest=/work/build-cache/cargo-home/build/debug/deps/libreqwest-5de86acda4cea8f4.rlib --extern russh=/work/build-cache/cargo-home/build/debug/deps/librussh-ed15d7ff509bfc78.rlib --extern russh_sftp=/work/build-cache/cargo-home/build/debug/deps/librussh_sftp-c0dd194e0f0fbcdd.rlib --extern serde=/work/build-cache/cargo-home/build/debug/deps/libserde-a2d31a39ef0e3ca2.rlib --extern serde_json_lenient=/work/build-cache/cargo-home/build/debug/deps/libserde_json_lenient-d40e6f0e7b3e9eef.rlib --extern sha2=/work/build-cache/cargo-home/build/debug/deps/libsha2-c9bcb32104c3d8ae.rlib --extern switch=/work/build-cache/cargo-home/build/debug/deps/libswitch-6c812704e5da955c.rlib --extern tempfile=/work/build-cache/cargo-home/build/debug/deps/libtempfile-a0e916d9301e1bc8.rlib --extern tokio=/work/build-cache/cargo-home/build/debug/deps/libtokio-13fd64194b408f82.rlib --extern tokio_stream=/work/build-cache/cargo-home/build/debug/deps/libtokio_stream-f2be74d61837d3fa.rlib --extern toml=/work/build-cache/cargo-home/build/debug/deps/libtoml-2aea33601fef026d.rlib --extern toml_edit=/work/build-cache/cargo-home/build/debug/deps/libtoml_edit-c70767a08866b85f.rlib --extern tracing=/work/build-cache/cargo-home/build/debug/deps/libtracing-83feaaf26e80a884.rlib --extern tracing_subscriber=/work/build-cache/cargo-home/build/debug/deps/libtracing_subscriber-b9d261067ec6d0c0.rlib --extern unicode_width=/work/build-cache/cargo-home/build/debug/deps/libunicode_width-b88ae913615e5a0f.rlib --extern url=/work/build-cache/cargo-home/build/debug/deps/liburl-7dfaaabb254cca5f.rlib --extern uuid=/work/build-cache/cargo-home/build/debug/deps/libuuid-2ad4c678aa627cb6.rlib --extern version=/work/build-cache/cargo-home/build/debug/deps/libversion-26aec4f378b53f65.rlib --extern zeroize=/work/build-cache/cargo-home/build/debug/deps/libzeroize-839e2912eb255706.rlib -L native=/work/build-cache/cargo-home/build/debug/build/zstd-sys-0d91391d9ed43bde/out -L native=/work/build-cache/cargo-home/build/debug/build/ring-43aedddb25fbb121/out -L native=/work/build-cache/cargo-home/build/debug/build/aws-lc-sys-467e076f78a0a3c4/out -L native=/work/build-cache/cargo-home/build/debug/build/tree-sitter-6abcf750100a3ada/out -L native=/work/build-cache/cargo-home/build/debug/build/tree-sitter-nickel-4d55240ed02e956b/out -L native=/work/build-cache/cargo-home/build/debug/build/blake3-493bdc0df5a171ff/out -L native=/work/build-cache/cargo-home/build/debug/build/blake3-493bdc0df5a171ff/out` (exit status: 101)
warning: build failed, waiting for other jobs to finish...
error: could not compile `minimal` (test "cli") due to 1 previous error
error: command `/usr/bin/cargo '--color=auto' test --no-run --message-format json-render-diagnostics --package minimal --package minimal-client --package minimald --locked` exited with code 101

Outside the task's layers::

  • docs/reference/cli-min.md

Converted to a draft: something above needs a person before review.

Review threads the coder judged:

  • 👍 valid — crates/minimal-client/src/attach.rs:853: Added resume_refusal_carries_the_vm_host_reason_prefix_minvmd_writes, which reads minvmd's control.rs and fails on drift. Sharing the constant needs minimald-rpc and minvmd, outside this task's layers. The doc comments no longer claim that every allocator reason names a step.

With the DNS service stopped, bare min and min box attach on a stopped own_ip box fail with minvmd's reason, which names min finalize-install --show, and the error line stays on screen after the terminal unwind. The client prefix that selects this refusal is now pinned to minvmd's source by a test.

Notes from the agent: Revise round 3. The review asked to share NO_ADDRESS_REFUSAL with minvmd. That needs a constant in minimald-rpc and an edit in crates/minvmd/src/control.rs, and both are outside this task's layers. In its place, a test in crates/minimal-client/src/box_registration.rs reads crates/minvmd/src/control.rs and fails when minvmd no longer writes the prefix. A later task can move the constant into minimald-rpc and remove that test. The doc comments now say that the allocator reasons include a full or quarantined range and a failed range bind check. Some of these reasons only state the situation and name no step. A resume with no address cannot go on, so the attach still fails with the reason.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 17, 2026 16:03
@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 4 of 10 on a failed check suite: the coder changed nothing. A person needs to take it from here.

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on a failed check suite: the coder changed nothing. every commit this round put on the branch above 6e1096f is a merge of the base branch, so it carries no work of its own

@minimal-foundry

Copy link
Copy Markdown
Contributor Author

Round 6 of 10 on a failed check suite: the coder changed nothing. every commit this round put on the branch above e49b92b is a merge of the base branch, so it carries no work of its own

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at e49b92b. Only the no-address refusals are fatal, an older minvmd's reply stays a warning, the reason prints once in plain words, exit 1 is documented, the daemon's exit-status fix has a handler test, and the refusal prefix is checked against minvmd's source. Low leftovers are in 3507 (follow-up).

@norrietaylor
norrietaylor added this pull request to the merge queue Nov 17, 2026

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 1 unresolved thread — minimal-foundry[bot] crates/minimal-client/src/attach.rs:853. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 17, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 40d38fc Nov 17, 2026
42 of 44 checks passed
@norrietaylor
norrietaylor deleted the agent/3477-a-resume-that-minvmd-refuses-shows-minvmd-s-reas branch November 17, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

D3475 — A resume that minvmd refuses shows minvmd's reason, and the error of bare min stays on screen

1 participant