Repository navigation
feat(minimal): T41 — Box spec lists a box's hooks with their declarer - #3490
Draft
minimal-foundry[bot] wants to merge 1 commit into
Draft
minimal-foundry[bot] wants to merge 1 commit into
minimal-foundry[bot] wants to merge 1 commit into
Conversation
The TOML render of a box's stored spec now opens with a comment list of its lifecycle hooks: one line for each event, with the command, the description and who declared the hook (minimal.toml or a loadout). The list is comments, so the render stays valid TOML (BCLI-022, BOX-179).
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T41 — Box spec lists a box's hooks with their declarer
slice: S5
kind: task
covers: BCLI-022
size: S
est: 70 code, 80 tests
executor: agent
difficulty: routine
model: standard
diagnostics: none new
observability: none new
layers:
- client:
- crates/minimal/src/cmd/box_spec.rs:
min box spec <box>lists the stored lifecycle hooks, with the event, the command, its description and who declared it (BOX-179'sdeclared_by)- crates/minimal/src/tests.rs: the in-process minimald test harness gains this layer's tests
test: cargo nextest run -p minimal box_spec_box_lists_hooks
produces: none
consumes: none
proof:
min box spec <box>lists each stored lifecycle hook with its event, command, description and declarer.depends on:
- blocked by #2906
- blocked by #3409
Proof
min box spec <box>now opens its TOML render with a# Lifecycle hooks:comment list. It has one line for each event of each stored hook, with the event, the description, the command and its declarer, for example# on_attach: echo rust (from loadout rust). A box stored with an empty hook list shows# Lifecycle hooks: none.Notes from the agent: The list is in the TOML render only, as comment lines, so the output stays valid TOML. The -o json and -o yaml renders already carry the stored
lifecycle_hookswithdeclared_byunchanged, so this change does not touch them. An inline command with more than one line shows its first line and then.... An external script shows asscript <path>. A spec stored before hooks were stored has nolifecycle_hookskey and shows no list. The existing test box_spec_box_renders_stored_copy still passes. cargo clippy -p minimal --all-targets is clean.Tests
cargo nextest run -p minimal box_spec_box_lists_hooksVerify
min task run agent-verifyexited 100, so this PR is a draft.Closes #3283