Skip to content

fix(boxes): the toolchain allowlist names docker hub's third blob host - #3498

Merged
bryan-minimal merged 1 commit into
mainfrom
fix/net068-docker-s3-blob-host
Nov 17, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
fix/net068-docker-s3-blob-host

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

What

The toolchain egress allowlist (NET-068) names Docker Hub's two CDN hosts for image blobs. Docker Hub also redirects a blob to the bucket behind them, docker-images-prod.s3.dualstack.us-east-1.amazonaws.com, and picks per request. This adds that host to the shared list, to the unit fixture that must exercise every entry, and to the copy in the session e2e script.

Why

The KVM test hostname_allowlist_toolchain_completes fails whenever a pull is sent to the bucket: the lookup of that name is refused, as the allowlist says it must be, and the image pull fails. It is intermittent because the redirect target varies, and it has blocked unrelated PRs (two failures in a row on #3265).

Testing

  • The unit fixture now includes the new host, so the test that every listed host is admitted covers it.
  • Workspace tests, lint and the native end-to-end script pass on this commit.

The proof that the flake is gone is the KVM job over time; one green run does not show it.

🤖 Generated with Claude Code

Docker Hub redirects an image blob to one of its two CDNs or to the bucket
behind them, docker-images-prod.s3.dualstack.us-east-1.amazonaws.com, and
picks per request. The NET-068 list named only the CDNs, so the
hostname-allowlist proof failed whenever a pull was sent to the bucket:
skopeo's lookup of that name was refused, as the allowlist says it must be.

The host joins the shared list, the unit fixture that must exercise every
entry, and the copy in the session e2e script.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 17, 2026 16:40
@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 3 billable files and costs up to $0.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 12 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f567ef55-668e-4cb5-966d-a3da457d6726
Commits

Reviewing files that changed from the base of the PR and between 893eedd and 4ce5e51.

Files selected for processing: 3

  • crates/boxes/src/lib.rs
  • crates/minimald/src/net/dns_gate.rs
  • scripts/session-e2e.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry

minimal-foundry Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Reviewed: 1 finding, none blocking at 4ce5e516b23d.

Address the comments on the diff.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@mitodrummer mitodrummer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit e9a61b6 Nov 17, 2026
39 checks passed
@bryan-minimal
bryan-minimal deleted the fix/net068-docker-s3-blob-host branch November 17, 2026 18:46
norrietaylor added a commit that referenced this pull request Nov 17, 2026
…-vm-box-is-not

Resolve the S3 blob host conflicts in favour of main's #3498.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants