Repository navigation
fix(boxes): the toolchain allowlist names docker hub's third blob host - #3498
Merged
Merged
Conversation
Docker Hub redirects an image blob to one of its two CDNs or to the bucket behind them, docker-images-prod.s3.dualstack.us-east-1.amazonaws.com, and picks per request. The NET-068 list named only the CDNs, so the hostname-allowlist proof failed whenever a pull was sent to the bucket: skopeo's lookup of that name was refused, as the allowlist says it must be. The host joins the shared list, the unit fixture that must exercise every entry, and the copy in the session e2e script. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 12 minutes for your next included review. View limit details
|
Contributor
|
Reviewed: 1 finding, none blocking at Address the comments on the diff. Clobber: none seen. |
norrietaylor
added a commit
that referenced
this pull request
Nov 17, 2026
…-vm-box-is-not Resolve the S3 blob host conflicts in favour of main's #3498.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The toolchain egress allowlist (NET-068) names Docker Hub's two CDN hosts for image blobs. Docker Hub also redirects a blob to the bucket behind them,
docker-images-prod.s3.dualstack.us-east-1.amazonaws.com, and picks per request. This adds that host to the shared list, to the unit fixture that must exercise every entry, and to the copy in the session e2e script.Why
The KVM test
hostname_allowlist_toolchain_completesfails whenever a pull is sent to the bucket: the lookup of that name is refused, as the allowlist says it must be, and the image pull fails. It is intermittent because the redirect target varies, and it has blocked unrelated PRs (two failures in a row on #3265).Testing
The proof that the flake is gone is the KVM job over time; one green run does not show it.
🤖 Generated with Claude Code