Skip to content

fix(minimal-client): extend loadout compose RPC deadline - #3400

Closed
norrietaylor with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-macos-e2e-activate-timeout
Closed

norrietaylor with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-macos-e2e-activate-timeout

Conversation

Copilot AI commented Nov 13, 2026 •

Copy link
Copy Markdown

Summary

ConfigureLoadout can exceed the generic 60-second RPC deadline while resolving a project graph. Give loadout composition a dedicated five-minute deadline across session activation, task run, and dashboard creation.

  • Use the existing per-RPC deadline mechanism:
    client.oneshot_rpc_with_deadline::<ConfigureLoadout>(
        request,
        minimal_client::LOADOUT_COMPOSE_TIMEOUT,
    )
  • Leave the generic timeout for other RPCs unchanged.

Testing

Not run; just is unavailable in this environment.

Checklist

  • Docs updated if behavior changed
  • BREAKING CHANGE: footer present if this is a breaking change

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 508da971-02f6-4107-8803-7f2e564d4165

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Co-authored-by: norrietaylor <91171431+norrietaylor@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Fix flaky macOS e2e activate timeout in ConfigureLoadout fix(minimal-client): extend loadout compose RPC deadline Nov 13, 2026
Copilot AI requested a review from norrietaylor November 13, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky: macOS e2e activate times out in ConfigureLoadout after 60s

3 participants