Repository navigation
docs(specs): the telemetry spec's known gaps are not dated - #3542
Conversation
The sentence named 2026-10-07, which stopped describing the list once TEL-034 left it. It now says "today", so it stays true as entries leave. Refs #3505 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 48 minutes for your next included review. View limit details
|
|
Approved: no findings at Nothing to do. Clobber: none. |
norrietaylor
left a comment
There was a problem hiding this comment.
No findings. The undated sentence is accurate at the PR head: the paragraph's gaps (TEL-009, TEL-044, TEL-047, and TEL-032 on macOS in the macOS sentence) match KNOWN_GAPS in crates/mlog/tests/otel_requirements.rs, whose doc comment says the list matches this paragraph. TEL-034 is no longer in either list, so the old 2026-10-07 date did describe a different list. The sentence keeps the gaps tied to the code rather than to a date, so it stays correct as entries leave. Prose: the changed line has no stated count (inventory.StatedCount) and adds no new terms. I could not run Vale here, so this is a manual check.
Generated by Claude Code
What
The sentence that introduces the telemetry spec's known gaps says "today" where it named 2026-10-07.
Refs #3505 (a review note there).
Why
The date stopped describing the list when TEL-034 left it. An undated sentence stays true as entries leave.
Scope
One sentence of
docs/specs/25-spec-telemetry/25-spec-telemetry.md. No requirement changes.🤖 Generated with Claude Code