Skip to content

docs(specs): the telemetry spec's known gaps are not dated - #3542

Merged
bryan-minimal merged 1 commit into
mainfrom
docs/tel-known-gaps-undated
Nov 19, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
docs/tel-known-gaps-undated

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

What

The sentence that introduces the telemetry spec's known gaps says "today" where it named 2026-10-07.

Refs #3505 (a review note there).

Why

The date stopped describing the list when TEL-034 left it. An undated sentence stays true as entries leave.

Scope

One sentence of docs/specs/25-spec-telemetry/25-spec-telemetry.md. No requirement changes.

🤖 Generated with Claude Code

The sentence named 2026-10-07, which stopped describing the list once
TEL-034 left it. It now says "today", so it stays true as entries leave.

Refs #3505

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 18, 2026 17:06
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 48 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 66ef30f6-3a24-4503-a0c4-3f4404777bf3
Commits

Reviewing files that changed from the base of the PR and between ff906b9 and 2ba9cea.

Files selected for processing: 1

  • docs/specs/25-spec-telemetry/25-spec-telemetry.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry

minimal-foundry Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at 2ba9ceab6afc.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 18, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. The undated sentence is accurate at the PR head: the paragraph's gaps (TEL-009, TEL-044, TEL-047, and TEL-032 on macOS in the macOS sentence) match KNOWN_GAPS in crates/mlog/tests/otel_requirements.rs, whose doc comment says the list matches this paragraph. TEL-034 is no longer in either list, so the old 2026-10-07 date did describe a different list. The sentence keeps the gaps tied to the code rather than to a date, so it stays correct as entries leave. Prose: the changed line has no stated count (inventory.StatedCount) and adds no new terms. I could not run Vale here, so this is a manual check.


Generated by Claude Code

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 8049518 Nov 19, 2026
41 checks passed
@bryan-minimal
bryan-minimal deleted the docs/tel-known-gaps-undated branch November 19, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants