Skip to content

fix(minimal): the sign-in page's "Change which repositories" link opens the App's install page - #3590

Merged
norrietaylor merged 1 commit into
mainfrom
agent/3545-the-sign-in-page-s-change-which-repositories-lin
Nov 19, 2026
Merged

norrietaylor merged 1 commit into
mainfrom
agent/3545-the-sign-in-page-s-change-which-repositories-lin

Conversation

@minimal-foundry

Copy link
Copy Markdown
Contributor

Follow-up

Fixes #3545

  • Epic: none; not charged to an epic
  • Size: S; estimated 5 code, 5 tests
  • May touch:
    • crates/minimal/src/cmd/auth.rs
Task marker
### D3544 — The sign-in page's "Change which repositories" link opens the App's install page, which lists organization installations
  kind: task
  size: S
  est: 5 code, 5 tests
  executor: agent
  origin: bug
  layers:
    - auth:
      - crates/minimal/src/cmd/auth.rs: Page::signed_in links "Change which repositories" to INSTALL_URL (https://github.com/apps/gominimal/installations/new) in place of SETTINGS_URL; removes SETTINGS_URL and fixes its doc comment if nothing else uses it; browser_page_names_the_installed_accounts pins the new href
      test: cargo test -p minimal browser_page_names_the_installed_accounts
  proof: After a sign-in that reaches only organization installations, the success page's "Change which repositories" link opens GitHub's install page for the Minimal GitHub App, which lists those organizations, and each opens its installation's configure page.

Proof

After a browser sign-in, the success page's "Change which repositories" link now opens https://github.com/apps/gominimal/installations/new. That GitHub page lists every account and organization with the Minimal GitHub App, and each entry opens its installation's configure page. The test browser_page_names_the_installed_accounts pins the new href.

Notes from the agent: SETTINGS_URL had no other user, so I removed it. I extended the INSTALL_URL doc comment to say the page also lists the existing installations. I did not check the GitHub page behaviour live from this box. The proof relies on GitHub's install page listing organization installations.

Tests

line exit tail
cargo test -p minimal browser_page_names_the_installed_accounts 0 running 1 test test cmd::auth::tests::browser_page_names_the_installed_accounts ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1023 filtered out; finished in 0.08s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 41 filtered out; finished in 0.00s

Verify

min task run agent-verify exited 100, so this PR is a draft.

 {
                "parent_span_id": "cb5ef96e1b030283",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "6da4fbe27e0a28c0",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "6da4fbe27e0a28c0",
                "queued_behind": "0",
                "span_id": "b51e5693f9a81313",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "cb5ef96e1b030283",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "0faafc4bfbb05d07",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "0faafc4bfbb05d07",
                "queued_behind": "0",
                "span_id": "e5b8b1153d12c6b0",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "0faafc4bfbb05d07",
                "queued_behind": "0",
                "span_id": "2d053f280f168f97",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "2d053f280f168f97",
                "span_id": "ed09b31355636c7d",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "2d053f280f168f97",
                "queued_behind": "0",
                "span_id": "3703062731a0cd76",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  81.617s] 1194 tests run: 1193 passed, 1 failed, 2 skipped
        FAIL [  12.908s] (1194/1194) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

The settings page lists only personal installations, so a sign-in that
reached only organization installations led nowhere useful. The App
install page lists every account that has the App.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c1748ebc-4340-45f0-b341-ff7a018786c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@norrietaylor
norrietaylor marked this pull request as ready for review November 18, 2026 22:52
@norrietaylor
norrietaylor requested a review from a team as a code owner November 18, 2026 22:52
@norrietaylor

Copy link
Copy Markdown
Member

Un-drafted: the agent-verify exit 100 comes from a minimald trace-span test, outside this diff, which changes only crates/minimal/src/cmd/auth.rs. The lanes are green.

@norrietaylor

Copy link
Copy Markdown
Member

/review

@minimal-foundry

minimal-foundry Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Approved: no findings at 709c7f7819db.

Nothing to do.

Clobber: none.

@norrietaylor

Copy link
Copy Markdown
Member

/arch-review

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 18, 2026
@norrietaylor

Copy link
Copy Markdown
Member

/arch-review

@norrietaylor

Copy link
Copy Markdown
Member

/review

@norrietaylor

Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The design of record does not specify the sign-in success page or the URL of its "Change which repositories" link. This is a pass by absence. The change stays in crates/minimal/src/cmd/auth.rs and removes SETTINGS_URL, which has no other user. The test pins the new href. This ruling agrees with the earlier rulings on this head.

Ruled at 709c7f7 against gominimal/arch@327e1b57d16b by claude-opus-5-5.

@norrietaylor

Copy link
Copy Markdown
Member

/review

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Page::signed_in now points "Change which repositories" at INSTALL_URL (https://github.com/apps/gominimal/installations/new). That is the same URL the "Choose repositories" button and the terminal's next-step line already use. GitHub's install page lists every account and organization that has the App, each with a link to its configure page, so the link now reaches organization installations, which https://github.com/settings/installations did not. SETTINGS_URL had no other user, and no doc in the tree references the old URL. browser_page_names_the_installed_accounts pins the new href. The link text and the user-facing sentences are unchanged.


Generated by Claude Code

@norrietaylor
norrietaylor added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 9566c56 Nov 19, 2026
40 checks passed
@norrietaylor
norrietaylor deleted the agent/3545-the-sign-in-page-s-change-which-repositories-lin branch November 19, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

D3544 — The sign-in page's "Change which repositories" link opens the App's install page, which lists organization installations

1 participant