Repository navigation
fix(minimal): the sign-in page's "Change which repositories" link opens the App's install page - #3590
Conversation
The settings page lists only personal installations, so a sign-in that reached only organization installations led nowhere useful. The App install page lists every account that has the App.
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Un-drafted: the |
|
/review |
|
Approved: no findings at Nothing to do. Clobber: none. |
|
/arch-review |
|
/arch-review |
|
/review |
|
/arch-review |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The design of record does not specify the sign-in success page or the URL of its "Change which repositories" link. This is a pass by absence. The change stays in crates/minimal/src/cmd/auth.rs and removes SETTINGS_URL, which has no other user. The test pins the new href. This ruling agrees with the earlier rulings on this head.
Ruled at 709c7f7 against gominimal/arch@327e1b57d16b by claude-opus-5-5.
|
/review |
norrietaylor
left a comment
There was a problem hiding this comment.
No findings. Page::signed_in now points "Change which repositories" at INSTALL_URL (https://github.com/apps/gominimal/installations/new). That is the same URL the "Choose repositories" button and the terminal's next-step line already use. GitHub's install page lists every account and organization that has the App, each with a link to its configure page, so the link now reaches organization installations, which https://github.com/settings/installations did not. SETTINGS_URL had no other user, and no doc in the tree references the old URL. browser_page_names_the_installed_accounts pins the new href. The link text and the user-facing sentences are unchanged.
Generated by Claude Code
Follow-up
Fixes #3545
crates/minimal/src/cmd/auth.rsTask marker
Proof
After a browser sign-in, the success page's "Change which repositories" link now opens https://github.com/apps/gominimal/installations/new. That GitHub page lists every account and organization with the Minimal GitHub App, and each entry opens its installation's configure page. The test browser_page_names_the_installed_accounts pins the new href.
Notes from the agent: SETTINGS_URL had no other user, so I removed it. I extended the INSTALL_URL doc comment to say the page also lists the existing installations. I did not check the GitHub page behaviour live from this box. The proof relies on GitHub's install page listing organization installations.
Tests
cargo test -p minimal browser_page_names_the_installed_accountsVerify
min task run agent-verifyexited 100, so this PR is a draft.