Repository navigation
test(otel): close the tel-034 known gap, the kvm lane runs its vm tests - #3505
Conversation
The Linux KVM lane runs every minvmd `_integration` harness with `--run-ignored all` and MINVMD_E2E=1, so both TEL-034 VM tests already run and pass on main: the_guest_daemons_records_reach_the_host_spool_and_endpoint_over_vsock and a_boot_and_stop_share_one_trace_with_the_guest_daemon. Remove the TEL-034 entry from KNOWN_GAPS and its known_gap test, drop the sentence from the spec's known-gaps paragraph, and note on the TEL-034 test list that the KVM lane runs both. Fixes #2034 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Approved: no findings at Nothing to do. Clobber: none. |
norrietaylor
left a comment
There was a problem hiding this comment.
Checked the claim against the tree: test-kvm exports MINVMD_E2E=1 job-wide and runs every *_integration binary with --run-ignored all --no-tests=fail, which picks up both otel_vsock_integration and otel_integration; skip_or_fail asserts rather than skips under MINVMD_E2E=1, so a pass there is a real run. The gap entry and its known_gap test leave together, so every_known_gap_is_listed_once_and_has_its_test still holds. One nit inline.
| @@ -124,8 +124,7 @@ workflow is a maintainer-owned change (gominimal/minimal#2075). A test marked | |||
| and its issue, and fails on request (`TEST_KNOWN_GAPS=1`) so a lane can | |||
| list the gaps. It is removed when the requirement gets a real test. These | |||
| are the known gaps on 2026-10-07, each with an issue to follow. TEL-009 | |||
There was a problem hiding this comment.
[nit] With TEL-034 removed, "the known gaps on 2026-10-07" no longer describes the list as of that date. Fine to leave for the follow-up pass you mention; dropping the date (or saying "the known gaps today") would keep the sentence true as entries leave.
There was a problem hiding this comment.
Yes. The follow-up pass over that section drops the date, so the sentence stays true as entries leave.
…#3542) The sentence named 2026-10-07, which stopped describing the list once TEL-034 left it. It now says "today", so it stays true as entries leave. Refs gominimal#3505 Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
What
Removes the TEL-034 "known gap" record: its entry and placeholder test in
crates/mlog/tests/otel_requirements.rs, and the sentence in spec 25's known-gaps paragraph. The TEL-034 test note now says the Linux KVM lane runs both tests.Fixes #2034.
Why it is no longer a gap
The gap said the guest telemetry path over vsock had no CI lane. It has one: the Linux KVM job sets the switch that enables these tests and runs every integration harness, which includes both.
Evidence from main, run 44036382383 (2026-11-17), job
test-kvm:The run before it passed both too.
Scope
17 lines removed, 2 added. No product code. The entry and its test leave together, as the file's own rule asks, so the two tests that check the list still hold.
Not changed here: the paragraph still dates the known gaps "on 2026-10-07", and a few neighbouring sentences are out of date (the other gaps' issues are filed;
min box specexists). Those are for a separate pass.A note for later
CI runs the
known_gap_*placeholder tests without the switch that makes them meaningful, so they always pass and nothing notices when a gap has closed. That is how this one stayed listed.🤖 Generated with Claude Code
Summary by CodeRabbit