Skip to content

test(otel): close the tel-034 known gap, the kvm lane runs its vm tests - #3505

Merged
bryan-minimal merged 1 commit into
mainfrom
fix/tel-034-gap-closed
Nov 18, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
fix/tel-034-gap-closed

Conversation

@bryan-minimal

@bryan-minimal bryan-minimal commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

What

Removes the TEL-034 "known gap" record: its entry and placeholder test in crates/mlog/tests/otel_requirements.rs, and the sentence in spec 25's known-gaps paragraph. The TEL-034 test note now says the Linux KVM lane runs both tests.

Fixes #2034.

Why it is no longer a gap

The gap said the guest telemetry path over vsock had no CI lane. It has one: the Linux KVM job sets the switch that enables these tests and runs every integration harness, which includes both.

Evidence from main, run 44036382383 (2026-11-17), job test-kvm:

PASS [11.288s] minvmd::otel_integration a_boot_and_stop_share_one_trace_with_the_guest_daemon
PASS [ 3.275s] minvmd::otel_vsock_integration the_guest_daemons_records_reach_the_host_spool_and_endpoint_over_vsock

The run before it passed both too.

Scope

17 lines removed, 2 added. No product code. The entry and its test leave together, as the file's own rule asks, so the two tests that check the list still hold.

Not changed here: the paragraph still dates the known gaps "on 2026-10-07", and a few neighbouring sentences are out of date (the other gaps' issues are filed; min box spec exists). Those are for a separate pass.

A note for later

CI runs the known_gap_* placeholder tests without the switch that makes them meaningful, so they always pass and nothing notices when a gap has closed. That is how this one stayed listed.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that real-VM telemetry integration tests require an explicit setting and run in the Linux KVM CI lane.
    • Separated TEL-034 coverage details from TEL-009, which now identifies only its lab scenario.
  • Tests
    • Removed the TEL-034 known-gap test entry.

The Linux KVM lane runs every minvmd `_integration` harness with
`--run-ignored all` and MINVMD_E2E=1, so both TEL-034 VM tests already
run and pass on main:
the_guest_daemons_records_reach_the_host_spool_and_endpoint_over_vsock
and a_boot_and_stop_share_one_trace_with_the_guest_daemon.

Remove the TEL-034 entry from KNOWN_GAPS and its known_gap test, drop
the sentence from the spec's known-gaps paragraph, and note on the
TEL-034 test list that the KVM lane runs both.

Fixes #2034

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 17, 2026 20:57
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The TEL-034 known-gap entry and its test are removed. The telemetry specification updates the TEL-009 coverage description and notes that gated real-VM tests run in the Linux KVM CI lane.

Changes: TEL-034 Coverage Tracking

Layer / File(s) Summary
Coverage note and known-gap test
docs/specs/25-spec-telemetry/25-spec-telemetry.md, crates/mlog/tests/otel_requirements.rs
The specification removes TEL-034 coverage details from the TEL-009 paragraph and states that gated real-VM tests run in the Linux KVM CI lane. The test suite removes the TEL-034 known-gap entry and test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: norrietaylor, mitodrummer

Merge Risk: Minimal · up to d7a94

This is a documentation and test-tracking cleanup with no product code changes. It is low risk to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title uses Conventional Commit form (test(otel): ...) and names the main change: closing the TEL-034 known gap because the KVM lane runs its VM tests. It is specific and matches the objectives, wh…
Description check Passed The description follows the repository template's main sections. The Summary section (under '## What' and '## Why it is no longer a gap') explains the change and links the issue with 'Fixes #2034'. Th…
Linked Issues check Passed [#2034] requires that the guest telemetry vsock test run in the Linux KVM CI lane, then that the TEL-034 known gap be dropped. At head, .github/workflows/ci-linux-kvm.yml sets MINVMD_E2E=1 in the …
Out of Scope Changes check Passed All changes support the TEL-034 gap removal required by [#2034]. The otel_requirements.rs diff removes only the TEL-034 KnownGap entry and its placeholder test. The spec 25 edits remove the TEL-03…
Full details: Title check

Explanation

The title uses Conventional Commit form (test(otel): ...) and names the main change: closing the TEL-034 known gap because the KVM lane runs its VM tests. It is specific and matches the objectives, which remove the gap entry and test and update the test note. It is slightly long at 71 characters, but this does not affect the verdict.

Full details: Description check

Explanation

The description follows the repository template's main sections. The Summary section (under '## What' and '## Why it is no longer a gap') explains the change and links the issue with 'Fixes #2034'. The Testing section is covered by the CI run evidence showing both tests passing. The description notes the scope and the follow-up items. The template's checklist items (docs updated, BREAKING CHANGE footer) are not explicitly addressed. The spec 25 doc is updated in the diff, so the docs item is largely met. No breaking change is claimed, so the footer does not apply. The headings differ from the template ('What', 'Why', 'Scope', 'A note for later' instead of 'Summary', 'Testing', 'Checklist'). Testing evidence is present but not labeled as a Testing section. Overall the description is mostly complete.

Full details: Linked Issues check

Explanation

[#2034] requires that the guest telemetry vsock test run in the Linux KVM CI lane, then that the TEL-034 known gap be dropped. At head, .github/workflows/ci-linux-kvm.yml sets MINVMD_E2E=1 in the test-kvm job and points MINVMD_BIN at the shipped static minvmd. The build job archives the minvmd test binaries with cargo nextest archive, and the test job runs those archived harnesses. The PR removes the TEL-034 KnownGap entry and its known_gap_tel_034_* placeholder test from crates/mlog/tests/otel_requirements.rs (diff confirmed, -14 lines, no product code). The PR cites main run 44036382383, where test-kvm reports PASS for minvmd::otel_vsock_integration the_guest_daemons_records_reach_the_host_spool_and_endpoint_over_vsock and minvmd::otel_integration a_boot_and_stop_share_one_trace_with_the_guest_daemon. Limitation: the job's filterset lines fall past the read truncation point, so I did not confirm from repository source that the filterset selects otel_vsock_integration. The run output cited in the PR is the evidence for that.

Full details: Out of Scope Changes check

Explanation

All changes support the TEL-034 gap removal required by [#2034]. The otel_requirements.rs diff removes only the TEL-034 KnownGap entry and its placeholder test. The spec 25 edits remove the TEL-034 sentence from the known-gaps paragraph and update the TEL-034 integration-test note to state that the real-VM tests run in the Linux KVM CI lane. The PR description states that it leaves the paragraph date and other outdated neighbouring sentences unchanged. No unrelated code or product changes were identified.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Vale (3.24.0)

{
"Line": 13,
"Path": ".vale.ini",
"Text": "Style 'ste' isn't on the StylesPath (/styles). If it's a package, run vale sync.",
"Code": "E201",
"Span": 23
}

A rabbit checks the test notes twice
TEL-034 leaves the gap list neat
Real VMs wait for KVM’s cue
The spec records their testing lane
Then hops away on quiet feet

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 0b9f8737-3b53-4329-abcd-4bfd632dd712
Commits

Reviewing files that changed from the base of the PR and between 6c0718d and d7a94de.

Files selected for processing: 2

  • crates/mlog/tests/otel_requirements.rs
  • docs/specs/25-spec-telemetry/25-spec-telemetry.md
Files with no reviewable changes: 1

  • crates/mlog/tests/otel_requirements.rs

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 0 remain after this review.

@minimal-foundry

minimal-foundry Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Approved: no findings at d7a94de83cac.

Nothing to do.

Clobber: none.

@minimal-foundry minimal-foundry Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 17, 2026

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the claim against the tree: test-kvm exports MINVMD_E2E=1 job-wide and runs every *_integration binary with --run-ignored all --no-tests=fail, which picks up both otel_vsock_integration and otel_integration; skip_or_fail asserts rather than skips under MINVMD_E2E=1, so a pass there is a real run. The gap entry and its known_gap test leave together, so every_known_gap_is_listed_once_and_has_its_test still holds. One nit inline.

@@ -124,8 +124,7 @@ workflow is a maintainer-owned change (gominimal/minimal#2075). A test marked
and its issue, and fails on request (`TEST_KNOWN_GAPS=1`) so a lane can
list the gaps. It is removed when the requirement gets a real test. These
are the known gaps on 2026-10-07, each with an issue to follow. TEL-009

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] With TEL-034 removed, "the known gaps on 2026-10-07" no longer describes the list as of that date. Fine to leave for the follow-up pass you mention; dropping the date (or saying "the known gaps today") would keep the sentence true as entries leave.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The follow-up pass over that section drops the date, so the sentence stays true as entries leave.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 4bd4ce8 Nov 18, 2026
41 checks passed
@bryan-minimal
bryan-minimal deleted the fix/tel-034-gap-closed branch November 18, 2026 02:43
yermakoffivan pushed a commit to yermakoffivan/minimal that referenced this pull request Nov 19, 2026
…#3542)

The sentence named 2026-10-07, which stopped describing the list once
TEL-034 left it. It now says "today", so it stays true as entries leave.

Refs gominimal#3505

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TEL-034: a CI lane for the guest telemetry path over vsock

2 participants