Repository navigation
fix(installer): better handle case where shell dir is not writeable - #714
Conversation
📝 WalkthroughWalkthroughThe installer now suppresses raw redirection permission errors while warning and continuing when rc-hook or shell-completion destinations are unwritable. The specification and proof tests verify exit status, warning content, continued completion generation, and clean output. ChangesInstaller permission handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/install_test.sh`:
- Around line 458-459: The install test only verifies bash completion after the
fish failure; extend the same “other shells’ completions still installed (R9.3)”
assertion block to also check the expected zsh completion file path, using the
appropriate zsh path variable and filename.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a8796f70-bb0c-4804-9bdc-585ec6e7daf9
📒 Files selected for processing (3)
docs/specs/07-spec-installer/07-spec-installer.mdscripts/install.shscripts/install_test.sh
| want_ok "other shells' completions still installed (R9.3)" \ | ||
| test -f "$H13/xdg-data/bash-completion/completions/min" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Assert zsh completion too.
The test currently proves only that bash completion continues after fish fails; a zsh-specific regression could still pass. Add an assertion for the expected zsh completion path.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/install_test.sh` around lines 458 - 459, The install test only
verifies bash completion after the fish failure; extend the same “other shells’
completions still installed (R9.3)” assertion block to also check the expected
zsh completion file path, using the appropriate zsh path variable and filename.
Summary by CodeRabbit