Skip to content

feat(bep): add bep serve for the listener and the control socket

Minimal Arch / arch-review failed Oct 21, 2026 in 0s

CONDITIONS

Governs: Gatehouse §6.10. Line 857 and line 833 cover the listener and node binding. Line 839 says box attribution comes from the host-side creator. Line 823 covers proxy_env CONNECT bounded to the module host sets (off_module), pass-through that is "egress-checked … audited", and "every admit/refuse" audited. Line 819 is the HTTP/1.1 digest. Networking §5.7 rows 208–209 give the BEP's ALPN downgrade and the proxy_env surface. architecture.md line 501 is the per-box audit read. The checkout at 109541a4 has no arch-map.md, so I worked from the headings.

Ruling: each covered requirement conforms. The listener refuses non-box connections before any byte. The box id comes from switch::bep_host, which runs host side in minvmd, so PeerAttested agrees with line 839. Both TLS legs offer http/1.1 alone, the upstream validates against the host roots, and off-set CONNECTs and absolute-form requests are refused off_module under the box's id. The conditions concern the interim. relay() carries requests with no egress check, no redemption and no admit record. That is against line 823, and only NoSigningKey keeps production away from it. The PR gives the flip as 'replace NoSigningKey when #2440 lands', and that flip alone opens the ungated path (rules 2 and 7). C1 binds the flip to the redemption wiring and its issue. C2 names the owner of the missing store authorities (rule 6).

Observations, not conditions: an absolute-form https:// target to a credentialed host gets marker upstream_not_tls and the text 'Use https://host/ in place of https://host/'. The marker is not exact, because that request would not ride a plaintext leg, and the message tells the user nothing. That is for minimal-review or the spec. The 501/505/origin-form refusals write no audit record. The spec gives them no marker, so I did not make this a condition. bind_owner_only sets 0700 only on a directory it creates.

Not checked: whether issue #2440 exists and is open, and whether an issue for the redemption wiring exists. The sandbox has no gh. The PR body is truncated at note 5. I did not build or run the tests.

Conditions

  • C1: Make the NoSigningKey interim state its true flip condition. Today crates/bep/src/proxy.rs relay() (called from Proxy::connect, line 493) sends every request head in an admitted tunnel upstream. It does no egress check, no redemption, and writes no admit Decision. Only NoSigningKey keeps bep serve from reaching it. Edit three places. (a) In crates/bep/src/main.rs, the NoSigningKey doc comment and the startup tracing::warn! line must say that the issuer can be replaced only when #2440 has landed AND each head in relay() goes through the redemption decision (redeem::decide / decide_plain with the box's declared egress) with one audit record per admit and per refusal. Link the issue that owns that wiring (file it if none exists). (b) Remove the PR note's flip condition 'when #2440 lands, replace NoSigningKey' and use the text from (a). (c) Add a doc comment on relay() that says it forwards with no decision and must not be reachable from bep serve until that issue lands. Link the same issue.
  • C2: crates/bep/src/main.rs serve(): give the comment above Admission::new(&[GITHUB], [("", 0); 0]) (line 235) the issue that owns reading [secret-store-rules] at start. Also make the comment say that until that issue lands, a CONNECT to a registered store authority is refused and audited off_module. Today the comment names no owner for that work.

Ruled at 43493c0 against gominimal/arch@109541a48c31 by claude-opus-5-5; arch_rulings 139, job 9d31f18c-08c2-4dca-9674-d9077917e0b4.