Repository navigation
Update libkrun to 1.19.7 - #1018
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
…es with -F0
0001's update_peer_credit hunk no longer matched 1.19.7 at zero fuzz:
upstream added an early return after the fwd_cnt update ("virtio/vsock:
preserve TCP half-close semantics"). build.sh's plain `patch -Np1` allows
fuzz 2, so the hunk applied anyway, at a site its context no longer
pinned, and the build stayed green.
The rebased hunk puts drain_forwarded() right after the fwd_cnt update and
BEFORE the new early return, so every credit update retires forwarded
packets (otherwise a connected stream never drains `outstanding` and stalls
once it reaches the skb ceiling). Every other hunk is unchanged apart from
offsets. 0002 already applied cleanly.
build.sh now applies both with -F0, so a stale hunk fails the build.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Rebased What went wrong. The updater called 0001 a conflict ("neither direction applies") because hunk #9 failed at self.peer_fwd_cnt = Wrapping(pkt.fwd_cnt());
if self.status != ProxyStatus::WaitingCreditUpdate || self.peer_avail_credit() == 0 {
return ProxyUpdate::default();
}The hunk's trailing context ( Where it goes now. The other 10 hunks are unchanged apart from offsets, including both Verification. build-bot run Left as a draft for review. Not merged. |
|
Correction to the comment above: with GNU patch, the original fuzzed apply was actually in the right place. A Cloud Build sweep (
The wrong-function placement (inside The change still matters:
|
Update libkrun
1.19.6→1.19.7Source:
github:libkrun/libkrun:operator-pinnedRelease: https://github.com/libkrun/libkrun/releases/tag/v1.19.7
Changelog: libkrun/libkrun@v1.19.6...v1.19.7
Released: 1 days ago (2026-10-22)
Warning
Carried patches will break this build — opened as a draft. Fix the recipe before merging.
0001-vsock-bound-outstanding-packets.patchneither applies nor reverse-applies to 1.19.7 (patch -p1 --dry-run): rebase it onto 1.19.7 or drop it.Forward dry-run:
Reverse dry-run:
Carried patches vs 1.19.7
Each
| Localpatch was dry-run against the extracted 1.19.7 tree: forward as build.sh applies it (patch -N), and reverse with exact context (patch -R -F0). Only a patch that reverse-applies WHOLE is treated as upstream; a partial match is a conflict.0001-vsock-bound-outstanding-packets.patch— neither direction applies to 1.19.7 (see the warning above).0002-vsock-refuse-stream-when-unix-proxy-creation-fails.patch— still applies forward to 1.19.7.Components changed
CycloneDX component delta (declared materials — the package's own version, not a dependency-tree diff)
libkrun1.19.61.19.7libkrun-upstream1.19.61.19.7Changes
1.19.61.19.77025d72208172dc0...d4541fcd959ad43f...https://github.com/libkrun/libkrun/archive/refs/tags/v1.19.6.tar.gzhttps://github.com/libkrun/libkrun/archive/refs/tags/v1.19.7.tar.gzApache-2.0(source: GitHub + tarball)🔒 TLS:
github.com— Sectigo Public Server Authentication CA DV E36 → Sectigo Public Server Authentication Root E46 (rootc90f26f0fb1b4018…) ⇒codeload.github.com— Sectigo Public Server Authentication CA DV E36 → Sectigo Public Server Authentication Root E46 (rootc90f26f0fb1b4018…)Quality suggestions
testsblock. This package has no standalone tests, so the buildbot will only verify compilation — not functional correctness. Consider adding a minimal smoke test (e.g., a--versionor small round-trip invocation) as part of this PR so future bumps catch regressions. Seepackages/python/build.nclfor a simple example.Created by pkgmgr