Skip to content

Update nickel-lsp to 1.18.0 - #1187

Merged
bryan-minimal merged 4 commits into
mainfrom
update-nickel-lsp-1.18.0
Nov 2, 2026
Merged

bryan-minimal merged 4 commits into
mainfrom
update-nickel-lsp-1.18.0

Conversation

@gominimal-pkgmgr-mgr

Copy link
Copy Markdown
Contributor

Update nickel-lsp 1.17.0 → 1.18.0

Source: github:nickel-lang/nickel
Release: https://github.com/nickel-lang/nickel/releases/tag/1.18.0
Changelog: nickel-lang/nickel@1.17.0...1.18.0
Released: 40 days ago (2026-09-19)

Caution

Security floor not met: rustls-webpki 0.103.13 < 0.103.16 (CVE-2026-111943 / RUSTSEC-2026-0382); webpki-root-certs 1.0.7 < 1.0.10 (CVE-2026-111943 / RUSTSEC-2026-0383) — cve-2026-111943-webpki-lock.patch no longer applies to 1.18.0's own Cargo.lock, and that lock is still below the floor (data/security_floors.toml in pkgmgr-rs). Regenerate the lock delta against 1.18.0 (cargo update -p <crate> --precise <fixed>, resolution only) and keep the build.sh guard; do NOT drop the patch.

Warning

Carried patches will break this build — opened as a draft. Fix the recipe before merging.

  • cve-2026-111943-webpki-lock.patch neither applies nor reverse-applies to 1.18.0 (patch -p1 --dry-run): rebase it onto 1.18.0 or drop it.

Forward dry-run:

checking file Cargo.lock
Hunk #1 FAILED at 4756.
Hunk #2 FAILED at 6112.
2 out of 2 hunks FAILED

Reverse dry-run:

checking file Cargo.lock
Hunk #1 FAILED at 4756.
Hunk #2 FAILED at 6112.
2 out of 2 hunks FAILED

Carried patches vs 1.18.0

Each | Local patch was dry-run against the extracted 1.18.0 tree, forward and reverse, both with exact context (patch -N -F0, patch -R -F0). Only a patch that reverse-applies WHOLE is treated as upstream; a partial match is a conflict, and one that applies forward only with fuzz is reported as such.

  • Conflict cve-2026-111943-webpki-lock.patch — neither direction applies to 1.18.0 (see the warning above). Security floors 1.18.0's own lock misses: rustls-webpki 0.103.13 < 0.103.16 (CVE-2026-111943 / RUSTSEC-2026-0382); webpki-root-certs 1.0.7 < 1.0.10 (CVE-2026-111943 / RUSTSEC-2026-0383).

Pkgscan: clean — diff against the prior version surfaced no newly-introduced suspicious patterns.

Components changed

CycloneDX component delta (declared materials — the package's own version, not a dependency-tree diff)
Component Old New
~ nickel-lsp 1.17.0 1.18.0
~ nickel-lsp-upstream 1.17.0 1.18.0

Changes

Old New
Version 1.17.0 1.18.0
SHA256 8cc47b3a2b9ed4e3... ddcac13684c1fc17...
Size 1.3 MB
Source https://github.com/nickel-lang/nickel/archive/refs/tags/1.17.0.tar.gz https://github.com/nickel-lang/nickel/archive/refs/tags/1.18.0.tar.gz
  • License: MIT (source: GitHub + tarball)

🔒 TLS: github.com — Sectigo Public Server Authentication CA DV E36 → Sectigo Public Server Authentication Root E46 (root c90f26f0fb1b4018…) · TLSv1_3 · TLS13_AES_128_GCM_SHA256 · X25519 ⇒ codeload.github.com — Sectigo Public Server Authentication CA DV E36 → Sectigo Public Server Authentication Root E46 (root c90f26f0fb1b4018…) · TLSv1_3 · TLS13_AES_128_GCM_SHA256 · X25519

Quality suggestions

  • Missing tests block. This package has no standalone tests, so the buildbot will only verify compilation — not functional correctness. Consider adding a minimal smoke test (e.g., a --version or small round-trip invocation) as part of this PR so future bumps catch regressions. See packages/python/build.ncl for a simple example.

Created by pkgmgr

@gominimal-pkgmgr-mgr gominimal-pkgmgr-mgr Bot added auto-update Opened autonomously by pkgmgr auto-update auto-update-review Freshness bump the leaf policy wants a human to read (major bump or a few dependents) labels Oct 29, 2026
@gominimal-pkgmgr-mgr

Copy link
Copy Markdown
Contributor Author

Opened for review by pkgmgr auto-update (a freshness update; it clears no advisory). The leaf policy did not auto-approve it because:

  • 2 direct / 2 transitive dependents — a break cascades

To defer it, leave a comment rather than closing: a closed auto-update PR currently marks the package declined, which also stops its future auto-updates.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

bryan-minimal and others added 2 commits October 31, 2026 17:26
…1.18.0)

cve-2026-111943-webpki-lock.patch no longer applied to 1.18.0's Cargo.lock
(rustls-webpki 0.103.13, webpki-root-certs 1.0.7, aws-lc-rs 1.17.0). Replaced
with `pkgmgr lock-patch nickel-lsp --replace-legacy --advisory-source osv`, run
in the deployed runner image (pkgmgr 0b705d3-sc2e851aa, cargo 1.98.1) via Cloud
Build 79c2d555. Base lock sha256 2fdafec3...3ec2.

Floors met: rustls-webpki 0.103.16, webpki-root-certs 1.0.10 (CVE-2026-111943),
plus anyhow, crossbeam-epoch, cxx, faster-hex, h2, memmap2, quinn-proto,
rustls, tokio. Companions include aws-lc-rs 1.19.0 / aws-lc-sys 0.47.0.
Unresolved, left to a human (header): bitmaps 3.2.1 (no fixed release),
imbl-sized-chunks 0.1.3, quick-xml 0.26.0 / 0.38.3 (semver-incompatible fixes).

The hand patch's apply line and exact-version check go; its CVE-2026-111943
floor check stays below the generated block.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal

Copy link
Copy Markdown
Member

Replaced the hand-written cve-2026-111943-webpki-lock.patch (it no longer applied to 1.18.0's Cargo.lock) with a generated security-floors-lock.patch (commit 1194695, on top of a merge of main).

How it was produced: pkgmgr --pkgs-path <pkgs@update-nickel-lsp-1.18.0> lock-patch nickel-lsp --replace-legacy --advisory-source osv, run in the deployed runner image pkgmgr:0b705d3-sc2e851aa (cargo 1.98.1 from /opt/rust-resolve, resolution only) on Cloud Build 79c2d555. Base lock sha256 2fdafec3df7887a526b84bb95bb5ae43c25ecbd48a3da73e89d232dd0dcb3ec2; the lock was verified with cargo metadata --locked.

Floors met (from the patch header):

  • rustls-webpki 0.103.13 → 0.103.16 (RUSTSEC-2026-0382, CVE-2026-111943)
  • webpki-root-certs 1.0.7 → 1.0.10 (RUSTSEC-2026-0383, CVE-2026-111943)
  • anyhow 1.0.99 → 1.0.103 (RUSTSEC-2026-0190)
  • crossbeam-epoch 0.9.18 → 0.9.20 (RUSTSEC-2026-0204)
  • cxx 1.0.184 → 1.0.195 (RUSTSEC-2026-0202)
  • faster-hex 0.10.0 → 0.10.1 (RUSTSEC-2026-0306)
  • h2 0.4.12 → 0.4.16 (RUSTSEC-2026-0258)
  • memmap2 0.9.10 → 0.9.11 (RUSTSEC-2026-0186)
  • quinn-proto 0.11.16 → 0.11.18 (RUSTSEC-2026-0338..0342)
  • rustls 0.23.31 → 0.23.46 (RUSTSEC-2026-0285, -0346, -0348, -0349)
  • tokio 1.47.1 → 1.51.6 (RUSTSEC-2026-0386)

Companions (cargo moved these to satisfy the floors): aws-lc-rs 1.17.0 → 1.19.0, aws-lc-sys 0.41.0 → 0.47.0 (the ^1.18 requirement of rustls-webpki 0.103.16), cxx-build / cxxbridge-cmd / cxxbridge-flags / cxxbridge-macro 1.0.184 → 1.0.195, mio 1.0.4 → 1.2.4, socket2 0.6.0 → 0.6.5, tokio-macros 2.5.0 → 2.7.2, signal-hook-mio 0.2.4 → 0.2.5, autocfg 1.5.0 → 1.5.1; added defmt 0.3.101 / 1.2.0, defmt-macros 1.2.0, defmt-parser 1.1.0 (dependencies of faster-hex 0.10.1), syn 3.0.9 (via defmt-macros); removed codespan-reporting 0.12.0, io-uring 0.7.10. Also, Windows-only windows-sys entries were re-resolved; they are not built on Linux.

Unresolved: left to a human, NOT fixed by this patch. These are pre-existing, and not part of CVE-2026-111943:

  • bitmaps 3.2.1, RUSTSEC-2025-0167: no fixed release (would need a [patch.crates-io] vendored fix)
  • imbl-sized-chunks 0.1.3, RUSTSEC-2026-0292: the fix is 0.2.0, but nickel-lang-vector requires ^0.1
  • quick-xml 0.26.0, RUSTSEC-2026-0194 / -0195: the fix is 0.41.0, but inferno 0.11.21 (via pprof → nickel-lang-utils) requires ^0.26
  • quick-xml 0.38.3, RUSTSEC-2026-0194 / -0195: the fix is 0.41.0, but plist 1.8.0 (via syntect → comrak) requires ^0.38

build.sh: the generated block (base-lock sha256 check, patch -Np1 -i ./security-floors-lock.patch, version-agnostic floor checks) replaces the hand patch's apply line and exact-version check. The existing CVE-2026-111943 floor check is kept below the block.

CI:

@bryan-minimal
bryan-minimal marked this pull request as ready for review November 1, 2026 17:41
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 1, 2026 17:41
@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit f9328ce Nov 2, 2026
13 checks passed
@bryan-minimal
bryan-minimal deleted the update-nickel-lsp-1.18.0 branch November 2, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Opened autonomously by pkgmgr auto-update auto-update-review Freshness bump the leaf policy wants a human to read (major bump or a few dependents)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant