Repository navigation
SECURITY: actions-runner: distrust emSign G3 (CVE-2026-111943) - #1115
Conversation
…26-111943) The runner's externals/node20 and node24 trust their compiled-in root store, which still holds emSign ECC Root CA - G3. Both wrappers now export NODE_OPTIONS=--use-openssl-ca, so they trust OpenSSL's default store, our ca-certificates (now a runtime dep). Not done by swapping in node-lts: the runner mounts externals/ into job containers, where a symlink would dangle. A new standalone test proves the store in use through the wrapper, with a control that the bare bundled node refuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 59 minutes for your next included review. View limit details
Comment |
mitodrummer
left a comment
There was a problem hiding this comment.
Checked that the bundled Linux node20 and node24 builds set OPENSSLDIR="/etc/ssl" (deps/openssl/openssl_common.gypi), and that ca-certificates installs /etc/ssl/cert.pem, so --use-openssl-ca resolves to our store. The NODE_OPTIONS case guard respects a caller's existing store choice. The new test has a negative control (bare node must refuse), and CI is green. The container-job gap is documented.
Why
CVE-2026-111943 (eMudhra intermediate key compromise, Mozilla bug 2083449). The runner bundles its own node in
externals/node20(v20.20.2) andexternals/node24(v24.18.0). Both trust their compiled-in root store, which still holds emSign ECC Root CA - G3.That node runs every JavaScript action on the host: checkout, cache, upload-artifact, and so on. The truststore audit (pkgmgr-rs#1091, fleet run e75e32d0) lists the package as
shipped, and pkgmgr-rs#1017 tracks it.What
NODE_OPTIONS=--use-openssl-ca. That'sactions-runnerandactions-runner-config. With it, the bundled node trusts OpenSSL's default store (OPENSSLDIR=/etc/ssl), which is our ca-certificates. The flag is prepended to any existingNODE_OPTIONS. It's skipped if the caller already chose--use-openssl-caor--use-bundled-ca.ca-certificatesis now a runtime dep.nodeinrun:steps get the flag too. A workflow that sets its ownNODE_OPTIONSreplaces it for that workflow's steps. That's the one gap.bundled_node_uses_system_store. It adds a throwaway CA to a copy of the system bundle (viaSSL_CERT_FILE) and serves a leaf signed by it on 127.0.0.1. Through the wrapper, bundled node20 and node24 must connect, which only works if they read OpenSSL's store. As a control, the same bare node must refuse.Not done: swapping externals/node* for our node-lts
That was the first-choice fix, but it would break container jobs. The runner mounts
externals/into job containers at/__e(ContainerInfo.cs) and runs JS actions with/__e/node24/bin/node. A symlink to/usr/bin/nodewould dangle inside the container, and our node is linked against our glibc anyway.With this PR, container jobs keep the bundled node and the image's own store, unchanged.
docker execdoesn't pass the runner's environment.The env approach also covers two cases a binary swap wouldn't:
RUNNER_HOMEcopies. The wrapper copies/usr/lib/actions-runneronly once.node20
node20 is kept. Runner 2.336.0 already runs
node20actions on node24 by default (since 2026-06-16). It still picks node20 when a job opts out withACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true, so removing it would break that path. The flag covers node20 too.Evidence
The TLS trust harness from #976 was extended with vendor rows. The probe reaches the bundled node through
/usr/bin/actions-runner, using aRUNNER_HOMEwhoserun.shjust runs its arguments. So the probe sees exactly the environment the wrapper sets. Live mode, 12 eMudhra hosts plus 2 positives, on arm64.Before: pkgs main 44a31a3
After: this PR's head 9c26ea3
NODE_USE_SYSTEM_CA=1was also tried, in a separate probe with the same probe script. It doesn't help: both bundled nodes still connect to the emSign hosts, because that flag adds the system store to the bundled one.Other checks:
min package build --rebuild actions-runner, thenmin check. Everything passes, standalone tests included.exportline replaced by a no-op, the standalone tests read Fail. A fresh session was used for that run.amd64 is covered only by the build-bot build. The harness here runs on arm64.
🤖 Generated with Claude Code