Repository navigation
ci: notify the webapp only for pushes that change a package - #1266
Merged
Merged
Conversation
The webapp deploy waits for pkgmgr's package_deps sync to reach the dispatched sha, and pkgmgr only syncs pushes that change packages/<name>/. A CI-only push at the tip therefore failed the deploy after 15 minutes, and its notify run cancelled the pending notify for the package push before it. 8f25b19 did both, leaving prod without verus-latest (webapp RSP-113). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016CYvTuUxJ4y4DGNF1uxPvx
Contributor
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Filter workflow triggers .github/workflows/notify-webapp.yml |
The workflow now filters pushes to main by changed paths matching packages/*/**. Comments describe the filter and its relationship to pkgmgr synchronization. |
Estimated code review effort: 2 (Simple) | ~5 minutes
Possibly related PRs
- gominimal/pkgs#936: This PR also changes CI behavior. It describes deploy and debounce issues related to notifications on CI-only pushes.
Suggested reviewers: mitodrummer
Merge Risk: 
Minimal · up to 19617
-
The notification now runs only for relevant package changes, with no identified merge-blocking regression.
Pre-merge checks: 
4
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
bryan-minimal
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notify-webappnow runs only for pushes to main that change a file underpackages/<name>/.The webapp's deploy waits for pkgmgr's
package_depssync to reach the sha it was dispatched for. pkgmgr returns early from a push with no package changes (handle_pushinpkgmgr-rs/src/webhooks.rs), so that sync never comes for a CI-only orstacks/-only push. The deploy then waits 15 minutes and fails.The filter is
packages/*/**, notpackages/**, to match pkgmgr'spackage_name_from_path: a file directly inpackages/doesn't count there either.A non-package push also stops replacing a package push's deploy that is still pending in the webapp's
deploy-cloudrunconcurrency group. That happened here: #936's dispatch replaced the pending deploy forac3c9574, soverus-latestnever shipped. The original commit message blames the notify debounce for this, which is wrong: the notify run forac3c9574succeeded.Why now
#936 (
8f25b199) only changed.github/, landed at the tip, and failed webapp deploy run 41507299573 (RSP-113). The stamp stayed atac3c9574, so prod's catalog is still at985eaefdand is missing theverus-latestupdate. The next package push clears that.What the webapp loses
Nothing. The prerendered catalog comes from vulndb tables (
package_deps,pkgs_commit_history) that pkgmgr only writes on these same pushes, so a non-package push has nothing new to bake.Checks
zizmorparsed the file. Its one high finding is the existing token-permissions note on thecreate-github-app-tokenstep, which this PR doesn't change. The path filter itself can only be exercised by pushes to main.🤖 Generated with Claude Code
https://claude.ai/code/session_016CYvTuUxJ4y4DGNF1uxPvx