Skip to content

ci: notify the webapp only for pushes that change a package - #1266

Merged
mitodrummer merged 1 commit into
mainfrom
notify-webapp-package-pushes-only
Nov 3, 2026
Merged

mitodrummer merged 1 commit into
mainfrom
notify-webapp-package-pushes-only

Conversation

@agent-137

@agent-137 agent-137 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

notify-webapp now runs only for pushes to main that change a file under packages/<name>/.

The webapp's deploy waits for pkgmgr's package_deps sync to reach the sha it was dispatched for. pkgmgr returns early from a push with no package changes (handle_push in pkgmgr-rs/src/webhooks.rs), so that sync never comes for a CI-only or stacks/-only push. The deploy then waits 15 minutes and fails.

The filter is packages/*/**, not packages/**, to match pkgmgr's package_name_from_path: a file directly in packages/ doesn't count there either.

A non-package push also stops replacing a package push's deploy that is still pending in the webapp's deploy-cloudrun concurrency group. That happened here: #936's dispatch replaced the pending deploy for ac3c9574, so verus-latest never shipped. The original commit message blames the notify debounce for this, which is wrong: the notify run for ac3c9574 succeeded.

Why now

#936 (8f25b199) only changed .github/, landed at the tip, and failed webapp deploy run 41507299573 (RSP-113). The stamp stayed at ac3c9574, so prod's catalog is still at 985eaefd and is missing the verus-latest update. The next package push clears that.

What the webapp loses

Nothing. The prerendered catalog comes from vulndb tables (package_deps, pkgs_commit_history) that pkgmgr only writes on these same pushes, so a non-package push has nothing new to bake.

Checks

zizmor parsed the file. Its one high finding is the existing token-permissions note on the create-github-app-token step, which this PR doesn't change. The path filter itself can only be exercised by pushes to main.

🤖 Generated with Claude Code

https://claude.ai/code/session_016CYvTuUxJ4y4DGNF1uxPvx

The webapp deploy waits for pkgmgr's package_deps sync to reach the
dispatched sha, and pkgmgr only syncs pushes that change
packages/<name>/. A CI-only push at the tip therefore failed the deploy
after 15 minutes, and its notify run cancelled the pending notify for
the package push before it. 8f25b19 did both, leaving prod without
verus-latest (webapp RSP-113).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016CYvTuUxJ4y4DGNF1uxPvx
@agent-137
agent-137 requested a review from a team as a code owner November 2, 2026 19:45
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 8f25b19 and 196172f.

Files selected for processing: 1
  • .github/workflows/notify-webapp.yml

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

Walkthrough

The notify-webapp workflow now runs on pushes to main only when changed paths match packages/*/**. Its comments describe the filter and its relationship to pkgmgr synchronization.

Changes: Webapp notification workflow

Layer / File(s) Summary
Filter workflow triggers
.github/workflows/notify-webapp.yml
The workflow now filters pushes to main by changed paths matching packages/*/**. Comments describe the filter and its relationship to pkgmgr synchronization.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

  • gominimal/pkgs#936: This PR also changes CI behavior. It describes deploy and debounce issues related to notifications on CI-only pushes.

Suggested reviewers: mitodrummer

Merge Risk: Minimal · up to 19617

The notification now runs only for relevant package changes, with no identified merge-blocking regression.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately and clearly summarizes the main change: limiting webapp notifications to pushes that modify a package.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mitodrummer
mitodrummer enabled auto-merge November 2, 2026 20:33
@mitodrummer
mitodrummer added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 7467718 Nov 3, 2026
11 checks passed
@mitodrummer
mitodrummer deleted the notify-webapp-package-pushes-only branch November 3, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants