Skip to content

Drop the hex0 -> stage0-* -> glibc-bedrock-2.42 chain (23 packages) - #1465

Merged
bryan-minimal merged 4 commits into
mainfrom
bryan/drop-hex0-chain
Nov 16, 2026
Merged

bryan-minimal merged 4 commits into
mainfrom
bryan/drop-hex0-chain

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

Stacked on #1462 and #1442 (both merged in); merge those first, then this lands as the single deletion commit.

Nothing in pkgs reads the chain any more. Its last consumer was glibc-bedrock-2.42-sysroot (gone in #1462); the three orphans above it go in #1442. Every bootstrap root pins a gominimal/bootstrap generation object by sha-keyed URL, and the chain lives on there, built and reproduced per generation.

Removed

  • hex0 (with amd64-ladder.ncl, the amd64 switch that has been enabled = false since 2026-10-07)
  • the 21 stage0-* rungs: hex1, kaem, mes, mescc, mescc-full, tcc-0.9.26, tcc-0.9.27 (+ musl-s1/s3/s4), musl-1.1.24 (+ cc2), musl-1.2.5, binutils-2.30/2.41, gcc-4.0.4/4.7.4/10.4.0/15.2.0, gmp-mpfr-mpc, linux-headers-6.12.43
  • glibc-bedrock-2.42

No package outside the chain imports any of them (checked every ../<pkg>/ reference under packages/).

CI scope test

test_ci_scope.py used hex0/amd64-ladder.ncl as its shared-helper fixture. It now uses llvm/versioned.ncl, the helper with the most importers left; the comments in ci_scope.py and blast_radius_report.py name the same example. 15/15 tests pass.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 161 billable files and costs up to $40.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 21 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 75 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 239ba4c and a54b98f.

Files selected for processing: 161

  • .github/scripts/blast_radius_report.py
  • .github/scripts/ci_scope.py
  • .github/scripts/test_ci_scope.py
  • packages/ghc-9.6.7/build.ncl
  • packages/ghc/build.ncl
  • packages/ghc/build.sh
  • packages/glibc-bedrock-2.42-sysroot/build.ncl
  • packages/glibc-bedrock-2.42/build.ncl
  • packages/glibc-bedrock-2.42/build.sh
  • packages/hex0/amd64-ladder.ncl
  • packages/hex0/build.ncl
  • packages/hex0/build.sh
  • packages/openjdk-21/build.ncl
  • packages/openjdk-25/build.ncl
  • packages/openjdk-26/build.ncl
  • packages/stage0-binutils-2.30/build.ncl
  • packages/stage0-binutils-2.30/build.sh
  • packages/stage0-binutils-2.30/libiberty-add-missing-config-directory-reference.patch
  • packages/stage0-binutils-2.30/new-gettext.patch
  • packages/stage0-binutils-2.30/opcodes-ensure-i386-init-dependencies-are-satisfied.patch
  • packages/stage0-binutils-2.30/stage0.answers
  • packages/stage0-binutils-2.41/build.ncl
  • packages/stage0-binutils-2.41/build.sh
  • packages/stage0-binutils-2.41/stage0.answers
  • packages/stage0-gcc-10.4.0/build.ncl
  • packages/stage0-gcc-10.4.0/build.sh
  • packages/stage0-gcc-10.4.0/stage0.answers
  • packages/stage0-gcc-15.2.0/build.ncl
  • packages/stage0-gcc-15.2.0/build.sh
  • packages/stage0-gcc-15.2.0/stage0.answers
  • packages/stage0-gcc-4.0.4/build.ncl
  • packages/stage0-gcc-4.0.4/build.sh
  • packages/stage0-gcc-4.0.4/stage0.answers
  • packages/stage0-gcc-4.7.4/build.ncl
  • packages/stage0-gcc-4.7.4/build.sh
  • packages/stage0-gcc-4.7.4/stage0.answers
  • packages/stage0-gmp-mpfr-mpc/build.ncl
  • packages/stage0-gmp-mpfr-mpc/build.sh
  • packages/stage0-hex1/build.ncl
  • packages/stage0-hex1/build.sh
  • packages/stage0-kaem/bootstrap.kaem
  • packages/stage0-kaem/build.ncl
  • packages/stage0-kaem/stage0.answers
  • packages/stage0-linux-headers-6.12.43/build.ncl
  • packages/stage0-linux-headers-6.12.43/build.sh
  • packages/stage0-mes/build.ncl
  • packages/stage0-mes/config.h
  • packages/stage0-mes/mes.answers
  • packages/stage0-mes/mes.kaem
  • packages/stage0-mescc-full/build.ncl
  • packages/stage0-mescc-full/mescc-full.kaem
  • packages/stage0-mescc-full/simple-patch.c
  • packages/stage0-mescc-full/stage0.answers
  • packages/stage0-mescc/build.ncl
  • packages/stage0-mescc/mescc.kaem
  • packages/stage0-mescc/stage0.answers
  • packages/stage0-musl-1.1.24-cc2/amd64-syscall-arch.patch
  • packages/stage0-musl-1.1.24-cc2/amd64-va-list.patch
  • packages/stage0-musl-1.1.24-cc2/avoid_sys_clone.patch
  • packages/stage0-musl-1.1.24-cc2/build.ncl
  • packages/stage0-musl-1.1.24-cc2/build.sh
  • packages/stage0-musl-1.1.24-cc2/disable_ctype_headers.patch
  • packages/stage0-musl-1.1.24-cc2/drop-dynamic-crt.patch
  • packages/stage0-musl-1.1.24-cc2/madvise_preserve_errno.patch
  • packages/stage0-musl-1.1.24-cc2/makefile.patch
  • packages/stage0-musl-1.1.24-cc2/skip-pic-crt.patch
  • packages/stage0-musl-1.1.24-cc2/stage0.answers
  • packages/stage0-musl-1.1.24/amd64-syscall-arch.patch
  • packages/stage0-musl-1.1.24/amd64-va-list.patch
  • packages/stage0-musl-1.1.24/avoid_sys_clone.patch
  • packages/stage0-musl-1.1.24/build.ncl
  • packages/stage0-musl-1.1.24/build.sh
  • packages/stage0-musl-1.1.24/disable_ctype_headers.patch
  • packages/stage0-musl-1.1.24/drop-dynamic-crt.patch
  • packages/stage0-musl-1.1.24/madvise_preserve_errno.patch
  • packages/stage0-musl-1.1.24/makefile.patch
  • packages/stage0-musl-1.1.24/skip-pic-crt.patch
  • packages/stage0-musl-1.1.24/stage0.answers
  • packages/stage0-musl-1.2.5/build.ncl
  • packages/stage0-musl-1.2.5/build.sh
  • packages/stage0-musl-1.2.5/stage0.answers
  • packages/stage0-tcc-0.9.26/addback-fileopen.after
  • packages/stage0-tcc-0.9.26/addback-fileopen.before
  • packages/stage0-tcc-0.9.26/build.ncl
  • packages/stage0-tcc-0.9.26/fix-mul.after
  • packages/stage0-tcc-0.9.26/fix-mul.before
  • packages/stage0-tcc-0.9.26/fix-plt.after
  • packages/stage0-tcc-0.9.26/fix-plt.before
  • packages/stage0-tcc-0.9.26/fix-setjmp.after
  • packages/stage0-tcc-0.9.26/fix-setjmp.before
  • packages/stage0-tcc-0.9.26/fix-shift.after
  • packages/stage0-tcc-0.9.26/fix-shift.before
  • packages/stage0-tcc-0.9.26/fix-stdarg.after
  • packages/stage0-tcc-0.9.26/fix-stdarg.before
  • packages/stage0-tcc-0.9.26/fix-swapb.after
  • packages/stage0-tcc-0.9.26/fix-swapb.before
  • packages/stage0-tcc-0.9.26/fix-swapf.after
  • packages/stage0-tcc-0.9.26/fix-swapf.before
  • packages/stage0-tcc-0.9.26/fix-vararg.after
  • packages/stage0-tcc-0.9.26/fix-vararg.before
  • packages/stage0-tcc-0.9.26/remove-fileopen.after
  • packages/stage0-tcc-0.9.26/remove-fileopen.before
  • packages/stage0-tcc-0.9.26/simple-patch.c
  • packages/stage0-tcc-0.9.26/stage0.answers
  • packages/stage0-tcc-0.9.26/tcc.kaem
  • packages/stage0-tcc-0.9.27-musl-s1/build.ncl
  • packages/stage0-tcc-0.9.27-musl-s1/build.sh
  • packages/stage0-tcc-0.9.27-musl-s3/build.ncl
  • packages/stage0-tcc-0.9.27-musl-s3/build.sh
  • packages/stage0-tcc-0.9.27-musl-s4/build.ncl
  • packages/stage0-tcc-0.9.27-musl-s4/build.sh
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_args.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_args.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_bigframe.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_bigframe.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_float.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_float.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_longlong.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_longlong.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_mul.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_mul.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_recursion.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_recursion.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_setjmp.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_setjmp.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_shift.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_shift.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_struct.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_struct.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_switch.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_switch.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_varargs.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_varargs.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_xobj.expected
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_xobj_lib.c
  • packages/stage0-tcc-0.9.27-musl-s4/torture/t_xobj_main.c
  • packages/stage0-tcc-0.9.27/addback-fileopen.after
  • packages/stage0-tcc-0.9.27/addback-fileopen.before
  • packages/stage0-tcc-0.9.27/build.ncl
  • packages/stage0-tcc-0.9.27/cast-signed-direct.after
  • packages/stage0-tcc-0.9.27/cast-signed-direct.before
  • packages/stage0-tcc-0.9.27/check-reloc-null.after
  • packages/stage0-tcc-0.9.27/check-reloc-null.before
  • packages/stage0-tcc-0.9.27/dont-skip-weak-symbols-ar.after
  • packages/stage0-tcc-0.9.27/dont-skip-weak-symbols-ar.before
  • packages/stage0-tcc-0.9.27/fiwix-paddr.after
  • packages/stage0-tcc-0.9.27/fiwix-paddr.before
  • packages/stage0-tcc-0.9.27/fix-setjmp.after
  • packages/stage0-tcc-0.9.27/fix-setjmp.before
  • packages/stage0-tcc-0.9.27/fix-stdarg.after
  • packages/stage0-tcc-0.9.27/fix-stdarg.before
  • packages/stage0-tcc-0.9.27/ignore-static-inside-array.after
  • packages/stage0-tcc-0.9.27/ignore-static-inside-array.before
  • packages/stage0-tcc-0.9.27/neg-float-const.after
  • packages/stage0-tcc-0.9.27/neg-float-const.before
  • packages/stage0-tcc-0.9.27/remove-fileopen.after
  • packages/stage0-tcc-0.9.27/remove-fileopen.before
  • packages/stage0-tcc-0.9.27/stage0.answers
  • packages/stage0-tcc-0.9.27/static-link.after
  • packages/stage0-tcc-0.9.27/static-link.before
  • packages/stage0-tcc-0.9.27/tcc.kaem
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

bryan-minimal and others added 3 commits November 12, 2026 22:23
…sroot package

gen-15 of gominimal/bootstrap builds the amd64 openjdk-21/25/26 and ghc-9.6.7 against the
system glibc with the gcc seed: PT_INTERP /usr/lib/ld-linux-x86-64.so.2, no RUNPATH beyond
their own $ORIGIN entries, and ghc-cc a plain gcc wrapper that adds that loader. The four pins
move to gen-15 on both arches (arm64's objects are the gen-13 bytes under their gen-15 names,
ghc-9.6.7's rebuilt from the shared script and identical apart from BUILDINFO) and their amd64
runtime dep becomes glibc. ghc drops the sysroot from its amd64 build deps; its check that
nothing shipped names the sysroot stays. Nothing imports glibc-bedrock-2.42-sysroot any more,
so the package goes.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit 1151b19)
The arm64 JDK objects are the gen-13 bytes re-published under gen-15
(bootstrap generations/gen-15/manifest.json lists each sha256 at its gen-15
url), so the url moves and the sha256 correctly stays. Comments only; no
spec hash changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing in pkgs reads it: the sysroot was its last consumer, and the
bootstrap roots pin gominimal/bootstrap generation objects instead. The
chain lives on there, built and reproduced per generation. The amd64
switch hex0/amd64-ladder.ncl goes with it.

The CI-scope test used hex0's ladder helper as its shared-helper fixture;
llvm/versioned.ncl is the one with the most importers now.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope matches the title and the body. The diff also carries the two stacked commits (ghc-9.6.7 and openjdk-21/25/26 move to gen-15, glibc-bedrock-2.42-sysroot goes). The body says this. Clobber none. git log on test_ci_scope.py, ghc/build.sh and openjdk-21/build.ncl shows only this stack after #1242 and #1372. Correctness no file outside the chain names hex0, amd64-ladder, a stage0-* package or glibc-bedrock-2.42 by import. The remaining hits are comments ("hex0-rooted toolchain") and gen-13 bootstrap object URLs in glibc and linux_headers. Those URLs are bootstrap objects, not packages, so the deletion does not break them. The amd64 runtime deps of ghc-9.6.7 and openjdk-21/25/26 now use glibc. No build script in those packages or in ghc/jdk-* references a sysroot path, so nothing else depended on the dropped dep. The ghc/build.sh guard against /usr/lib/glibc-bedrock-2.42 stays, which is a reasonable regression check. One finding: the new CI-scope test comment states a fact that is false for the new fixture. Not checked: the gen-15 hashes against the bootstrap manifest, and the 15/15 test run the body reports. Both need network or execution.

Comment thread .github/scripts/test_ci_scope.py Outdated
self.assertGreaterEqual(len(importers), 3)
# The edge itself, not just reachability: the importers also reach
# llvm through build.ncl, which would hide a regex that only matches
# build.ncl imports.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low · The comment says the importers also reach llvm through build.ncl. That is false. llvm-21, llvm-22 and llvm-23 reach llvm only through versioned.ncl, and none of them imports ../llvm/build.ncl. The assertion is now stronger than the comment says, because the helper edge is the only path. Rewrite the comment so that it says this. As written, it will mislead the next person who edits the test or the regex. The issue is local to this test.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a54b98f: the comment now says llvm-21/22/23 reach llvm only through versioned.ncl (none imports ../llvm/build.ncl), so a regex matching only build.ncl imports would fail this assertion. test_ci_scope: 15/15 pass.

….ncl

The comment said they also reach llvm through build.ncl; none imports
../llvm/build.ncl, so the helper edge is the only path (review on #1465).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit b891179 Nov 16, 2026
16 checks passed
@bryan-minimal
bryan-minimal deleted the bryan/drop-hex0-chain branch November 16, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants