Skip to content

gcloud: license_spdx Python-2.0 → Python-2.0.1 - #1466

Merged
bryan-minimal merged 1 commit into
mainfrom
gcloud-python-2.0.1
Nov 13, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
gcloud-python-2.0.1

Conversation

@bryan-minimal

@bryan-minimal bryan-minimal commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

gcloud declared the bundled CPython interpreter's license as Python-2.0. pkgmgr's license check on #1448 (592 → 593) reads Python-2.0.1 in the release's license files, and our own packages/python already declares Python-2.0.1 for that interpreter. This changes gcloud to match.

The comment described Python-2.0.1 as an auto-scan false positive from packaging's SPDX-ID table. That part is removed, and the comment now explains why the id is right. The Pixar false-positive note stays.

Rebuilds: 0. Only attrs.license_spdx and a comment change, and neither is hashed. nickel format is clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the package’s license information to identify the bundled Python interpreter as Python-2.0.1.
    • Clarified the license attribution notes, including the classification of Pixar as a false positive. This keeps the package’s published licensing details aligned with the interpreter and its license identifiers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 12, 2026 20:25
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The gcloud package now identifies the bundled CPython interpreter’s license as Python-2.0.1. The comments also explain the Pixar false positive from the Pygments USD lexer.

Changes: gcloud license metadata

Layer / File(s) Summary
Update license metadata
packages/gcloud/build.ncl
The license_spdx attribute changes from Python-2.0 to Python-2.0.1. Comments now attribute Pixar to a Pygments USD lexer false positive and identify Python-2.0.1 as the bundled interpreter’s license.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Suggested reviewers: mitodrummer

Merge Risk: Minimal · up to 16dbe

This updates the declared license identifier for the bundled CPython interpreter to Python-2.0.1 and adjusts its comments. It has no runtime effect and is ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the changed field (gcloud license_spdx) and the new value (Python-2.0.1), which matches the raw summary, where the bundled CPython license identifier changes from Python-2.0 to Python-…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the changed field (gcloud license_spdx) and the new value (Python-2.0.1), which matches the raw summary, where the bundled CPython license identifier changes from Python-2.0 to Python-2.0.1. It is short and specific, and a teammate scanning history would understand the primary change. The arrow notation is slightly informal but does not affect the meaning.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 15031cd and 16dbead.

Files selected for processing: 1

  • packages/gcloud/build.ncl

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit aba195d Nov 13, 2026
15 checks passed
@bryan-minimal
bryan-minimal deleted the gcloud-python-2.0.1 branch November 13, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants