Skip to content

emscripten: 4.0.11 -> 6.0.3 on llvm-23 (off frozen llvm-21) - #1476

Merged
bryan-minimal merged 1 commit into
mainfrom
emscripten-6.0.3-llvm23
Nov 13, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
emscripten-6.0.3-llvm23

Conversation

@bryan-minimal

@bryan-minimal bryan-minimal commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Moves emscripten off the frozen llvm-21 (pkgs#1339) onto LLVM 23.

Version choice

EXPECTED_LLVM_VERSION in tools/shared.py, per tag: 4.0.11 = 21, 4.0.12–4.0.23 = 22, 5.0.0–6.0.3 = 23, 6.0.4–7.0.0 = 24 (LLVM 24 is not released). So 6.0.3 is the newest release that runs on LLVM 23. 6.0.4+ comes with LLVM 24.

Changes

  • build.ncl: 4.0.11 → 6.0.3. llvm-21 → llvm-23 (prefixed, same ["bins", "libs"] subset), so a later default-llvm major can't change the compiler underneath it.
  • build.sh: LLVM_ROOT = /usr/lib/llvm-23/bin. New guard: the build fails when tools/shared.py's EXPECTED_LLVM_VERSION differs from that clang's major (emcc itself only warns).
  • build.sh: 5.0.2 removed the emcc/em++/... shell launchers from git and the tarball (Remove remaining launcher files from git. NFC emscripten-core/emscripten#26247). bootstrap.py creates them, along with npm ci and submodules. We run only its launcher step (tools/maint/create_entry_points.py) before install.py and assert the launchers exist. Also added a wrapper for the new empath-split entry point.
  • binaryen stays at 133. 6.0.3 expects 129 and accepts 129 or 130. The check only warns, and it already did for 4.0.11 (which expected 123). Bryan's policy rules out downgrading a shared package.

Source sha256 033241f96a5c50993b43d8383c3356d2804932f5b3548e94c9839c4f68e8b5bd (codeload refs/tags/6.0.3, the bytes behind the recipe's archive/refs/tags URL). The upstream URL is unchanged, so there's nothing to mirror.

Not verified

Nothing was built locally. The standalone tests (compile_archive, link_run, fetches_nothing, no_build_scaffolding) cover the risky parts: the generated launchers, the sysroot cache under binaryen 133, and the extra launcher files install.py now copies.

Follow-up

pkgmgr-rs data/series_pins.toml [emscripten] series = "4.0.11" has to move to 6.0.3 in step with this change, or the updater will hold it back.

Rebuilds: emscripten plus raylib, raygui, odin and ols (transitive importers).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • The Emscripten toolchain now uses version 6.0.3 with LLVM 23.
    • Packaged command-line tools now include additional path and profiling utilities.
    • Builds now verify the LLVM version and confirm required Emscripten tools are available and executable.

6.0.3 is the last emscripten release whose tools/shared.py
EXPECTED_LLVM_VERSION is 23 (6.0.4+ expect the unreleased 24), so it moves
off llvm-21 onto the prefixed llvm-23, the same shape as before.

- build.sh: LLVM_ROOT is /usr/lib/llvm-23/bin; a new guard fails the build
  when tools/shared.py's EXPECTED_LLVM_VERSION and that clang's major differ
  (emcc itself only warns).
- build.sh: 5.0.2 removed the shell launchers (emcc, em++, ...) from git and
  the tarball; bootstrap.py creates them. Run only its create-entry-points
  step (tools/maint/create_entry_points.py) before install.py, not npm ci or
  submodules, and add a wrapper for the new empath-split entry point.
- binaryen stays at 133. 6.0.3 expects 129 (accepts 129/130); the check is a
  warning, as it was for 4.0.11 (expected 123).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Emscripten package updates to version 6.0.3 and switches from LLVM 21 to LLVM 23. Its build script checks the LLVM major version and generated launcher executables, updates LLVM_ROOT, and adds empath-split and emprofile to the wrapper list.

Changes: Emscripten package update

Layer / File(s) Summary
Package version and LLVM dependency
packages/emscripten/build.ncl
The package version changes to 6.0.3, its source checksum is updated, and its LLVM build and runtime dependencies change to LLVM 23.
Build validation and launchers
packages/emscripten/build.sh
The build checks the selected Clang major against EXPECTED_LLVM_VERSION and verifies that four generated launchers are executable. It sets LLVM_ROOT to LLVM 23 and adds empath-split and emprofile to the wrapper list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

  • gominimal/pkgs#1339: This PR moves Emscripten to the LLVM 21 package, which is the starting point for the LLVM dependency update here.
  • gominimal/pkgs#1061: This PR adds the prefixed LLVM 23 package used by the updated Emscripten build.

Suggested reviewers: evanspearman

Merge Risk: Minimal · up to 3f3d4

This updates Emscripten to 6.0.3 on LLVM 23 and adds build-time checks for the toolchain and generated launchers. No actionable merge-blocking risk was found. The description notes that the pkgmgr-rs series pin must be updated separately, and the dependent packages will need rebuilds.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: Emscripten is bumped from 4.0.11 to 6.0.3 and moves from frozen LLVM 21 to LLVM 23. The raw summary and PR objectives both describe this version and toolchain change, …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: Emscripten is bumped from 4.0.11 to 6.0.3 and moves from frozen LLVM 21 to LLVM 23. The raw summary and PR objectives both describe this version and toolchain change, so the title matches the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 1ac96bf and 3f3d46e.

Files selected for processing: 2

  • packages/emscripten/build.ncl
  • packages/emscripten/build.sh

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@bryan-minimal
bryan-minimal marked this pull request as ready for review November 13, 2026 03:59
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 13, 2026 03:59

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope matches the title. The diff changes only packages/emscripten/build.ncl and packages/emscripten/build.sh. Every hunk traces to the 4.0.11 -> 6.0.3 move, the llvm-21 -> llvm-23 move, or the launchers that 5.0.2 removed from the tarball. Clobber none. HEAD is the PR commit itself, and the diff keeps the existing npm stub, scaffolding cleanup and EM_CACHE wrapper logic unchanged. Correctness packages/llvm-23 exists. It is prefixed at /usr/lib/llvm-23 through llvm/versioned.ncl, and it exports the bins and libs outputs that the subset names. The LLVM guard parses ^clang version N. and llvm/ sets no CLANG_VENDOR, so the parse matches the clang this package gets. One gap: the launcher assertion checks 4 of the 19 launchers that the /usr/bin wrappers exec. Details are in the finding. Stale reference outside the diff: the packages/llvm-21/build.ncl header still lists "emscripten 4.0.11 (EXPECTED_LLVM_VERSION = 21)" as a consumer. The packages/llvm-23/build.ncl header does not list emscripten. Update both in this PR. Not checked: I did not fetch the 6.0.3 tarball. I did not confirm that tools/maint/create_entry_points.py exists at that tag or that it writes empath-split. I did not build the package or run the standalone tests. The pkgmgr-rs series pin follow-up is outside this repo.

  • packages/emscripten/build.sh:84 low · Since 5.0.2 the tarball no longer contains the launchers. All 19 /usr/bin wrappers below (lines 68-70) now exec a file that only create_entry_points.py creates. This check covers 4 of them. Assume the script does not create empath-split, emdwp, emscan-deps, or any other name in the wrapper list. The build still passes, and the package then ships a /usr/bin/<tool> that fails with exec: /usr/share/emscripten/<tool>: not found. empath-split is new in this PR, so it is the most likely gap. No standalone test calls any wrapper other than emcc and emar. Assert the full wrapper list here, or test after install.py that each $EM_ROOT/$t in the wrapper loop is executable. This instance is local: no other package uses this pattern.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit e0751a7 Nov 13, 2026
15 checks passed
@bryan-minimal
bryan-minimal deleted the emscripten-6.0.3-llvm23 branch November 13, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants