Skip to content

rust 1.99.1 -> 1.100.0 on a gen-16 rustc-1.99.1 stage0 (LLVM 23); drops bun's 1.99 shims - #1493

Open
bryan-minimal wants to merge 12 commits into
mainfrom
rust-1.100.0
Open

bryan-minimal wants to merge 12 commits into
mainfrom
rust-1.100.0

Conversation

@bryan-minimal

@bryan-minimal bryan-minimal commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Builds on both arches. build-bot run at 95028ed7 passed minimal build on amd64 and arm64 (68 min, 2026-11-14), with every check green. Its stage0, rustc-1.99.1, is bootstrap generation gen-16 (gominimal/bootstrap#13, built on LLVM 23). The first real builds found two breaks this PR now fixes: libssh2's version string, and bun's allocator_api gate. Both are under Changes.

Changes

  • packages/rustc-1.99.1/build.ncl (new). A thin prebuilt that pulls the gen-16 rung tarballs. It is shaped like rustc-1.98.1 (gen-13) and installs at /usr/lib/rustc-1.99.1.
    • runtime_deps pins llvm-23, not the default llvm, so the next default-LLVM major does not move this frozen rung.
    • It carries # pkgmgr: bootstrap_rung = "rust".
    • url and sha256 per arch are gen-16's: amd64 02a0a9c8…, arm64 07b2fdce… (rustc-1.99.1-1.99.1-aarch64.tar.zst).
    • The openssl-3.5/libssh2/sqlite/zlib runtime deps are copied from 1.98.1. They are marked TODO to confirm against the published rung's DT_NEEDED.
  • packages/rust: 1.99.1 -> 1.100.0.
    • Source sha256 90dab90b8084eb57c35ae2b1d0b70c8e5138ace6023b22c60a5a400f586f63b2, which equals static.rust-lang.org's rustc-1.100.0-src.tar.xz.sha256.
    • The stage0 import, STAGE0_PREFIX and the --version grep now point at rustc-1.99.1. 1.100.0's src/stage0 pins 1.99.0, and x.py compares major.minor only.
    • Dropped export LD_LIBRARY_PATH=/usr/lib/llvm-21/lib. The new stage0 needs libLLVM.so.23.1, and the default llvm (23.1.5 since llvm: freeze LLVM 21 as llvm-21, switch default llvm to 23.1.5 (LLVM plan steps 6+7) #1339) already provides that in /usr/lib. Exporting /usr/lib/llvm-23/lib instead would make the stage1/stage2 compilers load the prefixed copy under the same soname. The comment says to re-add it once the default llvm moves past 23. rust never had an llvm-21 build or runtime dep of its own; that dep lived only on rustc-1.98.1.
    • bootstrap.toml: change-id = 162423, the newest entry in 1.100.0's change_tracker.rs.
  • packages/amaro-wasm. Its rustc pin and the matching rustc-<v>-src.tar.xz sha are bumped to 1.100.0 (same tarball). Without this its build.sh fails with rustc is not 1.99.1.
  • packages/rust-arm-embedded/build.sh. It read target/<triple>/release/deps/lib*.rlib, which cargo 1.100 no longer produces. Its new default build-dir layout stores each unit under build/<pkg>/<hash>/out/ (cargo#17354, #15010). Details are in the section below.
  • packages/bun: Rust 1.99 shims removed. bun 1.4.4 (SECURITY: bun 1.3.14 -> 1.4.4 on llvm-23 (3 HIGH), with Rust 1.99 shims #1492, now merged into this branch) carried them to build on rustc 1.99.1, and they hard-failed on rustc >= 1.100.
    • Deleted rust-1.99-type-info-of.patch (a local core::mem::type_info::of in bun_collections, plus a hand-written impl Default for Start in lint_js.rs replacing #[derive(Default)]).
    • Removed its build.ncl Local entry and, in build.sh, the patch application, its three post-apply greps (including ^impl Default for Start {$) and the guard that failed on rustc >= 1.100.
    • In their place build.sh now requires rustc >= 1.100. bun 1.4.3+ needs it.
    • Everything else in bun (the system CA store patch, the CVE-2026-111943 root checks, the LLVM 23 checks) is untouched.
  • packages/libssh2: stamp the release version (7bd7eff). The source is GitHub's tag archive, whose include/libssh2.h says LIBSSH2_VERSION "1.11.1_DEV"; release tarballs stamp the suffix out. CMake copied it into libssh2.pc, and libssh2-sys 0.3.4 (cargo in 1.100) semver-parses the pkg-config version and panicked, which stopped cargo's build on both arches. The same string went into libssh2_version() and the SSH banner (SSH-2.0-libssh2_1.11.1_DEV). build.sh now stamps the version (a build arg, so it follows bumps) after the CVE patches, and checks both the header and the installed libssh2.pc. Only rust and rustc-1.98.1 import libssh2.
  • packages/bun: Rust 1.100's allocator_api split (95028ed). 1.100 stabilized part of allocator_api and moved the rest (e.g. const Vec::new_in) to allocator_ext. bun 1.4.4 and bun main still pin nightly-2026-09-15, from before the split, so 12 bun crate roots enable allocator_api, which bun's -D warnings rejects. Crates differ on which part they need: a plain rename left bun_ptr and bun_shell_parser with an unused allocator_ext. So build.sh leaves bun's gates alone and prepends #![feature(allocator_ext)] and #![allow(stable_features, unused_features)] to every crate root that enables allocator_api (single-line, listed, or multi-line like bun_collections), then checks each one. Tested on all 124 crate roots of the 1.4.4 tag. bun upstream will need the same change once its pinned nightly moves.
  • packages/broot/build.sh. It now takes its build script's OUT_DIR from cargo's build-script-executed message, instead of running find over target/release/build. It also fails loudly instead of silently skipping. The old find -path '*/out/broot.bash' would still have matched the new build/broot/<hash>/out, so this is hardening rather than a break. The skip was silent, though, while all three completions are declared outputs.

rust-arm-embedded: why JSON messages

The -Zbuild-std rlibs (core, alloc, compiler_builtins, ...) are intermediate artifacts. They never reach the final artifact dir, which holds only libdriver.rlib, so "copy from target/<triple>/release" is not an option.

I considered two fixes:

  • Pin the old layout. The only opt-out in cargo 0.101 (src/workspace/features.rs) is the env var __CARGO_TEMPORARY_BUILD_DIR_NEW_LAYOUT_OPT_OUT=1. The name says it is temporary, so this would break again soon.
  • Ask cargo (chosen). This is what the 1.100 changelog prescribes: "Tools that inspect the build directory may need to use Cargo's JSON messages to locate build artifacts… The layout is not a stable interface."

The build now runs cargo build ... --message-format=json-render-diagnostics. It then copies every .rlib named in a compiler-artifact message's filenames that sits under /<triple>/release/, which excludes host-built build scripts and deps, and it skips the driver. A positive control fails the build if libcore-*, liballoc-* or libcompiler_builtins-* is missing for any target. The same code works under the old and new layouts.

Verified

  • Builds. minimal build passed on amd64 and arm64 at 95028ed7. That covers every package changed here: rust (stage1/stage2 and cargo, on the gen-16 stage0), rustc-1.99.1, amaro-wasm, rust-arm-embedded (including its -Zbuild-std rlib control), broot, libssh2 and bun.
  • Source checksum. The rustc-1.100.0-src sha256 matches upstream's .sha256. A .asc is published, and the signing key fingerprint is 108F66205EAEB0AAA8DD5E1C85AB96E6FA1BE5FE.
  • bootstrap.toml keys. Every key rust/bootstrap.toml uses still exists in 1.100.0's src/bootstrap/src/core/config/toml/*.rs. The keys are vendor, build-stage/test-stage/doc-stage, extended, tools, docs, rustc, cargo, link-shared, channel, download-rustc, lld, llvm-bitcode-linker, remap-debuginfo, compression-profile, src-tarball, cc/cxx/linker/llvm-config/default-linker and prefix.
  • change_tracker entries after 154587.
    • Removals: compiletest-use-stage0-libtest (unused here), rust.use-lld (we use rust.lld, which still exists), and the override-allocator rename (unused).
    • Install component: x install src became rust-src (162423). We install explicit components and copy library/ by hand, and library/std, compiler/rustc, cargo, clippy, rustfmt and rust-analyzer are all still valid install paths.
    • GDB/LLDB are no longer auto-discovered. This only matters for tests.
  • Vendor patch. The vendor.rs sed anchor (let _guard = builder.group(&format!("Vendoring sources) matches exactly once in 1.100.0. VendorOutput { config, config_library } is unchanged.
  • LLVM minimum. check_llvm_version in 1.100.0 needs LLVM >= 21, which 23.1.5 satisfies.
  • Cargo version. Cargo at the 1.100.0 submodule commit (3acc79c, 0.101.0) still honours __CARGO_TESTS_ONLY_SRC_ROOT, which amaro-wasm uses.
  • Pipeline check. The grep pipelines in rust-arm-embedded and broot were checked against hand-written cargo JSON in the 1.100 shape, not against real cargo output.
  • bun without the shims. bun-v1.4.4 (38afee6c) as published uses use core::mem::type_info; / type_info::of::<T>() in src/collections/multi_array_list.rs (with #![feature(type_info)]) and #[derive(Default)] over a std::sync::Once field in src/runtime/cli/lint_js.rs. Rust 1.100.0 has both: pub const fn of<T: ?Sized>() -> TypeId in library/core/src/mem/type_info.rs (unstable type_info, which bun's RUSTC_BOOTSTRAP=1 allows) and impl Default for Once, stable as once_default since 1.100.0. These are the only two places the patch touched.
  • No other rustc 1.99 pins or guards. Outside rust and rustc-1.99.1, the only 1.99 reference left is verus-latest's let rust = "1.99.1". That is Verus's own rust-toolchain.toml channel, vendored privately with rustc-dev and independent of the rust package, so it stays as is.
  • nickel format was run on every .ncl changed here.

Not verified

  • Never-type fallback warnings. I haven't searched the successful build's logs for will be rejected by a future version. build-bot only exports logs for failed builds, so this needs the run's log (see Review items).
  • Runtime. No smoke test beyond each package's own build-time checks and the standalone tests CI runs.
  • The rung's DT_NEEDED set is still assumed from gen-13 (see the TODO in packages/rustc-1.99.1/build.ncl). The gen-16 names and shas are now real.
  • rustc-1.100.0-src.tar.xz is mirrored (2026-11-13, 263313328 bytes, sha256 90dab90b…63b2 read back from the public URL; signature and checksum verified before upload).

History

gen-16 (gominimal/bootstrap#13, published and verified 123/123) supplies the stage0, and rustc-1.100.0-src.tar.xz is mirrored. The first build-bot runs failed in cargo (libssh2 _DEV), then in bun (allocator_api, twice); all three are fixed above.

Mirror command, for the next rustc source (it verifies the signature and checksum, then makes a create-only upload). Two fixes against the first version of this command, which can't pass with sq 1.5:

  • sq inspect | grep -q dies with "Broken pipe", so the output is captured first.
  • The Rust release key binds its user ID with a SHA-1 self-signature, which sq rejects from 2023-02-01. --policy-as-of 2023-01-01 evaluates the key under the policy of that day; the signature over the tarball is checked as usual.

It fails if sq is missing rather than skipping the signature.

set -euo pipefail
V=1.100.0; F=rustc-$V-src.tar.xz; SHA=90dab90b8084eb57c35ae2b1d0b70c8e5138ace6023b22c60a5a400f586f63b2
D=$(mktemp -d) && cd "$D" && UA=gominimal-pkgmgr-agent
command -v sq >/dev/null || { echo "sq is required to check the signature" >&2; exit 1; }
for f in $F $F.asc $F.sha256; do curl -fsSL -A "$UA" -o "$f" "https://static.rust-lang.org/dist/$f"; done
curl -fsSL -A "$UA" -o rust-key.gpg.ascii https://static.rust-lang.org/rust-key.gpg.ascii
KEYINFO=$(sq --home=none inspect rust-key.gpg.ascii 2>&1)
case "$KEYINFO" in *108F66205EAEB0AAA8DD5E1C85AB96E6FA1BE5FE*) ;; *) echo "unexpected signing key" >&2; exit 1 ;; esac
sq --home=none --policy-as-of 2023-01-01 verify --signer-file rust-key.gpg.ascii --signature-file $F.asc $F
shasum -a 256 -c $F.sha256
echo "$SHA  $F" | shasum -a 256 -c
gcloud storage cp --no-clobber $F gs://minimal-staging-archives/$F

Review items

  • Never-type fallback is now ! on all editions, and Infallible is now an alias of ! (rust#155499). This is the main crate-level unknown. Once anything builds, grep the build logs for will be rejected by a future version. Also look for new inference errors from the Box<T, A> impl generalisation (rust#161946) and the more precise if let closure capture (rust#154210).
  • box patterns are no longer syntactically allowed (rust#156749). Only crates using them under RUSTC_BOOTSTRAP are affected.
  • ARM: ABI-altering -Ctarget-feature/-Ctarget-cpu values are now hard errors (rust#161280). rust-arm-embedded passes none.
  • The stacks/rust build-dir cache. The stack sets CARGO_BUILD_BUILD_DIR = "{cargo-cache-home}/build". Old-layout caches there are not reused after the switch, so expect one cold build per project and stale old-layout content until it is cleaned.
  • LD_LIBRARY_PATH reasoning. Please check the LD_LIBRARY_PATH reasoning in rust/build.sh. It assumes the default llvm is in the rust build sandbox, which is true today: bootstrap.toml uses /usr/bin/llvm-config.
  • Frozen rule. pkgmgr-rs gets a matching data/frozen_packages.toml [[rule]] name = "rustc-1.99.1" in a separate pm PR. It is not part of this PR.
  • Leftover comments. packages/hex0/amd64-ladder.ncl and packages/llvm-21/build.ncl still mention rustc-1.98.1 / LLVM 21 as rust's stage0. rustc-1.98.1 is now unreferenced by rust and can be retired, or kept for the ladder, in a follow-up.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates

    • Rust packages now use Rust 1.100.0, with an updated stage0 compiler and a new Rust 1.99.1 prebuilt package.
    • Bun builds now require Rust 1.100 or newer.
  • Bug Fixes

    • Broot builds now install Bash, Fish, and Zsh completions from Cargo’s reported output and fail clearly if required completion files are missing.
    • libssh2 builds now verify that reported package versions match the expected version.
    • Embedded Rust builds now validate that required libraries are installed.

bryan-minimal and others added 3 commits November 13, 2026 10:19
Thin prebuilt of bootstrap's rustc-1.99.1 rung, built against llvm-23, the
same shape as rustc-1.98.1. gen-16 is not published yet: both sha256s are
all-zero placeholders marked TODO(gen-16). runtime_deps pin llvm-23 so the
next default-LLVM major does not move the rung. Carries the
`# pkgmgr: bootstrap_rung = "rust"` marker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- stage0 import, STAGE0_PREFIX and version check -> rustc-1.99.1
- drop LD_LIBRARY_PATH=/usr/lib/llvm-21/lib: the stage0 now needs
  libLLVM.so.23.1, which the default llvm (23.1.5) provides in /usr/lib
- bootstrap.toml change-id 154587 -> 162423 (1.100.0's newest entry);
  every key used still exists in 1.100's config/toml/*.rs
- source sha256 = static.rust-lang.org's rustc-1.100.0-src.tar.xz.sha256
- amaro-wasm: rustc pin and the matching rustc source tarball

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cargo 1.100 switched the build-dir to a per-unit layout:
target/<triple>/release/deps/ no longer exists and build-script OUT_DIRs
moved to build/<pkg>/<hash>/out. Cargo's changelog says tools should read
its JSON messages instead of the layout, so:

- rust-arm-embedded takes the -Zbuild-std rlibs from compiler-artifact
  "filenames" (only paths under the target's triple dir), and fails if
  core, alloc or compiler_builtins is missing
- broot takes its build script's out_dir from build-script-executed and
  fails instead of silently skipping the declared completions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Warning

Review limit reached

  • Run on-demand review

This review includes 12 billable files and costs up to $3.00.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 5 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 63 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 95028ed and e9a5012.

Files selected for processing: 12

  • packages/amaro-wasm/build.ncl
  • packages/broot/build.sh
  • packages/bun/build.ncl
  • packages/bun/build.sh
  • packages/bun/rust-1.99-type-info-of.patch
  • packages/libssh2/build.ncl
  • packages/libssh2/build.sh
  • packages/rust-arm-embedded/build.sh
  • packages/rust/bootstrap.toml
  • packages/rust/build.ncl
  • packages/rust/build.sh
  • packages/rustc-1.99.1/build.ncl

No actionable comments were generated in the recent review.

Walkthrough

The changes update the Rust toolchain to version 1.100.0, adjust related compiler builds, and change how several package build scripts discover, install, or verify build outputs and versions.

Changes: Rust 1.100 toolchain

Layer / File(s) Summary
rustc-1.99.1 package
packages/rustc-1.99.1/build.ncl
Adds an architecture-specific prebuilt compiler package with runtime dependencies, a rustc -vV test, and package metadata.
Rust 1.100 bootstrap
packages/rust/build.ncl, packages/rust/bootstrap.toml, packages/rust/build.sh
Updates the Rust package to 1.100.0, uses rustc 1.99.1 as stage0, and updates the bootstrap change-id.
Compiler consumer updates
packages/bun/build.ncl, packages/bun/build.sh, packages/bun/rust-1.99-type-info-of.patch, packages/amaro-wasm/build.ncl
Removes bun’s Rust 1.99 compatibility patch and adds checks and crate-root feature setup for its Rust build. amaro-wasm selects Rust 1.100.0.

broot completions

Layer / File(s) Summary
Completion discovery and installation
packages/broot/build.sh
Uses Cargo JSON output to locate completion files and exits with an error if the output directory or broot.bash is missing.

libssh2 version checks

Layer / File(s) Summary
Version stamping and verification
packages/libssh2/build.ncl, packages/libssh2/build.sh
Passes the package version to the build script, stamps the source header, and checks the header and installed libssh2.pc version.

Embedded Rust libraries

Layer / File(s) Summary
Artifact-based library installation
packages/rust-arm-embedded/build.sh
Captures Cargo compiler-artifact messages, copies qualifying .rlib files, skips the dummy driver crate, and checks for required libraries.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: msample, jtnkminimal

Merge Risk: Minimal · previous review 95028

This upgrades the Rust toolchain to 1.100.0 and adapts the dependent package build scripts. The reported builds pass on both architectures, and the build scripts fail loudly when they find unexpected output. No concrete merge-blocking defect was established.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change, the Rust upgrade from 1.99.1 to 1.100.0 on a new gen-16 rustc-1.99.1 stage0 with LLVM 23. It also names the removal of bun's 1.99 shims, which the changeset covers. Th…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change, the Rust upgrade from 1.99.1 to 1.100.0 on a new gen-16 rustc-1.99.1 stage0 with LLVM 23. It also names the removal of bun's 1.99 shims, which the changeset covers. The title is long and dense, but it matches the changes in the PR summary and file summaries.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ded4f65 and 95028ed.

Files selected for processing: 12

  • packages/amaro-wasm/build.ncl
  • packages/broot/build.sh
  • packages/bun/build.ncl
  • packages/bun/build.sh
  • packages/bun/rust-1.99-type-info-of.patch
  • packages/libssh2/build.ncl
  • packages/libssh2/build.sh
  • packages/rust-arm-embedded/build.sh
  • packages/rust/bootstrap.toml
  • packages/rust/build.ncl
  • packages/rust/build.sh
  • packages/rustc-1.99.1/build.ncl
Files with no reviewable changes: 2

  • packages/bun/build.ncl
  • packages/bun/rust-1.99-type-info-of.patch

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

bryan-minimal and others added 2 commits November 13, 2026 14:13
bun 1.4.4 (#1492) carried rust-1.99-type-info-of.patch so it would
compile on rustc 1.99.1: a local core::mem::type_info::of in
bun_collections and a hand-written `impl Default for Start` in
lint_js.rs. Both APIs are in 1.100.0 (type_info::of under the type_info
feature, `impl Default for Once` stable as once_default), so upstream's
source compiles as written.

Remove the patch, its build.ncl Local entry, the patch/apply guards,
and the guard that failed on rustc >= 1.100. In its place build.sh
requires rustc >= 1.100, since bun 1.4.3+ now needs it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal bryan-minimal changed the title rust 1.99.1 -> 1.100.0 on a gen-16 rustc-1.99.1 stage0 (LLVM 23) — DRAFT, needs bootstrap rust 1.99.1 -> 1.100.0 on a gen-16 rustc-1.99.1 stage0 (LLVM 23); drops bun's 1.99 shims — DRAFT, needs gen-16 shas + rustc-1.100.0-src mirror Nov 13, 2026
amd64 02a0a9c8..., arm64 07b2fdce..., both compared clean across two
lab machines per arch. The arm64 object name carries the version
(rustc-1.99.1-1.99.1-aarch64.tar.zst), unlike gen-13's
rustc-1.98.1-aarch64, so the placeholder name is fixed too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal bryan-minimal changed the title rust 1.99.1 -> 1.100.0 on a gen-16 rustc-1.99.1 stage0 (LLVM 23); drops bun's 1.99 shims — DRAFT, needs gen-16 shas + rustc-1.100.0-src mirror rust 1.99.1 -> 1.100.0 on a gen-16 rustc-1.99.1 stage0 (LLVM 23); drops bun's 1.99 shims Nov 13, 2026
bryan-minimal and others added 3 commits November 13, 2026 17:49
pkgs builds libssh2 from the GitHub tag archive, whose include/libssh2.h says
LIBSSH2_VERSION "1.11.1_DEV" (release tarballs stamp the suffix out). CMake
copies it into libssh2.pc, libssh2_version() returns it, and the SSH banner sends
"SSH-2.0-libssh2_1.11.1_DEV". rust 1.100's cargo vendors libssh2-sys 0.3.4, whose
build.rs semver-parses the pkg-config version and panics on `_DEV`. That is the
#1493 failure on both arches, found by minimermetic-7f.

build.sh now stamps the release version into the header after the CVE patches
(none of which touch it), checks the header, and checks that the installed
libssh2.pc says `Version: <version>`. Both checks fail on unstamped input. The
version comes in as a build arg so the stamp follows bumps. Only rust and
rustc-1.98.1 import libssh2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rust 1.100 stabilized part of allocator_api and moved the rest to
allocator_ext. bun 1.4.4 (and bun main) pin nightly-2026-09-15, from before
the split, so 11 bun crates still enable allocator_api. On 1.100 that is
`-D stable-features` and no longer unlocks Vec::new_in as a const fn, which
failed bun_alloc in #1493's amd64 build.

build.sh renames the gate in every crate root that enables it (bundler and
shell_parser list it with other features), then fails if any is left. Tested
on the 1.4.4 tag's 11 crate roots: all 11 found before and none after, only
those lines change, and `allocator_api2::` is untouched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the gate

1826e84 renamed allocator_api to allocator_ext. On #1493's next build that
failed three ways: bun_ptr and bun_shell_parser only use the part 1.100
stabilized, so a lone allocator_ext is unused (-D unused-features); and
bun_collections lists the gate across lines, which the one-line pattern missed.

build.sh now leaves bun's gates alone and puts
  #![feature(allocator_ext)]
  #![allow(stable_features, unused_features)]
at the top of every crate root (a file with `#![feature`) that enables
allocator_api in any form, then checks each starts with both lines. Tested on
all 124 crate roots of the 1.4.4 tag: the 12 that enable it (collections
included) gain exactly those two lines, a decoy using `allocator_api2::` is
untouched, and the check fails when a file is left unpatched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal marked this pull request as ready for review November 14, 2026 20:01
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 14, 2026 20:01

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope. The diff matches the title and the PR body. It has the rung, the 1.100.0 bump, the amaro-wasm pin, three cargo build-dir fixes (rust-arm-embedded, broot, bun), and the libssh2 version stamp. Each hunk traces to a break that the PR body names. Clobber. None found. git log on bun, libssh2, broot and rust-arm-embedded shows only this branch's own commits on top of main.

Correctness.

  • rustc-1.99.1 differs from rustc-1.98.1 only in the gen, the shas, the version and llvm-21 -> llvm-23.
  • The removal of LD_LIBRARY_PATH is sound. rust keeps the default llvm (23.1.5) in runtime_deps, so /usr/lib/libLLVM.so.23.1 is in the build sandbox. llvm-23 is also 23.1.5.
  • No other package pins rustc 1.99 except verus-latest, which is its own toolchain.
  • No other build script reads the old target/<triple>/release/deps layout. charon already searches both the target dir and the build dir, and bat pins its own assets dir.
  • The bun allocator prepend puts inner attributes before other inner attributes and //! docs, which is valid. With no input files, xargs grep reads /dev/null, so it does not hang.
  • One nit is filed on the libssh2 fallback default.

Not checked. No compile, by policy. The broot package_id match and the rust-arm-embedded */<triple>/release/* filter were read against cargo's documented JSON shape, not against real output. The PR reports a green build on both arches at this head. The rung's DT_NEEDED TODO stays open, as the PR says.

Comment thread packages/libssh2/build.sh
echo "ERROR: include/libssh2.h LIBSSH2_VERSION is not \"${MINIMAL_ARG_VERSION:-1.11.1}\"" >&2
grep -n '^#define LIBSSH2_VERSION ' include/libssh2.h >&2
exit 1
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit · build.ncl now always passes version through build_args, so the ${MINIMAL_ARG_VERSION:-1.11.1} fallback (five occurrences) is dead code that hardcodes the version a second time. Use $MINIMAL_ARG_VERSION directly, as other packages do. With set -u, a missing build arg then fails at once and does not compare against a stale literal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants