Skip to content

tests: minimal test_deps for older standalone tests (batch 2 of 6, ddgr–google-java-format) - #1405

Merged
bryan-minimal merged 1 commit into
mainfrom
retest-minimal-deps-2
Nov 10, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
retest-minimal-deps-2

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

Re-checks older standalone tests with minimal test_deps (batch 2 of 6, ddgr–google-java-format): 26 packages, 49 tests.

These tests were written with test_deps = [base]. base brings in bash, coreutils, grep, sed, gawk, diffutils, findutils, tar, gzip, xz, bzip2, file and tzdata, and through them zlib, zstd, libmagic, libstdc++ and more. That masks missing runtime libraries: a binary that needs an undeclared library still loads, because base put the library in the test closure. The smoke-test batches of 11-06/07 (#1364–#1368, #1372, #1373) used minimal deps and found several real missing runtime_deps this way.

What changed

Only test_deps. No test command was changed.

  • base is removed from every test's test_deps.
  • bash-bootstrap is added where a command runs /bin/bash or /bin/sh (its only runtime_dep is glibc).
  • The base tools a script actually calls are added explicitly: coreutils, grep, diffutils, findutils, gawk, tar, gzip. They were found by scanning each script's command positions, including multi-line m%"…"% scripts and #!/usr/bin/env shebangs.
  • Other non-base deps (toolchain, jdk, ocaml, git, and so on) are kept as they were.
  • let base = import … stays wherever base is still a build dep.

tests are not part of the spec hash, so nothing rebuilds. This PR changes no package output.

Expected failures

Some of these tests are expected to fail. That is the point of the PR. A failure with the minimal closure, typically exit 127 with empty stderr (a loader failure) or a missing shared library, shows a package with an UNDECLARED runtime_dep that base was hiding. Each one gets fixed in a follow-up commit on this branch by adding the missing runtime_deps (which does rebuild that package). A failure can also come from a script calling a tool the scan missed. Those get fixed by adding that tool to test_deps, never by adding base back.

The failures were deliberately not predicted ahead of time. This PR exists so the build-bot runs every test under the minimal closure.

Tests

package test before after
ddgr smoke base bash-bootstrap
deno eval base bash-bootstrap, grep
deno tls_ca_store_default base bash-bootstrap, coreutils
deno global_install base bash-bootstrap
direnv envrc base bash-bootstrap, coreutils, grep
dive smoke base bash-bootstrap
dnsutils dig_version base bash-bootstrap
dotenvx smoketest base bash-bootstrap, grep
dotenvx run base bash-bootstrap, grep
dotenvx trust_store_without_emsign base bash-bootstrap, coreutils
dua smoke base bash-bootstrap
dune version_check base, grep, coreutils bash-bootstrap, grep, coreutils
dune builds_a_project base, ocaml, toolchain, grep, coreutils bash-bootstrap, ocaml, toolchain, grep, coreutils
edgedelta smoketest base bash-bootstrap
elfutils readelf_sections base, toolchain bash-bootstrap, toolchain, grep
emacs batch_eval base bash-bootstrap, grep
emacs byte_compile base bash-bootstrap
emacs gnutls base bash-bootstrap, grep
emacs libxml2_available base bash-bootstrap, grep
emacs zlib_available base bash-bootstrap, grep
emacs dynamic_modules base bash-bootstrap, grep
emacs threads base bash-bootstrap, grep
emacs inotify_file_notify base bash-bootstrap, grep
emacs emacsclient_runs base bash-bootstrap, grep
emacs tree_sitter base bash-bootstrap, grep
emacs treesit_predicate_syntax base bash-bootstrap, grep
emscripten version_check base (none)
emscripten no_build_scaffolding base bash-bootstrap, findutils
emscripten fetches_nothing base bash-bootstrap
emscripten compile_archive base bash-bootstrap
emscripten link_run base bash-bootstrap, grep
esbuild smoke base bash-bootstrap, coreutils, grep
foundationdb server_smoke base bash-bootstrap, coreutils, grep
fq decodes base bash-bootstrap, coreutils, gzip
fx reports_version base bash-bootstrap, grep
gcloud config_ops base bash-bootstrap, grep
gcloud ca_certs_from_system_store base bash-bootstrap, coreutils, grep
gdb capabilities base bash-bootstrap, grep
gef loads_into_gdb base bash-bootstrap, grep
ghidra sevenzip_java base, jdk bash-bootstrap, jdk, coreutils, findutils, grep
ghidra headless_decompile base, toolchain bash-bootstrap, toolchain, coreutils
git version_check base (none)
git basic_repo_ops base bash-bootstrap, coreutils, grep
git-lfs smoke base bash-bootstrap, grep
gitleaks smoke base bash-bootstrap, coreutils
gn smoketest base bash-bootstrap, grep
gnupg smoke base bash-bootstrap, coreutils, grep
google-java-format format base bash-bootstrap, diffutils
google-java-format check_mode base bash-bootstrap

🤖 Generated with Claude Code

…gr–google-java-format)

Replace `base` in test_deps with bash-bootstrap plus the tools each script
actually calls, so the test closure no longer masks undeclared runtime libraries.
Test commands are unchanged; tests are not in the spec hash.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 8, 2026 21:27
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 26 billable files and costs up to $6.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 4 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 5 included reviews currently available. Your 5 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between adc60ff and aa03c34.

Files selected for processing: 26

  • packages/ddgr/build.ncl
  • packages/deno/build.ncl
  • packages/direnv/build.ncl
  • packages/dive/build.ncl
  • packages/dnsutils/build.ncl
  • packages/dotenvx/build.ncl
  • packages/dua/build.ncl
  • packages/dune/build.ncl
  • packages/edgedelta/build.ncl
  • packages/elfutils/build.ncl
  • packages/emacs/build.ncl
  • packages/emscripten/build.ncl
  • packages/esbuild/build.ncl
  • packages/foundationdb/build.ncl
  • packages/fq/build.ncl
  • packages/fx/build.ncl
  • packages/gcloud/build.ncl
  • packages/gdb/build.ncl
  • packages/gef/build.ncl
  • packages/ghidra/build.ncl
  • packages/git-lfs/build.ncl
  • packages/git/build.ncl
  • packages/gitleaks/build.ncl
  • packages/gn/build.ncl
  • packages/gnupg/build.ncl
  • packages/google-java-format/build.ncl
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@agent-137 agent-137 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review on Karl's behalf. This is a comment, not an approval. Nothing was built for it. The findings come from reading the declarations and fetching upstream sources, and each one says how it was checked. The CI rollup on this head is now SUCCESS.

CI: all green, including minimal build SUCCESS. CodeRabbit was rate-limited and posted no review.

No findings. What I checked:

  • The tool scan for all 49 tests.
  • deno, bun-style CA tests and gcloud: no hostname lookups. The deno CA test only reads an env var.
  • jreleaser-style tar use: none in this batch.
  • ghidra launchers. Note: the launchers (support/*, bash) have no coreutils in runtime_deps. headless_decompile adds coreutils to test_deps, so that test would hide a launcher that needs it. I could not check this without the upstream scripts; it is not a failure.

Verdict: ready to approve.

@agent-137 agent-137 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at aa03c34. No should-fix findings; the nits in the earlier comment review are optional.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 11a4401 Nov 10, 2026
15 checks passed
@bryan-minimal
bryan-minimal deleted the retest-minimal-deps-2 branch November 10, 2026 03:30
bryan-minimal added a commit that referenced this pull request Nov 10, 2026
…et coreutils (#1405 added it)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants