Repository navigation
tests: minimal test_deps for older standalone tests (batch 2 of 6, ddgr–google-java-format) - #1405
Conversation
…gr–google-java-format) Replace `base` in test_deps with bash-bootstrap plus the tools each script actually calls, so the test closure no longer masks undeclared runtime libraries. Test commands are unchanged; tests are not in the spec hash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 26 billable files and costs up to $6.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 4 minutes for your next included review. View limit details
|
agent-137
left a comment
There was a problem hiding this comment.
Review on Karl's behalf. This is a comment, not an approval. Nothing was built for it. The findings come from reading the declarations and fetching upstream sources, and each one says how it was checked. The CI rollup on this head is now SUCCESS.
CI: all green, including minimal build SUCCESS. CodeRabbit was rate-limited and posted no review.
No findings. What I checked:
- The tool scan for all 49 tests.
- deno, bun-style CA tests and gcloud: no hostname lookups. The deno CA test only reads an env var.
- jreleaser-style tar use: none in this batch.
- ghidra launchers. Note: the launchers (
support/*, bash) have no coreutils in runtime_deps.headless_decompileadds coreutils to test_deps, so that test would hide a launcher that needs it. I could not check this without the upstream scripts; it is not a failure.
Verdict: ready to approve.
…et coreutils (#1405 added it) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-checks older standalone tests with minimal
test_deps(batch 2 of 6,ddgr–google-java-format): 26 packages, 49 tests.These tests were written with
test_deps = [base].basebrings in bash, coreutils, grep, sed, gawk, diffutils, findutils, tar, gzip, xz, bzip2, file and tzdata, and through them zlib, zstd, libmagic, libstdc++ and more. That masks missing runtime libraries: a binary that needs an undeclared library still loads, because base put the library in the test closure. The smoke-test batches of 11-06/07 (#1364–#1368, #1372, #1373) used minimal deps and found several real missing runtime_deps this way.What changed
Only
test_deps. No test command was changed.baseis removed from every test'stest_deps.bash-bootstrapis added where a command runs/bin/bashor/bin/sh(its only runtime_dep is glibc).coreutils,grep,diffutils,findutils,gawk,tar,gzip. They were found by scanning each script's command positions, including multi-linem%"…"%scripts and#!/usr/bin/envshebangs.toolchain,jdk,ocaml,git, and so on) are kept as they were.let base = import …stays whereverbaseis still a build dep.testsare not part of the spec hash, so nothing rebuilds. This PR changes no package output.Expected failures
Some of these tests are expected to fail. That is the point of the PR. A failure with the minimal closure, typically exit 127 with empty stderr (a loader failure) or a missing shared library, shows a package with an UNDECLARED runtime_dep that
basewas hiding. Each one gets fixed in a follow-up commit on this branch by adding the missingruntime_deps(which does rebuild that package). A failure can also come from a script calling a tool the scan missed. Those get fixed by adding that tool totest_deps, never by addingbaseback.The failures were deliberately not predicted ahead of time. This PR exists so the build-bot runs every test under the minimal closure.
Tests
basebash-bootstrapbasebash-bootstrap, grepbasebash-bootstrap, coreutilsbasebash-bootstrapbasebash-bootstrap, coreutils, grepbasebash-bootstrapbasebash-bootstrapbasebash-bootstrap, grepbasebash-bootstrap, grepbasebash-bootstrap, coreutilsbasebash-bootstrapbase, grep, coreutilsbash-bootstrap, grep, coreutilsbase, ocaml, toolchain, grep, coreutilsbash-bootstrap, ocaml, toolchain, grep, coreutilsbasebash-bootstrapbase, toolchainbash-bootstrap, toolchain, grepbasebash-bootstrap, grepbasebash-bootstrapbasebash-bootstrap, grepbasebash-bootstrap, grepbasebash-bootstrap, grepbasebash-bootstrap, grepbasebash-bootstrap, grepbasebash-bootstrap, grepbasebash-bootstrap, grepbasebash-bootstrap, grepbasebash-bootstrap, grepbase(none)basebash-bootstrap, findutilsbasebash-bootstrapbasebash-bootstrapbasebash-bootstrap, grepbasebash-bootstrap, coreutils, grepbasebash-bootstrap, coreutils, grepbasebash-bootstrap, coreutils, gzipbasebash-bootstrap, grepbasebash-bootstrap, grepbasebash-bootstrap, coreutils, grepbasebash-bootstrap, grepbasebash-bootstrap, grepbase, jdkbash-bootstrap, jdk, coreutils, findutils, grepbase, toolchainbash-bootstrap, toolchain, coreutilsbase(none)basebash-bootstrap, coreutils, grepbasebash-bootstrap, grepbasebash-bootstrap, coreutilsbasebash-bootstrap, grepbasebash-bootstrap, coreutils, grepbasebash-bootstrap, diffutilsbasebash-bootstrap🤖 Generated with Claude Code