Skip to content

tests: minimal test_deps for older standalone tests (batch 6 of 6, spire–zola) - #1409

Merged
bryan-minimal merged 1 commit into
mainfrom
retest-minimal-deps-6
Nov 10, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
retest-minimal-deps-6

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

Re-checks older standalone tests with minimal test_deps (batch 6 of 6, spire–zola): 25 packages, 35 tests.

These tests were written with test_deps = [base]. base brings in bash, coreutils, grep, sed, gawk, diffutils, findutils, tar, gzip, xz, bzip2, file and tzdata, and through them zlib, zstd, libmagic, libstdc++ and more. That masks missing runtime libraries: a binary that needs an undeclared library still loads, because base put the library in the test closure. The smoke-test batches of 11-06/07 (#1364–#1368, #1372, #1373) used minimal deps and found several real missing runtime_deps this way.

What changed

Only test_deps. No test command was changed.

  • base is removed from every test's test_deps.
  • bash-bootstrap is added where a command runs /bin/bash or /bin/sh (its only runtime_dep is glibc).
  • The base tools a script actually calls are added explicitly: coreutils, grep, diffutils, findutils, gawk, tar, gzip. They were found by scanning each script's command positions, including multi-line m%"…"% scripts and #!/usr/bin/env shebangs.
  • Other non-base deps (toolchain, jdk, ocaml, git, and so on) are kept as they were.
  • let base = import … stays wherever base is still a build dep.

tests are not part of the spec hash, so nothing rebuilds. This PR changes no package output.

Expected failures

Some of these tests are expected to fail. That is the point of the PR. A failure with the minimal closure, typically exit 127 with empty stderr (a loader failure) or a missing shared library, shows a package with an UNDECLARED runtime_dep that base was hiding. Each one gets fixed in a follow-up commit on this branch by adding the missing runtime_deps (which does rebuild that package). A failure can also come from a script calling a tool the scan missed. Those get fixed by adding that tool to test_deps, never by adding base back.

The failures were deliberately not predicted ahead of time. This PR exists so the build-bot runs every test under the minimal closure.

Tests

package test before after
spire server_smoketest base bash-bootstrap
spire agent_smoketest base bash-bootstrap
spire oidc_provider_smoketest base bash-bootstrap
spotbugs find_bug base bash-bootstrap, coreutils, grep
stow smoke base bash-bootstrap, coreutils
stress-ng smoke base bash-bootstrap, grep
tcl smoketest base bash-bootstrap, grep
tealdeer smoke base bash-bootstrap
tealdeer system_ca_default base, ca-certificates bash-bootstrap, ca-certificates, coreutils, grep
tlaplus sany base bash-bootstrap, coreutils, grep
tlaplus tlc base bash-bootstrap, coreutils, grep
tlaplus pcal base bash-bootstrap, coreutils, grep
tmd render base bash-bootstrap, grep
tmd notices base bash-bootstrap, grep
tree smoketest base bash-bootstrap, coreutils, grep
tuicr smoke base bash-bootstrap
typst template_path_escape_refused base bash-bootstrap, coreutils, grep
typst template_path_absolute_is_package_relative base bash-bootstrap, coreutils, grep
unzip roundtrip base bash-bootstrap, grep
upx pack_run_unpack base bash-bootstrap, coreutils, diffutils, grep
varlock smoke base bash-bootstrap, coreutils, grep
varlock trust_store_without_emsign base bash-bootstrap, coreutils
verus-latest smoke base bash-bootstrap, grep
vlt version_is_exact base bash-bootstrap, coreutils
vlt companion_bins_work base bash-bootstrap, coreutils
vlt reads_a_manifest base bash-bootstrap, coreutils
wasm-bindgen-cli version_check base bash-bootstrap, grep
which smoketest base bash-bootstrap, grep
xdg-utils smoketest base bash-bootstrap, grep
xh smoke base bash-bootstrap, grep
yojson findlib_resolve_and_run base, ocaml, dune, ocamlfind, toolchain, grep, coreutils bash-bootstrap, ocaml, dune, ocamlfind, toolchain, grep, coreutils
z3-4.16.0 smoke base bash-bootstrap, grep
zeromq compile_link base, toolchain, pkgconf, libsodium bash-bootstrap, toolchain, pkgconf, libsodium, coreutils, grep
zig compile_run base, glibc bash-bootstrap, glibc
zola smoke base bash-bootstrap

🤖 Generated with Claude Code

…ire–zola)

Replace `base` in test_deps with bash-bootstrap plus the tools each script
actually calls, so the test closure no longer masks undeclared runtime libraries.
Test commands are unchanged; tests are not in the spec hash.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 8, 2026 21:28
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 25 billable files and costs up to $6.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 4 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 5 included reviews currently available. Your 5 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between adc60ff and 57a590b.

Files selected for processing: 25

  • packages/spire/build.ncl
  • packages/spotbugs/build.ncl
  • packages/stow/build.ncl
  • packages/stress-ng/build.ncl
  • packages/tcl/build.ncl
  • packages/tealdeer/build.ncl
  • packages/tlaplus/build.ncl
  • packages/tmd/build.ncl
  • packages/tree/build.ncl
  • packages/tuicr/build.ncl
  • packages/typst/build.ncl
  • packages/unzip/build.ncl
  • packages/upx/build.ncl
  • packages/varlock/build.ncl
  • packages/verus-latest/build.ncl
  • packages/vlt/build.ncl
  • packages/wasm-bindgen-cli/build.ncl
  • packages/which/build.ncl
  • packages/xdg-utils/build.ncl
  • packages/xh/build.ncl
  • packages/yojson/build.ncl
  • packages/z3-4.16.0/build.ncl
  • packages/zeromq/build.ncl
  • packages/zig/build.ncl
  • packages/zola/build.ncl
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@agent-137 agent-137 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review on Karl's behalf. This is a comment, not an approval. Nothing was built for it. The findings come from reading the declarations and fetching upstream sources, and each one says how it was checked. The CI rollup on this head is now SUCCESS.

CI: all green, including minimal build SUCCESS. CodeRabbit was rate-limited and posted no review.

No findings. What I checked:

  • The tool scan for all 35 tests. unzip:roundtrip calls /bin/grep by absolute path, so grep is needed there.
  • xdg-utils, spotbugs and tlaplus wrappers: their runtime closures already carry bash, coreutils and sed, plus grep and gawk for xdg-utils.
  • xh tests use --offline, so no lookup.
  • vlt:version_is_exact: "grep" appears only in a comment.

Verdict: ready to approve.

@agent-137 agent-137 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 57a590b. No should-fix findings; the nits in the earlier comment review are optional.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit ea1ead2 Nov 10, 2026
15 checks passed
@bryan-minimal
bryan-minimal deleted the retest-minimal-deps-6 branch November 10, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants