Skip to content

Resolve importer TODOs: go-swagger, goose, podman-remote, prettier, typescript, yarn - #1413

Merged
bryan-minimal merged 1 commit into
mainfrom
importer-todo-cleanup
Nov 11, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
importer-todo-cleanup

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

Six packages still carried the importer's TODO: REVIEWER header. Each one is now checked against its real install tree, pulled from the artifact cache by spec hash:

package finding change
go-swagger, goose ELFs need only libresolv.so.2, libc.so.6 (glibc); build.sh already has -trimpath / -buildid= drop the TODO
podman-remote CGO_ENABLED=0, static, no DT_NEEDED runtime_deps = [], drop the unused glibc import and the TODO
prettier 3.9.10, typescript 7.0.2, yarn 1.22.22 no peerDependencies, no dependencies drop the "add any peer packages" TODO

Rebuilds: podman-remote only (mip dump before/after).

What's left of the importer TODOs is in packages touched by open PRs: gnupg, git-lfs (#1405), iputils (#1406), lsof (#1407) and stow (#1409). The gnupg libraries are #1411.

🤖 Generated with Claude Code

…ypescript, yarn

Checked against the cached install trees (cache.minimal.dev, by spec hash):
- go-swagger and goose link only libresolv.so.2 and libc.so.6, so
  runtime_deps [glibc] is right; their build.sh already pass -trimpath and
  -buildid=.
- podman-remote is CGO_ENABLED=0 with no DT_NEEDED at all, so its glibc
  runtime dep goes (and the now-unused import).
- prettier 3.9.10, typescript 7.0.2 and yarn 1.22.22 declare no peer or
  runtime dependencies, so the "add any peer packages" TODO has nothing
  to add.

Rebuilds: podman-remote only (mip dump before/after).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 9, 2026 23:25
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 6 billable files and costs up to $1.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 10 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available. Your 39 included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f938675 and b7f6595.

Files selected for processing: 6

  • packages/go-swagger/build.ncl
  • packages/goose/build.ncl
  • packages/podman-remote/build.ncl
  • packages/prettier/build.ncl
  • packages/typescript/build.ncl
  • packages/yarn/build.ncl
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope matches the title. The diff removes six importer TODO: REVIEWER headers and drops the glibc runtime edge and its import from podman-remote. Clobber none found: each hunk deletes only the importer header, and the podman-remote edit touches only runtime_deps and its import. Correctness packages/podman-remote/build.sh:15 builds with CGO_ENABLED=0 and the remote tag, so runtime_deps = [] is correct. helm is the same kind of package and already uses the same form (packages/helm/build.ncl:26). The remaining TODO: REVIEWER headers are in gnupg, the gnupg libraries, git-lfs, iputils and lsof, as the PR body says. The prettier and yarn lockfiles pin only the root package. The typescript lockfile does not: TypeScript 7 pulls a prebuilt native compiler through optionalDependencies (see finding). Pre-existing and outside the diff: podman-remote still lists toolchain in build_deps, but a CGO_ENABLED=0 build does not use it. Not checked I did not inspect ELF DT_NEEDED entries for go-swagger, goose or the TypeScript native binary, because that needs the built artifacts.

# Imported from npm `typescript` by `pkgmgr import npm` (node build).
# TODO: REVIEWER — installs `typescript` from npm; add any peer packages the
# tool needs (cf. typescript-language-server pulling `typescript`).
let { standaloneTest, subsetOf, Attrs, BuildSpec, Local, Needs, OutputBin, OutputData, .. } = import "minimal.ncl" in

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low · The removed TODO asked the reviewer to verify the install. The PR says typescript has "no dependencies". That is not correct: TypeScript 7 declares 20 optionalDependencies, and npm ci --omit=dev installs @typescript/typescript-linux-x64. That package is a prebuilt native compiler binary from npm, not JavaScript. AGENTS.md says to build from source when the toolchain is packaged, and go is packaged. Keep a note in build.ncl that the package ships an upstream prebuilt binary and why, or open an issue for a source build. Also check the binary's DT_NEEDED before you call runtime_deps complete. The check is local to typescript: the prettier and yarn lockfiles pin only the root package.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit f27591c Nov 11, 2026
15 checks passed
@bryan-minimal
bryan-minimal deleted the importer-todo-cleanup branch November 11, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants