Repository navigation
gotpm: add 0.4.11 (google/go-tpm-tools) - #1548
Open
bryan-minimal wants to merge 1 commit into
Open
bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
The res-servers run `gotpm attest --key gceAK` to quote each build's nonce with the Shielded VM's vTPM, for the Package Build Log. The prod res-servers have no gotpm today, so no statement binds a quote (gominimal/build-servers#554). Built without cgo so the binary runs on the host as it is. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 4 minutes for your next included review. View limit details
|
bryan-minimal
marked this pull request as ready for review
November 17, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A new package,
gotpm: the command-line tool of google/go-tpm-tools, v0.4.11, built without cgo.Why
The res-servers run
gotpm attest --key gceAKto quote each build's nonce with the Shielded VM's vTPM, for the Package Build Log. The prod res-servers have nogotpmbinary, so no published statement binds a quote (gominimal/build-servers#554). Building it here means the binary the res-servers run has signed provenance and is pinned by digest, in place of a download from GitHub at boot.Notes
CGO_ENABLED=0: the binary has to run on the res-server host (Ubuntu), outside any minimal sandbox. In the repository only the TPM simulator and the key manager use cgo; I have not confirmed by building thatgotpmlinks neither. build-bot's build is the check.gh release download --archive tar.gzgave for the tag. I expect thearchive/refs/tagsURL to serve the same bytes; a mismatch fails the fetch.cmd/go.mod, with the repository'sgo.work), and asks for Go 1.26.5 or later; the registry has 1.27.4.🤖 Generated with Claude Code