Skip to content

gotpm: add 0.4.11 (google/go-tpm-tools) - #1548

Open
bryan-minimal wants to merge 1 commit into
mainfrom
add-gotpm
Open

bryan-minimal wants to merge 1 commit into
mainfrom
add-gotpm

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

What

A new package, gotpm: the command-line tool of google/go-tpm-tools, v0.4.11, built without cgo.

Why

The res-servers run gotpm attest --key gceAK to quote each build's nonce with the Shielded VM's vTPM, for the Package Build Log. The prod res-servers have no gotpm binary, so no published statement binds a quote (gominimal/build-servers#554). Building it here means the binary the res-servers run has signed provenance and is pinned by digest, in place of a download from GitHub at boot.

Notes

  • CGO_ENABLED=0: the binary has to run on the res-server host (Ubuntu), outside any minimal sandbox. In the repository only the TPM simulator and the key manager use cgo; I have not confirmed by building that gotpm links neither. build-bot's build is the check.
  • The source sha256 is of the archive gh release download --archive tar.gz gave for the tag. I expect the archive/refs/tags URL to serve the same bytes; a mismatch fails the fetch.
  • The command is its own Go module (cmd/go.mod, with the repository's go.work), and asks for Go 1.26.5 or later; the registry has 1.27.4.
  • Not built locally.

🤖 Generated with Claude Code

The res-servers run `gotpm attest --key gceAK` to quote each build's nonce
with the Shielded VM's vTPM, for the Package Build Log. The prod
res-servers have no gotpm today, so no statement binds a quote
(gominimal/build-servers#554). Built without cgo so the binary runs on the
host as it is.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 4 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between eaabbf3 and 7dc236d.

Files selected for processing: 2

  • packages/gotpm/build.ncl
  • packages/gotpm/build.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@bryan-minimal
bryan-minimal marked this pull request as ready for review November 17, 2026 20:40
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 17, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant