Repository navigation
atuin: pkgscan-allow the Hermes plugin's Popen of atuin itself (18.24.8) - #1505
Merged
Merged
Conversation
….24.8) pkgscan flagged a High ProcessSpawn in crates/atuin-common/res/harnesstools/hermes/__init__.py, new in 18.24.7-8 (atuinsh/atuin#4689, #4701, #4718). It runs atuin's own binary with the hook event on stdin, with no shell and no network. Pinned to the file's sha256. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 20 minutes for your next included review. View limit details
|
norrietaylor
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the atuin 18.24.6 -> 18.24.8 update, which pkgscan stopped on a High ProcessSpawn finding.
The finding is a false positive.
crates/atuin-common/res/harnesstools/hermes/__init__.pyis new in 18.24.7–8: atuin's plugin for the Hermes AI agent, written by atuin maintainer Michelle Tilley in reviewed PRs atuinsh/atuin#4689, #4701 and #4718.atuin hook install hermescopies it into Hermes's plugin directory so the shell commands Hermes runs are recorded in atuin's history.subprocess.Popen(High): runs[ATUIN, "hook", "hermes"], atuin's own binary at an absolute path written at install. It uses an argument list (no shell), sends the event as JSON on stdin, sends stdout and stderr to DEVNULL, and has a timeout.os.environ(Medium, doesn't gate): that same call's environment, plus atuin's config paths.hermes atuin import <file>.The stanza is pinned to the file's sha256 (
236e7eda…), so any upstream change to the file makes it gate again. A match regrades the finding, never hides it.An agent drafted this. Allowlist entries are a security decision, so a human should review and merge it (see #1113).
🤖 Generated with Claude Code