Repository navigation
Update stacked: lz4 1.11.0 -> 1.11.1 - #1524
gominimal-pkgmgr-mgr[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
norrietaylor
left a comment
There was a problem hiding this comment.
Scope matches the title. The diff changes the version string, the source sha256, and the two hardcoded paths in build.sh. Clobber none. git log on packages/lz4 shows the gen-13 bootstrap pin (#1242) and the 1.11.0 bump (#1385). The diff keeps both, and replace_on_cycle is unchanged. Correctness The version binding, the %{version} URL and the build.sh paths agree on 1.11.1. Secrets: none in the diff. Not checked The gs://minimal-staging-archives tarball and its hash need a fetch from a private bucket. I did not run a build. So I did not confirm that the 1.11.0 workarounds in build.sh are still necessary on 1.11.1: the CPPFLAGS=-DNDEBUG export and the install-only target. Their comments (lines 16-24, outside the diff) still name 1.11.0. Re-check them against the 1.11.1 Makefile, then update or remove them.
| tar -xof lz4-1.11.0.tar.gz | ||
| cd lz4-1.11.0 | ||
| tar -xof lz4-1.11.1.tar.gz | ||
| cd lz4-1.11.1 |
There was a problem hiding this comment.
low · build.sh hardcodes 1.11.1 in a second place. Each bump must edit it beside the version binding in build.ncl, and this PR shows that. AGENTS.md asks for build_args = { include version } and $MINIMAL_ARG_VERSION. With that change, a bump is one edit in build.ncl. Add build_args = { include version }, to build.ncl and use lz4-$MINIMAL_ARG_VERSION here. This is one of 35 build.sh files with a hardcoded tarball name, and 170 use the variable. So the fix is local, but the pattern repeats.
Update base-soup (1 package)
Note
lz4declaresreplace_on_cyclein build.ncl, so they take part inthe toolchain rebuild graph and one hash change cascades through the
set. Bundling lands the cascading rebuild as a single unit, even when
only one package is bumping, which avoids back-to-back full rebuilds
from singleton PRs.
Note
Build risk — 5 dependents across the tree. Package(s) that
build- or runtime-depend on a member of this bundle may need a rebuild,
or could FTBFS on an API/ABI change. Informational (not blocking) — a
heads-up for the reviewer on what this bump can ripple into.
lz4file,postgres,rizin,rsync,zstdSummary
1.11.01.11.1github:lz4/lz4:release-asset:operator-pinnedPer-package details
lz4 1.11.0 → 1.11.1247e5fa64da5f7b7...→683fed08a844ad01...gs://minimal-staging-archives/lz4-1.11.0.tar.gz→gs://minimal-staging-archives/lz4-1.11.1.tar.gzgithub.com— Sectigo Public Server Authentication CA DV E36 → Sectigo Public Server Authentication Root E46 (rootc90f26f0fb1b4018…) · TLSv1_3 · TLS13_AES_128_GCM_SHA256 · X25519 ⇒release-assets.githubusercontent.com— YR1 → Root YR → ISRG Root X1 (root96bcec06264976f3…) · TLSv1_3 · TLS13_AES_128_GCM_SHA256 · X25519License
1.11.0→1.11.1: unchanged, license files byte-identical (LICENSE)license_spdx:BSD-2-Clause AND GPL-2.0-or-later, not checked against upstream: the detector couldn't identify the new release's license files with confidenceCreated by pkgmgr