Repository navigation
virtio-linux: enable conntrack marks for the guest classifier table - #803
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe kernel build script adds ChangesKernel configuration
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The required kernel option can be enabled under the declared configuration; no merge-blocking risk was identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…minimal#1962) * build: bump the pkgs locked_commit for the guest kernel's conntrack marks Picks up gominimal/pkgs#803, which enables CONFIG_NF_CONNTRACK_MARK in the virtio-linux guest kernel. The guest classifier table's ct mark rule needs it (T75, gominimal#1886). One pkgs commit; the only file it changes is packages/virtio-linux/build.sh. * build: bump the pkgs locked_commit for the timezone database in base gominimal/pkgs#804 adds tzdata to base, so boxes resolve TZ=Area/City and Python's zoneinfo finds its zones.
The guest minimald's classifier table (
inet minimal_class) tags each new flow with its box's verdict and reads it back:ct mark set ct mark and 0xcfffffff or 0x10000000. That isct mark, which needsCONFIG_NF_CONNTRACK_MARK. defconfig leaves it off. Without it,nft_ctanswersEOPNOTSUPP, sonft -crejects the whole table with "Could not process rule: Not supported", and the guest never loads the table.Evidence:
c5839783, after virtio-linux, microvm-rootfs: add nftables socket support and nft to the guest #798) has# CONFIG_NF_CONNTRACK_MARK is not setin its embedded IKCONFIG. NFT_CT, NFT_SOCKET, NFT_NAT, NFT_REJECT_INET, NFT_LOG and NFT_LIMIT are all=y.ct markload).nft -c -f -on a stock Ubuntu 6.17 kernel, which hasCONFIG_NF_CONNTRACK_MARK=y.This adds
want NF_CONNTRACK_MARKbeside the NFT_SOCKET group from #798, so the existing assert catches a drop. It unblocks gominimal/minimal#1886 (the guest classifier testguest_classifier_table_present) once minimal's pin moves to this commit.Summary by CodeRabbit