Skip to content

tzdata: source_provenance eggert/tz (restores advisory coverage) - #815

Merged
bryan-minimal merged 1 commit into
mainfrom
tzdata-source-provenance
Oct 10, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
tzdata-source-provenance

Conversation

@bryan-minimal

@bryan-minimal bryan-minimal commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

pkgmgr reported tzdata (added in #804) as a monitoring gap: it has no source_provenance and no curated CPE, so a scan of 0/0/0 couldn't be told apart from "unable to check".

Why not a CPE (the alert's first suggestion). NVD's CPE dictionary has no entry for the tz database under any vendor (tzdata, tzcode, tz database, time zone database and the iana vendor all return 0, while the same API returns 760 for openssl). Every tz-like CPE in our vulndb is a false friend: SonicWall TZ-series firewalls, a "time zone clocks" plugin, and moment-timezone (a JS library). Curating one of those would attach someone else's CVEs.

Fix. source_provenance = GithubRepo eggert/tz: the tz project's own repository (actively maintained, last push 2026-10-04). Its tags match our version scheme (2026e, 2026d, …). This gives tzdata a real advisory identity for GitHub-advisory and OSV lookups, plus a cross-check for version tracking. The download is unchanged (still data.iana.org); provenance only drives lookups.

Exposure note. This package ships only compiled zone data (usr/share/zoneinfo/**, built by glibc's zic), none of tzcode, so a genuinely clean result is the expected outcome. The point is that it will now be a result.

Needs a human reviewer; build + tests are the merge gate.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated source attribution for the time zone data package. Archive downloads continue to use the existing source, while advisory and version lookups use the newly recorded project repository. No changes were made to package exports or user-facing behavior.

pkgmgr flagged tzdata (new in #804) as a MONITORING GAP: no source_provenance
and no curated CPE, so its 0/0/0 was indistinguishable from "cannot check".
A CPE cannot fix it: NVD's CPE dictionary has no entry for the tz database
under any vendor, and every tz-ish CPE in our vulndb is a false friend
(SonicWall TZ firewalls, moment-timezone, ...).

eggert/tz is the tz project's own repository; its tags match our version
scheme (2026e). The download stays on data.iana.org; provenance only drives
advisory and version lookups.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner October 5, 2026 16:58
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: gominimal/pkgs/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 9a0e1841-ca01-41d6-9a62-5c00cc82604a
📥 Commits

Reviewing files that changed from the base of the PR and between eaf783e and 0164f8f.

📒 Files selected for processing (1)
  • packages/tzdata/build.ncl

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


📝 Walkthrough

Walkthrough

The tzdata package now declares the eggert/tz GitHub repository as source provenance. Its archive download remains configured to use data.iana.org.

Changes

tzdata Repository Provenance

Layer / File(s) Summary
Declare repository provenance
packages/tzdata/build.ncl
The package attributes add eggert/tz as GitHub repository provenance. The configured archive source remains unchanged.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: norrietaylor

Merge Risk: ⚪ Minimal · up to 0164f

The release identity matches, but advisory matching for this data-only package remains unknown; no concrete misclassification is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the tzdata provenance change and its purpose of restoring advisory coverage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: IANA's own tz-link.html and the CONTRIBUTING file inside tzdata2026e.tar.gz both name github.com/eggert/tz as the development repository, and tag 2026e exists there, so this is upstream-of-record rather than a mirror. Same shape as curl, ffmpeg, go, nginx, node-lts, ruby, zig on main (GithubRepo provenance with a non-GitHub release URL). Source URL/sha256 unchanged and re-verified.

Nit: the 4-line comment at build.ncl:33-36 narrates the PR rationale (pkgmgr coverage gap, NVD CPE). A one-liner like # tz development repo (IANA coordinator); release tags match this version scheme. would age better.

@bryan-minimal
bryan-minimal added this pull request to the merge queue Oct 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 9, 2026
@bryan-minimal
bryan-minimal added this pull request to the merge queue Oct 10, 2026
Merged via the queue into main with commit 901d8f1 Oct 10, 2026
11 checks passed
@bryan-minimal
bryan-minimal deleted the tzdata-source-provenance branch October 10, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants