Repository navigation
tzdata: source_provenance eggert/tz (restores advisory coverage) - #815
Conversation
pkgmgr flagged tzdata (new in #804) as a MONITORING GAP: no source_provenance and no curated CPE, so its 0/0/0 was indistinguishable from "cannot check". A CPE cannot fix it: NVD's CPE dictionary has no entry for the tz database under any vendor, and every tz-ish CPE in our vulndb is a false friend (SonicWall TZ firewalls, moment-timezone, ...). eggert/tz is the tz project's own repository; its tags match our version scheme (2026e). The download stays on data.iana.org; provenance only drives advisory and version lookups. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe tzdata package now declares the Changestzdata Repository Provenance
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The release identity matches, but advisory matching for this data-only package remains unknown; no concrete misclassification is established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
norrietaylor
left a comment
There was a problem hiding this comment.
Verified: IANA's own tz-link.html and the CONTRIBUTING file inside tzdata2026e.tar.gz both name github.com/eggert/tz as the development repository, and tag 2026e exists there, so this is upstream-of-record rather than a mirror. Same shape as curl, ffmpeg, go, nginx, node-lts, ruby, zig on main (GithubRepo provenance with a non-GitHub release URL). Source URL/sha256 unchanged and re-verified.
Nit: the 4-line comment at build.ncl:33-36 narrates the PR rationale (pkgmgr coverage gap, NVD CPE). A one-liner like # tz development repo (IANA coordinator); release tags match this version scheme. would age better.
pkgmgr reported tzdata (added in #804) as a monitoring gap: it has no
source_provenanceand no curated CPE, so a scan of 0/0/0 couldn't be told apart from "unable to check".Why not a CPE (the alert's first suggestion). NVD's CPE dictionary has no entry for the tz database under any vendor (
tzdata,tzcode,tz database,time zone databaseand theianavendor all return 0, while the same API returns 760 for openssl). Every tz-like CPE in our vulndb is a false friend: SonicWall TZ-series firewalls, a "time zone clocks" plugin, andmoment-timezone(a JS library). Curating one of those would attach someone else's CVEs.Fix.
source_provenance = GithubRepo eggert/tz: the tz project's own repository (actively maintained, last push 2026-10-04). Its tags match our version scheme (2026e,2026d, …). This gives tzdata a real advisory identity for GitHub-advisory and OSV lookups, plus a cross-check for version tracking. The download is unchanged (stilldata.iana.org); provenance only drives lookups.Exposure note. This package ships only compiled zone data (
usr/share/zoneinfo/**, built by glibc'szic), none of tzcode, so a genuinely clean result is the expected outcome. The point is that it will now be a result.Needs a human reviewer; build + tests are the merge gate.
🤖 Generated with Claude Code
Summary by CodeRabbit