Repository navigation
leaflet: add 1.9.4 - #988
Conversation
Browser map library, no bin: the sha256-pinned registry tarball unpacked into a package-private prefix, the same layout as serve and next. Review fixes from #966: minimal.ncl import on line 1, no coreutils runtime dep, the test reads `version`, and source_provenance (Leaflet/Leaflet) alongside binary_from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 7 minutes for your next included review. View limit details
Comment |
norrietaylor
left a comment
There was a problem hiding this comment.
All four points from #966 are addressed:
- the import is on line 1;
runtime_deps = [];- the test uses
%{version}; source_provenanceis set alongsidebinary_from.
The sha256 matches the registry tarball (the sha512 matches npm's integrity too), the license is BSD-2-Clause, and the usr/libexec/leaflet layout is right.
I'm fine shipping upstream's rollup-built dist/. Since node is packaged, though, AGENTS.md asks for the reason to be called out, and build.ncl:46 states the fact but not the why. Please add one line there (e.g. that upstream's rollup + uglify build needs network devDeps). I'll approve once that's in.
Optional: src/geo/crs/CRS.Earth.js and src/layer/tile/GridLayer.js carry +x upstream, so a chmod -R a-x would tidy the data output.
Generated by Claude Code
…data files Review follow-ups: upstream's `npm run build` is rollup + uglify-js with rollup-plugin-git-version/git-rev-sync (network devDependencies that also read a .git checkout the tarball lacks). Two sources carry +x in the tarball; build.sh clears it on files (not dirs) and asserts none remain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks @norrietaylor. Both points are addressed in 7ada749, on top of a merge of main (1b22586).
Verification, in a fresh remote session: 🤖 Generated with Claude Code |
mitodrummer
left a comment
There was a problem hiding this comment.
The sha256 matches registry.npmjs.org's leaflet-1.9.4.tgz, and its sha512 matches npm's integrity field. The package has no dependencies and no install scripts, and its license is BSD-2-Clause. All four points from #966 and norrietaylor's follow-ups (why the prebuilt dist/ is shipped, +x cleared on data files) are in 7ada749, and minimal build is green. Whether a browser-only library belongs in the catalog is a scope question the PR raises itself; that is a maintainer call, not a defect.
Adds
leaflet1.9.4, the browser map library. Split out of #966 at review, since it's unrelated tonext.What
/usr/libexec/leaflet/lib/node_modules/leaflet. That's the layoutnpm install -g --prefixgivesserveandnext, so a project can link it into its ownnode_modules.dist/, sobinary_frompoints at it.source_provenanceisLeaflet/Leaflet, and the licence is BSD-2-Clause, matching the repo's own.Changes from #966's version (norrie's review)
minimal.nclimport moved to line 1.coreutilsruntime dep dropped. Nothing runs at runtime;runtime_deps = [].%{version}instead of a hard-coded"1.9.4".source_provenanceadded alongsidebinary_from.Scope question
This is a browser-only library with prebuilt rollup output, so whether it belongs in the registry is a scope call. It was added for a project that builds a Next app entirely from registry packages.
Verified
nickel format --checkandbash -npass, andmip dump --packagesevaluates.min package build --rebuild leafletbuilt it.min check --packages leafletpassed every check, includingstandalone tests...Pass, not Skip.🤖 Generated with Claude Code