Repository navigation
direnv, mailpit, overmind: Rails dev tools - #991
Merged
Merged
Conversation
Split out of #848. Go tools built with -trimpath -buildid=; mailpit's web UI follows the node-lts pattern. mailpit's SMTP round-trip test now kills the daemon it starts on exit instead of leaving it running. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 6 billable files and costs up to $1.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 47 minutes for your next included review. View limit details
Comment |
norrietaylor
approved these changes
Oct 22, 2026
norrietaylor
left a comment
Member
There was a problem hiding this comment.
LGTM. The mailpit test now kills its daemon in an EXIT trap without masking the test status. direnv and overmind are unchanged from #848, and I'm accepting the session min check evidence.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #848, as suggested in review. This PR is the Rails dev tools. It is independent of the other three parts.
direnv: per-directory environment loading (.envrc).mailpit: a local SMTP sink with a web UI, for Action Mailer in development. The UI is built with node-lts, following the node-lts pattern.overmind: a Procfile process manager (bin/dev), on tmux.The Go tools build with
-trimpath -buildid=.Review point from #848
EXITtrap, pass or fail. The shell's exit status is unchanged by the trap.(libidn's man/info outputs are answered on the locale PR, where libidn now lives.)
Verification. A fresh remote session (
pkgbuildloadout) ranmin package build --rebuild direnv mailpit overmind, which built all three, thenmin check --packages direnv mailpit overmind. Every check is Pass for all three, with no Skip, including enumerate bins, output types, missing runtime_deps and the standalone tests (mailpit's SMTP round trip included).nickel format --check,bash -nandmip dump(amd64 and arm64) are clean.🤖 Generated with Claude Code