Skip to content

direnv, mailpit, overmind: Rails dev tools - #991

Merged
bryan-minimal merged 1 commit into
mainfrom
split848-d-devtools
Oct 23, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
split848-d-devtools

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

Split out of #848, as suggested in review. This PR is the Rails dev tools. It is independent of the other three parts.

  • direnv: per-directory environment loading (.envrc).
  • mailpit: a local SMTP sink with a web UI, for Action Mailer in development. The UI is built with node-lts, following the node-lts pattern.
  • overmind: a Procfile process manager (bin/dev), on tmux.

The Go tools build with -trimpath -buildid=.

Review point from #848

  • mailpit's test no longer leaves the daemon running. It now starts mailpit as a child of the test shell, keeps its pid, and kills it through an EXIT trap, pass or fail. The shell's exit status is unchanged by the trap.

(libidn's man/info outputs are answered on the locale PR, where libidn now lives.)

Verification. A fresh remote session (pkgbuild loadout) ran min package build --rebuild direnv mailpit overmind, which built all three, then min check --packages direnv mailpit overmind. Every check is Pass for all three, with no Skip, including enumerate bins, output types, missing runtime_deps and the standalone tests (mailpit's SMTP round trip included). nickel format --check, bash -n and mip dump (amd64 and arm64) are clean.

🤖 Generated with Claude Code

Split out of #848. Go tools built with -trimpath -buildid=; mailpit's web
UI follows the node-lts pattern. mailpit's SMTP round-trip test now kills
the daemon it starts on exit instead of leaving it running.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner October 22, 2026 19:23
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 6 billable files and costs up to $1.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 47 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 63 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between befeac7 and 8837cf6.

📒 Files selected for processing: 6
  • packages/direnv/build.ncl
  • packages/direnv/build.sh
  • packages/mailpit/build.ncl
  • packages/mailpit/build.sh
  • packages/overmind/build.ncl
  • packages/overmind/build.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The mailpit test now kills its daemon in an EXIT trap without masking the test status. direnv and overmind are unchanged from #848, and I'm accepting the session min check evidence.


Generated by Claude Code

@bryan-minimal
bryan-minimal added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit cdf4424 Oct 23, 2026
11 checks passed
@bryan-minimal
bryan-minimal deleted the split848-d-devtools branch October 23, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants