Repository navigation
Fix Ingress creation/deletion loop - #12404
Merged
Merged
Conversation
DGuhr
previously approved these changes
Jun 8, 2022
DGuhr
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the quick fix! Have you also provided a PR to prod REL branch so we can backport it?
Contributor
Author
|
Thanks for the quick review @DGuhr , I will as soon as this gets merged. |
Contributor
Author
|
I forgot to fix this line: Let's hope the tests are green now 🤞 |
Contributor
Author
|
@abstractj can we please, prioritize merging this PR as it should be backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12274
as agreed the logic is unit tested.