Skip to content

Fix Ingress creation/deletion loop - #12404

Merged
abstractj merged 1 commit into
keycloak:mainfrom
andreaTP:issue-12274
Jun 9, 2022
Merged

abstractj merged 1 commit into
keycloak:mainfrom
andreaTP:issue-12274

Conversation

@andreaTP

@andreaTP andreaTP commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Resolves #12274

as agreed the logic is unit tested.

@andreaTP
andreaTP requested review from DGuhr and vmuzikar June 8, 2022 17:11
DGuhr
DGuhr previously approved these changes Jun 8, 2022

@DGuhr DGuhr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix! Have you also provided a PR to prod REL branch so we can backport it?

@andreaTP

andreaTP commented Jun 8, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the quick review @DGuhr , I will as soon as this gets merged.

@andreaTP

andreaTP commented Jun 8, 2022

Copy link
Copy Markdown
Contributor Author

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreaTP LGTM, thank you!

@vmuzikar
vmuzikar requested a review from abstractj June 9, 2022 07:10
@andreaTP

andreaTP commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

@abstractj can we please, prioritize merging this PR as it should be backported to 18.0.1?

@abstractj
abstractj merged commit a40acd4 into keycloak:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ingress creation loop

4 participants