Skip to content

Fix OpenshiftClientStorageTest.testCodeGrantFlowWithServiceAccountUsingOAuthRedirectReference - #15741

Merged
stianst merged 1 commit into
keycloak:mainfrom
stianst:OpenshiftClientStorageTest
Nov 29, 2022
Merged

Fix OpenshiftClientStorageTest.testCodeGrantFlowWithServiceAccountUsingOAuthRedirectReference#15741
stianst merged 1 commit into
keycloak:mainfrom
stianst:OpenshiftClientStorageTest

Conversation

@stianst

@stianst stianst commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Closes #15565

@stianst
stianst force-pushed the OpenshiftClientStorageTest branch from 08447ca to 2ed950a Compare November 29, 2022 11:01
@stianst
stianst force-pushed the OpenshiftClientStorageTest branch from 2ed950a to 78717ff Compare November 29, 2022 11:05
@lhanusov
lhanusov self-requested a review November 29, 2022 11:41
lhanusov
lhanusov approved these changes Nov 29, 2022
View reviewed changes

@lhanusov lhanusov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - discussed in gchat.

@stianst

stianst commented Nov 29, 2022

Copy link
Copy Markdown
Contributor Author

The issue is caused by the use of https://myapp.org/callback. If I switch this to https://myapp.internal/callback I can reproduce the same issue. This means the stability of the test is depending on the stability of https://myapp.org, and we should not have external dependencies like these in the tests.

I've updated the tests to simply use 127.0.0.1 instead, which at least is passing locally

@stianst
stianst merged commit c3c858c into keycloak:main Nov 29, 2022
@stianst
stianst deleted the OpenshiftClientStorageTest branch November 29, 2022 13:20
andre-nascimento6791 pushed a commit to andre-nascimento6791/keycloak-cnd-work that referenced this pull request Dec 1, 2022
@stianst @andre-nascimento6791
Fix OpenshiftClientStorageTest.testCodeGrantFlowWithServiceAccountUsi…
0545ccb 
…ngOAuthRedirectReference (keycloak#15741)

Closes keycloak#15565
@ahus1 ahus1 mentioned this pull request Dec 8, 2022
Merged
ahus1 pushed a commit to ahus1/keycloak that referenced this pull request Dec 8, 2022
@stianst @ahus1
Fix OpenshiftClientStorageTest.testCodeGrantFlowWithServiceAccountUsi…
bd2a371 
…ngOAuthRedirectReference (keycloak#15741)

Closes keycloak#15565
@ahus1 ahus1 mentioned this pull request Dec 8, 2022
Merged
mhajas pushed a commit that referenced this pull request Dec 12, 2022
@stianst @mhajas
Fix OpenshiftClientStorageTest.testCodeGrantFlowWithServiceAccountUsi…
10813db 
…ngOAuthRedirectReference (#15741)

Closes #15565
@stianst stianst mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes
+1 more reviewer
@lhanusov lhanusov lhanusov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: OpenshiftClientStorageTest.testCodeGrantFlowWithServiceAccountUsingOAuthRedirectReference

3 participants

@stianst @pedroigor @lhanusov