Repository navigation
Conversation
pedroigor
reviewed
Nov 1, 2022
Contributor
There was a problem hiding this comment.
We can use this option to choose between JTA and RESOURCE_LOCAL. See
Member
Author
There was a problem hiding this comment.
Included in the latest commit
Contributor
There was a problem hiding this comment.
In the past, we had some discussions with Quarkus team about it. We can involve them again to see the implications of doing this. At that time, the discussions were around JTA, perhaps using resource local it can work well.
Member
Author
There was a problem hiding this comment.
As agreed in today's call, I'll reach out to experts in Quarkus/Hibernate/Agroal to discuss this. Still, this PR will be merged to fix the problems we currently experience.
ahus1
force-pushed
the
is-15248-test-resource-local-on-quarkus-for-jpa-map-storage
branch
from
November 1, 2022 14:05
c5d9e34 to
d259092
Compare
ahus1
marked this pull request as ready for review
November 1, 2022 19:39
Member
Author
|
@vramik - after the builds are finally green this is now ready for review. |
pedroigor
approved these changes
Nov 1, 2022
This was referenced Nov 3, 2022
ahus1
deleted the
is-15248-test-resource-local-on-quarkus-for-jpa-map-storage
branch
November 23, 2022 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15248