Repository navigation
Refactor Profile - #15341
Refactor Profile#15341
Conversation
9368573 to
e1215a1
Compare
There was a problem hiding this comment.
There's no longer CLI output at startup to warn for preview/experimental features, so not sure how to test this.
There was a problem hiding this comment.
Can we add some debug/trace logging? It should be simpler and only require configuring the log-level to the tests.
There was a problem hiding this comment.
Changed to using a single log statement, and output both for build and start. Doesn't hurt to output for both in case folks are using an optimized build from elsewhere or something they wouldn't necessarily see the build output at all.
|
@pedroigor Initially I also moved Feature into a separate class, but changed it back for now since it made so many changes making it hard to review. Planning to do the move after this PR is removed so there's a separate PR just for moving stuff around, and also move Profile into a separate package. |
pedroigor
left a comment
There was a problem hiding this comment.
Nice to see most of the profile setup being done at built time. It should help save some time at startup time.
There was a problem hiding this comment.
Can we add some debug/trace logging? It should be simpler and only require configuring the log-level to the tests.
There was a problem hiding this comment.
We can do a follow-up but it should be possible to avoid installing the PropertiesFileProfileConfigResolver to the distribution but only during tests.
This can be done using a conditional build step like here
.There was a problem hiding this comment.
Wonder if it wouldn't be nice for folks to have the option of using conf/profile.properties. Plan is to extend more on the profile stuff in the future to leverage it more, and could be nice to be able to separate out that part from the other config perhaps?
There was a problem hiding this comment.
My only argument against it is that we have now a configuration schema and we should rely on it whenever possible to configure the server.
For now, I would not introduce another file but just rely on the existing configuration sources (cli, keycloak.conf, etc)
8de8834 to
151e3ae
Compare
97ded83 to
f3d67c2
Compare
9a06c71 to
5af8eb5
Compare
d175815 to
ca87331
Compare
ca87331 to
faae9c0
Compare
Closes #15206