Skip to content

Move init builtin mappers from static init to factory init - #15356

Closed
lexcao wants to merge 1 commit into
keycloak:mainfrom
lexcao:15349/feature/scope-mappers
Closed

lexcao wants to merge 1 commit into
keycloak:mainfrom
lexcao:15349/feature/scope-mappers

Conversation

@lexcao

@lexcao lexcao commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

Closes #15349

The built-in mappers are initialized from static currently.

I am trying to create a unit test but failed.
I found no way to set up disabled features at the test server startup.
Need the team to help me how to fix this test.

@stianst

stianst commented Nov 6, 2022 •

Copy link
Copy Markdown
Contributor

I'm already doing this in #15341, which is also changing the builtIns to not be a static field anymore.

@stianst stianst closed this Nov 6, 2022
@lexcao

lexcao commented Nov 6, 2022

Copy link
Copy Markdown
Contributor Author

@stianst Sounds great, thank you!

@lexcao
lexcao deleted the 15349/feature/scope-mappers branch November 6, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in Core? ( Clients Client details Dedicated scopes): Cannot read properties of undefined (reading 'helpText')

2 participants