Skip to content

Remove JUnit dependencies from the distribution - #22457

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
mabartos:KC-22445
Aug 15, 2023
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
mabartos:KC-22445

Conversation

@mabartos

Copy link
Copy Markdown
Member

The JUnit and its transitive dependencies JARs are not included in the distribution anymore.

@vmuzikar Could you please check it?

@pedroigor

Copy link
Copy Markdown
Contributor

@mabartos Some time ago I did this #9077. At that time, blocked by issues with HashiCorp extension (which now is removed from dist).

I think we should be able to remove much more ...

@mabartos

Copy link
Copy Markdown
Member Author

@pedroigor Nice piece of information. I'll take a look at it.

@mabartos

mabartos commented Aug 15, 2023 •

Copy link
Copy Markdown
Member Author

@pedroigor From the mentioned PR, there's nothing to use ATM. The testcontainers and Maven JARs are not present there anymore. I think the removal of the additional artifact can be done in a follow-up task.

@mabartos
mabartos requested a review from vmuzikar August 15, 2023 13:06

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mabartos!

@ASzc jFYI – this keeps the JUnit artifacts only in tests, so should resolve prod issues.

@vmuzikar
vmuzikar merged commit ecd9044 into keycloak:main Aug 15, 2023
@vmuzikar vmuzikar linked an issue Aug 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove junit dependencies from the distribution

3 participants