Skip to content

24476 backport - #24717

Merged
stianst merged 1 commit into
keycloak:release/22.0from
andymunro:24476-backport
Nov 14, 2023
Merged

stianst merged 1 commit into
keycloak:release/22.0from
andymunro:24476-backport

Conversation

@andymunro

@andymunro andymunro commented Nov 13, 2023 •

Copy link
Copy Markdown
Contributor

Backport of #24476

@ahus1 Please merge

@andymunro
andymunro requested a review from a team as a code owner November 13, 2023 18:30
@andymunro
andymunro requested a review from a team November 13, 2023 18:30
@andymunro
andymunro requested review from a team as code owners November 13, 2023 18:30
@ahus1
ahus1 changed the base branch from main to release/22.0 November 13, 2023 18:46
@ahus1
ahus1 force-pushed the 24476-backport branch 2 times, most recently from 22f6388 to 9539714 Compare November 13, 2023 19:06
(cherry picked from commit bf17fcc)

Signed-off-by: andymunro <48995441+andymunro@users.noreply.github.com>
@ahus1 ahus1 added the area/docs Documentation — server guides, AsciiDoc, JavaDoc, migration/upgrade guides label Nov 13, 2023

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to change the base-branch and trigger the CI after doing so by rebasing the change. Now it is fine.

@ahus1

ahus1 commented Nov 13, 2023

Copy link
Copy Markdown
Member

@stianst - please merge this PR to the KC22 branch which is currently blocked. Thanks!

@stianst
stianst merged commit 1359ea5 into keycloak:release/22.0 Nov 14, 2023
@cypress

cypress Bot commented Nov 14, 2023

Copy link
Copy Markdown

2 flaky tests on run #9785 ↗︎

0 527 48 0 Flakiness 2

Details:

Fix broken links (#24476) (#24717)
Project: Keycloak Admin UI Commit: 1359ea5332
Status: Passed Duration: 11:51 💡
Started: Nov 14, 2023 4:20 AM Ended: Nov 14, 2023 4:31 AM
Flakiness  authentication_test.spec.ts • 1 flaky test • chrome

View
Output

Test Artifacts
Authentication test > should add a condition Screenshots
Flakiness  sessions_test.spec.ts • 1 flaky test • chrome

View
Output

Test Artifacts
Sessions test > revocation > Check if notBefore saved Screenshots

Review all test suite changes for PR #24717 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation — server guides, AsciiDoc, JavaDoc, migration/upgrade guides

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants