Repository navigation
Adapter tests failing with Jakarta error - #24180
Merged
Merged
Conversation
mabartos
force-pushed
the
fix_sb_tests_22
branch
from
October 24, 2023 11:43
36fbaff to
7422efd
Compare
Member
Author
|
Rebased |
Member
Author
|
@miquelsi CI passed for the backported version. |
Member
Author
miquelsi
approved these changes
Oct 31, 2023
Aboullos
approved these changes
Oct 31, 2023
Aboullos
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Now those tests are passing
ahus1
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24176
Backport-of #24177
@Aboullos @miquelsi Could you check it, please?