Repository navigation
Localization tabs - #25532
Localization tabs#25532
Conversation
Passing run #10432 ↗︎
Details:
Review all test suite changes for PR #25532 ↗︎ |
|||||||||||||||
bb12b5b to
6978e94
Compare
hmlnarik
left a comment
There was a problem hiding this comment.
Changes in Java code look good, thanks for fixing the NPE
There was a problem hiding this comment.
do we really need all this css
There was a problem hiding this comment.
I agree with Erik on this one, is there a way we can eliminate most, if not all of this CSS? The advantage of using PatternFly is that we can avoid custom styling in most places, and instead rely on theirs.
If we customize the styles to this extend it will make it very fragile if we need to do major version updates of PatternFly that introduce breaking changes. For example, most of the variable names used here have completely different names in PatternFly 5.
There was a problem hiding this comment.
@jonkoops I was able to use Patternfly styles and remove the localization stylesheet altogether. Could you please give it a final check? Thanks!
|
@agagancarczyk looks like there are some conflicts with the |
@jonkoops I've just rebased. |
9dc1c4a to
95e9ea1
Compare
95e9ea1 to
3cbc80f
Compare
Closes keycloak#23057 Signed-off-by: Agnieszka <agancarc@redhat.com> Signed-off-by: Jon Koops <jonkoops@gmail.com>
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
563f399 to
8620ffc
Compare
hmlnarik
left a comment
There was a problem hiding this comment.
Reapproving the java changes
* Add new localization tabs to Administration Console Closes keycloak#23057 Signed-off-by: Agnieszka <agancarc@redhat.com> Signed-off-by: Jon Koops <jonkoops@gmail.com> * css cleanup Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> * css cleanup Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> --------- Signed-off-by: Agnieszka <agancarc@redhat.com> Signed-off-by: Jon Koops <jonkoops@gmail.com> Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> Co-authored-by: Jon Koops <jonkoops@gmail.com> Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com> Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
* Add new localization tabs to Administration Console Closes keycloak#23057 Signed-off-by: Agnieszka <agancarc@redhat.com> Signed-off-by: Jon Koops <jonkoops@gmail.com> * css cleanup Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> * css cleanup Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> --------- Signed-off-by: Agnieszka <agancarc@redhat.com> Signed-off-by: Jon Koops <jonkoops@gmail.com> Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com> Co-authored-by: Jon Koops <jonkoops@gmail.com> Co-authored-by: Agnieszka Gancarczyk <agancarc@redhat.com> Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Closes #23057
Locales and Realm overrides tabs are as per designs.
The effective message bundles tab is as per discussions we had and slightly differs from the original designs. The table no longer includes 'Language' and 'Theme' columns, as they are unnecessary – the user sees their chosen options, and currently, we support only one selected language and one selected theme at a time. In the search form, the user can select only one theme, one theme type, and one language, but multiple 'hasWords' options are available. The default language is set to English.