Skip to content

Revised many parts of the account console that were not correctly translated into Chinese. - #25828

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
potterhe:i18n-zh-cn
Jan 8, 2024
Merged

ahus1 merged 1 commit into
keycloak:mainfrom
potterhe:i18n-zh-cn

Conversation

@potterhe

Copy link
Copy Markdown
Contributor

No description provided.

@potterhe
potterhe requested a review from a team as a code owner December 30, 2023 17:13
@ahus1 ahus1 self-assigned this Jan 2, 2024
@ahus1

ahus1 commented Jan 2, 2024

Copy link
Copy Markdown
Member

Thank you for this contribution. Please have a second Chinese native speaker review your changes, and approve them here with a comment. Once the review is in, this PR can be merged. Thanks!

@jonkoops

jonkoops commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

@xianli123 would you be willing to review this one?

@xianli123

xianli123 commented Jan 3, 2024 •

Copy link
Copy Markdown
Contributor

Thanks, @potterhe @ahus1 @jonkoops I will take a look.

@xianli123

Copy link
Copy Markdown
Contributor

Hi @potterhe Thanks for your great contribution. Overall, it looks great. I just made a few tweaks, please take a look at the suggestions in the original file. If you have any opinion on the fine-tuning, we can discuss it.

@ahus1

ahus1 commented Jan 5, 2024

Copy link
Copy Markdown
Member

@xianli123 - I see that there have been some new commits to the PR. Could you please re-review and write a short note if your previous comments are now resolved?

Signed-off-by: potterhe <potter.he@gmail.com>

@xianli123 xianli123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahus1 Previous commits have been resolved. It looks good for now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
thirdPartyApp=第三方
thirdPartyApp=第三方应用

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
credentialCreatedAt=创建于
credentialCreatedAt=创建时间

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
applicationsIntroMessage=踪和管理您的应用程序访问您帐户的权限
applicationsIntroMessage=综合管理您的应用程序访问您帐户的权限

@ahus1

ahus1 commented Jan 8, 2024

Copy link
Copy Markdown
Member

@xianli123 - thank you for the review. I see you've also added new review comments, so I assume this PR is not ready to be merged until those have been addressed by the original author?

@xianli123

Copy link
Copy Markdown
Contributor

Hi @ahus1 Sorry for misleading you. I have reviewed the changes and approved this PR. So we can merge it for now. Thanks!

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of community review

@ahus1
ahus1 enabled auto-merge (squash) January 8, 2024 10:53
@ahus1
ahus1 merged commit 69b28ea into keycloak:main Jan 8, 2024
wistefan pushed a commit to wistefan/keycloak that referenced this pull request Jan 17, 2024
Signed-off-by: potterhe <potter.he@gmail.com>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
Signed-off-by: potterhe <potter.he@gmail.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants