Skip to content

Update web element of the LinkedIn login page - #25905

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
tondrusk:linkedin-login-btn
Jan 8, 2024
Merged

ahus1 merged 1 commit into
keycloak:mainfrom
tondrusk:linkedin-login-btn

Conversation

@tondrusk

@tondrusk tondrusk commented Jan 4, 2024 •

Copy link
Copy Markdown
Contributor

Rely on the type and aria-label tags to more clearly specify the login button instead of relying on text(). The text() changed from Sign in to ‎ Sign in‎ (leading and trailing space) and it may change to something else over time.

Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com>
@tondrusk
tondrusk requested review from a team as code owners January 4, 2024 14:51
@tondrusk
tondrusk requested a review from a team January 4, 2024 14:51
@tondrusk
tondrusk requested a review from a team as a code owner January 4, 2024 14:51
@tondrusk

tondrusk commented Jan 4, 2024

Copy link
Copy Markdown
Contributor Author

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of @miquelsi's review.

@ahus1
ahus1 merged commit e4fa5c0 into keycloak:main Jan 8, 2024
tondrusk added a commit to tondrusk/keycloak that referenced this pull request Jan 9, 2024
Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com>
(cherry picked from commit e4fa5c0)
ahus1 pushed a commit that referenced this pull request Jan 9, 2024
Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com>
(cherry picked from commit e4fa5c0)
wistefan pushed a commit to wistefan/keycloak that referenced this pull request Jan 17, 2024
Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants