Skip to content

Make passing parameters to generateEncodedPath() type-safe - #25944

Merged
jonkoops merged 1 commit into
keycloak:mainfrom
jonkoops:type-safe-path
Jan 5, 2024
Merged

jonkoops merged 1 commit into
keycloak:mainfrom
jonkoops:type-safe-path

Conversation

@jonkoops

@jonkoops jonkoops commented Jan 5, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@jonkoops
jonkoops requested a review from a team as a code owner January 5, 2024 11:30
@ghost ghost added the team/ui label Jan 5, 2024
Signed-off-by: Jon Koops <jonkoops@gmail.com>
@cypress

cypress Bot commented Jan 5, 2024 •

Copy link
Copy Markdown

1 flaky test on run #10408 ↗︎

0 550 54 0 Flakiness 1

Details:

Merge c9a8563 into 6f25793...
Project: Keycloak Admin UI Commit: 821e242823 ℹ️
Status: Passed Duration: 07:04 💡
Started: Jan 5, 2024 1:16 PM Ended: Jan 5, 2024 1:23 PM
Flakiness  cypress/e2e/clients_test.spec.ts • 1 flaky test • chrome

View Output

Test Artifacts
Clients test > Roles tab test > Should delete client role from role details test Test Replay Screenshots

Review all test suite changes for PR #25944 ↗︎

@hmlnarik hmlnarik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than the original. Thank you!

@jonkoops
jonkoops merged commit 2eb31f8 into keycloak:main Jan 5, 2024
@jonkoops
jonkoops deleted the type-safe-path branch January 5, 2024 14:13
wistefan pushed a commit to wistefan/keycloak that referenced this pull request Jan 17, 2024
…k#25944)

Signed-off-by: Jon Koops <jonkoops@gmail.com>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
…k#25944)

Signed-off-by: Jon Koops <jonkoops@gmail.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants