Skip to content

Bump jsdom from 23.0.1 to 23.2.0 in /js - #25970

Merged
jonkoops merged 1 commit into
mainfrom
dependabot/npm_and_yarn/js/jsdom-23.2.0
Jan 8, 2024
Merged

jonkoops merged 1 commit into
mainfrom
dependabot/npm_and_yarn/js/jsdom-23.2.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jan 8, 2024 •

Copy link
Copy Markdown
Contributor

Bumps jsdom from 23.0.1 to 23.2.0.

Release notes

Sourced from jsdom's releases.

Version 23.2.0

This release switches our CSS selector engine from nwsapi to https://github.com/jsdom/jsdom/blob/HEAD/@asamuzakjp/dom-selector. The new engine is more actively maintained, and supports many new selectors: see the package's documentation for the full list. It also works better with shadow trees.

There is a potential of a performance regression due to this change. In our stress test benchmark, which runs most of these 273 selectors against this 128 KiB document, the new engine completes the benchmark only 0.25x as fast. However, we're hopeful that in more moderate usage this will not be a significant issue. Any help speeding up @asamuzakjp/dom-selector is appreciated, and feel free to open an issue if this has had a significant impact on your project.

Version 23.1.0

  • Added an initial implementation of ElementInternals, including the shadowRoot getter and the string-valued ARIA properties. (zjffun)
  • Added the string-valued ARIA attribute-reflecting properties to Element.
  • Fixed history.pushState() and history.replaceState() to follow the latest specification, notably with regards to how they handle empty string inputs and what new URLs are possible.
  • Fixed the input.valueAsANumber setter to handle NaN correctly. (alexandertrefz)
  • Updated various dependencies, including cssstyle which contains several bug fixes.
Changelog

Sourced from jsdom's changelog.

23.2.0

This release switches our CSS selector engine from nwsapi to https://github.com/jsdom/jsdom/blob/main/@asamuzakjp/dom-selector. The new engine is more actively maintained, and supports many new selectors: see the package's documentation for the full list. It also works better with shadow trees.

There is a potential of a performance regression due to this change. In our stress test benchmark, which runs most of these 273 selectors against this 128 KiB document, the new engine completes the benchmark only 0.25x as fast. However, we're hopeful that in more moderate usage this will not be a significant issue. Any help speeding up @asamuzakjp/dom-selector is appreciated, and feel free to open an issue if this has had a significant impact on your project.

23.1.0

  • Added an initial implementation of ElementInternals, including the shadowRoot getter and the string-valued ARIA properties. (zjffun)
  • Added the string-valued ARIA attribute-reflecting properties to Element.
  • Fixed history.pushState() and history.replaceState() to follow the latest specification, notably with regards to how they handle empty string inputs and what new URLs are possible.
  • Fixed the input.valueAsANumber setter to handle NaN correctly. (alexandertrefz)
  • Updated various dependencies, including cssstyle which contains several bug fixes.
Commits
  • cf8b707 Version 23.2.0
  • 908f27d Update dom-selector and roll web platform tests
  • c039e52 Switch from nwsapi to dom-selector
  • b677627 Add new CSS selectors benchmark
  • 4b33d36 Enable WPT directories css/selectors and css/css-scoping
  • 3a3a4cb Roll web platform tests
  • dc8306f Version 23.1.0
  • d6c0ab2 Implement string ARIA reflection
  • 60978b6 Implement basic ElementInternals
  • b7683ed Remove chai dependency
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
dependabot Bot requested a review from a team as a code owner January 8, 2024 00:35
@dependabot dependabot Bot added area/dependencies Dependency updates, CVE reports for third-party libraries, version bumps team/ui labels Jan 8, 2024
@cypress

cypress Bot commented Jan 8, 2024 •

Copy link
Copy Markdown

1 flaky test on run #10426 ↗︎

0 550 54 0 Flakiness 1

Details:

Merge 6d73d41 into de0a0a0...
Project: Keycloak Admin UI Commit: 41241d8839 ℹ️
Status: Passed Duration: 07:10 💡
Started: Jan 8, 2024 9:23 AM Ended: Jan 8, 2024 9:31 AM
Flakiness  cypress/e2e/clients_test.spec.ts • 1 flaky test • chrome

View Output

Test Artifacts
Clients test > Client details - Client scopes subtab > Should search non-existent client scope by name Test Replay Screenshots

Review all test suite changes for PR #25970 ↗︎

@hmlnarik

hmlnarik commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

@dependabot rebase

Bumps [jsdom](https://github.com/jsdom/jsdom) from 23.0.1 to 23.2.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md)
- [Commits](jsdom/jsdom@23.0.1...23.2.0)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/js/jsdom-23.2.0 branch from a91aa50 to 6d73d41 Compare January 8, 2024 09:15
@jonkoops
jonkoops enabled auto-merge (squash) January 8, 2024 09:23
@jonkoops
jonkoops merged commit a42fae6 into main Jan 8, 2024
@jonkoops
jonkoops deleted the dependabot/npm_and_yarn/js/jsdom-23.2.0 branch January 8, 2024 09:31
wistefan pushed a commit to wistefan/keycloak that referenced this pull request Jan 17, 2024
Bumps [jsdom](https://github.com/jsdom/jsdom) from 23.0.1 to 23.2.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md)
- [Commits](jsdom/jsdom@23.0.1...23.2.0)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
Bumps [jsdom](https://github.com/jsdom/jsdom) from 23.0.1 to 23.2.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md)
- [Commits](jsdom/jsdom@23.0.1...23.2.0)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Dependency updates, CVE reports for third-party libraries, version bumps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants