Skip to content

fix empty attributes parsing - #26729

Merged
stianst merged 1 commit into
keycloak:release/23.0from
stianst:fix-empty-attributes-parsing
Feb 2, 2024
Merged

fix empty attributes parsing#26729
stianst merged 1 commit into
keycloak:release/23.0from
stianst:fix-empty-attributes-parsing

Conversation

@stianst

@stianst stianst commented Feb 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ideally the admin console shouldn't be sending empty values, and we should also have validation to prevent saving empty values, but for the time being this resolves the issue, and also is a fix for those that have upgraded and broken their installation.

Resolves #26597, resolves #26665

@stianst
stianst requested a review from a team as a code owner February 2, 2024 09:15
@stianst
stianst requested a review from a team February 2, 2024 09:15
@stianst
stianst requested review from a team as code owners February 2, 2024 09:15
@stianst
stianst changed the base branch from main to release/23.0 February 2, 2024 09:16
@stianst
stianst force-pushed the fix-empty-attributes-parsing branch 2 times, most recently from 828e813 to 2ce0263 Compare February 2, 2024 09:19
@mposolda mposolda mentioned this pull request Feb 2, 2024
Merged
vmuzikar
vmuzikar approved these changes Feb 2, 2024
View reviewed changes

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, LGTM.

@antikalk

antikalk commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

Thank you for this! 👍 Only thing I can add is that, what if the user somehow, e.g. via API or Admin UI, stores a value that is not empty but can not be parsed, e.g. the string "a"? Wouldn't that result in the same behaviour?

sschu
sschu approved these changes Feb 2, 2024
View reviewed changes

@sschu sschu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just questions/nitpicks.

Comment thread ...ration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/realm/RealmTest.java Outdated

@sschu sschu Feb 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the wildcard imports here intended?

@stianst stianst Feb 2, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nopes, that was a mistake, but not fixing that now as that would require a new run in CI ;)

@jonkoops jonkoops Feb 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to prevent this we should have some kind of shared linter/IDE configuration.

Comment thread ...ration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/realm/RealmTest.java Outdated

@sschu sschu Feb 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, I would use realmName.

@stianst stianst Feb 2, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have possibly changed that, if it wasn't for the fact that will result in a new CI run ;)

@stianst

stianst commented Feb 2, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for this! 👍 Only thing I can add is that, what if the user somehow, e.g. via API or Admin UI, stores a value that is not empty but can not be parsed, e.g. the string "a"? Wouldn't that result in the same behaviour?

The Admin UI only allows adding numbers to those fields, but that could happen if you do it through the Admin UI. We really need to get some improvements around validation for things like that, but won't cover it in this as I'd like to get the most pressing thing sorted out first, and get a 23.0.6 release out, hopefully today.

hmlnarik
hmlnarik approved these changes Feb 2, 2024
View reviewed changes

@hmlnarik hmlnarik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for 23.0, otherwise I support @sschu 's review comments

mhajas
mhajas suggested changes Feb 2, 2024
View reviewed changes

@mhajas mhajas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getUserActionTokenLifespans is doing a substring of the entry key so we need to get only something instead of whole RealmAttributes.ACTION_TOKEN_GENERATED_BY_USER_LIFESPAN + ".something" in the test. That may be a reason for a new CI run.

Comment thread ...ration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/realm/RealmTest.java Resolved
Comment thread ...ration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/realm/RealmTest.java Resolved
Comment thread ...ration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/realm/RealmTest.java Resolved
@sschu

sschu commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

A link to the issue in the PR description would be good so the tracking on the board works correctly.

@stianst
stianst force-pushed the fix-empty-attributes-parsing branch from 2ce0263 to 36b9530 Compare February 2, 2024 10:03
@stianst stianst linked an issue Feb 2, 2024 that may be closed by this pull request
Keycloak UI meets "Internal Sever Error" after save "Refresh Token Max Reuse" number #26597
Closed
1 task done
@ghost ghost added the flaky-test label Feb 2, 2024
This was referenced Feb 2, 2024
Closed
Closed
Closed
@stianst

stianst commented Feb 2, 2024

Copy link
Copy Markdown
Contributor Author

getUserActionTokenLifespans is doing a substring of the entry key so we need to get only something instead of whole RealmAttributes.ACTION_TOKEN_GENERATED_BY_USER_LIFESPAN + ".something" in the test. That may be a reason for a new CI run.

Fixed this, although it doesn't matter for this fix, as the exception is thrown regardless.

ghost
ghost reviewed Feb 2, 2024
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@sschu

sschu commented Feb 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Somehow the "new-realm" seems to affect other tests. It causes 404 when setting the realm and assertion failures Caused by: org.junit.ComparisonFailure: expected:<[test]> but was:<[new-realm]> also Expected: [master, test], was: [master, new-realm, test]: array lengths differed, expected.length=2 actual.length=3; arrays first differed at element [1]; expected:<[test]> but was:<[new-realm]>. Looks like the realm should be deleted at the end of the test?

@keycloak keycloak deleted a comment Feb 2, 2024
@stianst
stianst force-pushed the fix-empty-attributes-parsing branch 2 times, most recently from 864e2cf to 55ae655 Compare February 2, 2024 10:41
@stianst
Ignore empty attribute values when retriveing boolean/int/long
2419960 
Resolves keycloak#26597, resolves keycloak#26665

Signed-off-by: stianst <stianst@gmail.com>
@stianst
stianst force-pushed the fix-empty-attributes-parsing branch from 55ae655 to 2419960 Compare February 2, 2024 10:42
@stianst

stianst commented Feb 2, 2024

Copy link
Copy Markdown
Contributor Author

Somehow the "new-realm" seems to affect other tests. It causes 404 when setting the realm and assertion failures Caused by: org.junit.ComparisonFailure: expected:<[test]> but was:<[new-realm]> also Expected: [master, test], was: [master, new-realm, test]: array lengths differed, expected.length=2 actual.length=3; arrays first differed at element [1]; expected:<[test]> but was:<[new-realm]>. Looks like the realm should be deleted at the end of the test?

Just noticed that, should be fixed now

ghost
ghost reviewed Feb 2, 2024
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost

ghost commented Feb 2, 2024

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.realm.RealmTest#testNoUserProfileProviderComponentUponRealmChange

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.ClientErrorException: HTTP 409 Conflict
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:258)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#removeRealm

Keycloak CI - Legacy Store IT (mariadb)

Expected: [master, test], was: [master, new-realm, test]: array lengths differed, expected.length=2 actual.length=3; arrays first differed at element [1]; expected:<[test]> but was:<[new-realm]>
	at org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:78)
	at org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:28)
	at org.junit.Assert.internalArrayEquals(Assert.java:534)
	at org.junit.Assert.assertArrayEquals(Assert.java:285)
...

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#updateRealmAttributes

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#createRealmFromJson

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#renameRealm

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#updateRealmEventsConfig

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#clientSessionStats

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#loginAfterRemoveRealm

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#getRealmRepresentation

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#createRealmWithPasswordPolicyFromJsonWithValidPasswords

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#testSupportedOTPApplications

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#createRealmEmpty

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#updateRealmWithNewRepresentation

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#getRealms

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#excludesFieldsFromAttributes

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#pushNotBeforeWithSamlApp

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#convertOIDCClientDescription

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#createRealmWithPasswordPolicyFromJsonWithInvalidPasswords

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#deleteSession

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#convertSAMLClientDescription

Keycloak CI - Legacy Store IT (mariadb)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#testNoUserProfileProviderComponentUponRealmChange

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.ClientErrorException: HTTP 409 Conflict
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:258)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#removeRealm

Keycloak CI - Legacy Store IT (postgres)

Expected: [master, test], was: [master, new-realm, test]: array lengths differed, expected.length=2 actual.length=3; arrays first differed at element [1]; expected:<[test]> but was:<[new-realm]>
	at org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:78)
	at org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:28)
	at org.junit.Assert.internalArrayEquals(Assert.java:534)
	at org.junit.Assert.assertArrayEquals(Assert.java:285)
...

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#updateRealmAttributes

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#createRealmFromJson

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#renameRealm

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#updateRealmEventsConfig

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#clientSessionStats

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#loginAfterRemoveRealm

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#getRealmRepresentation

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#createRealmWithPasswordPolicyFromJsonWithValidPasswords

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#testSupportedOTPApplications

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#createRealmEmpty

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#updateRealmWithNewRepresentation

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#getRealms

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#excludesFieldsFromAttributes

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#pushNotBeforeWithSamlApp

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#convertOIDCClientDescription

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#createRealmWithPasswordPolicyFromJsonWithInvalidPasswords

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#deleteSession

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.admin.realm.RealmTest#convertSAMLClientDescription

Keycloak CI - Legacy Store IT (postgres)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

mhajas
mhajas approved these changes Feb 2, 2024
View reviewed changes

@mhajas mhajas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @stianst

@stianst
stianst merged commit 8056135 into keycloak:release/23.0 Feb 2, 2024
@cypress

cypress Bot commented Feb 2, 2024

Copy link
Copy Markdown

1 flaky test on run #10890 ↗︎

0 539 49 0 Flakiness 1

Details:

Ignore empty attribute values when retriveing boolean/int/long (#26729)
Project: Keycloak Admin UI Commit: 8056135e2a
Status: Passed Duration: 07:13 💡
Started: Feb 2, 2024 12:42 PM Ended: Feb 2, 2024 12:49 PM
Flakiness  cypress/e2e/client_scopes_test.spec.ts • 1 flaky test • chrome

View Output

Test Artifacts
Client Scopes test > Client Scope filter list items > should filter items by Protocol All Test Replay Screenshots

Review all test suite changes for PR #26729 ↗︎

stianst added a commit to stianst/keycloak that referenced this pull request Feb 2, 2024
@stianst
Ignore empty attribute values when retriveing boolean/int/long (keycl…
d7a4c17 
…oak#26729)

Resolves keycloak#26597, resolves keycloak#26665

Signed-off-by: stianst <stianst@gmail.com>
@sschu sschu mentioned this pull request Feb 2, 2024
Closed
stianst added a commit that referenced this pull request Feb 6, 2024
@stianst
Ignore empty attribute values when retriveing boolean/int/long (#26729)…
3e08a17 
… (#26737)

Resolves #26597, resolves #26665

Signed-off-by: stianst <stianst@gmail.com>
stianst added a commit to stianst/keycloak that referenced this pull request Feb 6, 2024
@stianst
Ignore empty attribute values when retriveing boolean/int/long (keycl…
9e16357 
…oak#26729)

Resolves keycloak#26597, resolves keycloak#26665

Signed-off-by: stianst <stianst@gmail.com>
mhajas pushed a commit that referenced this pull request Feb 6, 2024
@stianst
Ignore empty attribute values when retriveing boolean/int/long (#26729)…
0d6005d 
… (#26738)

Resolves #26597, resolves #26665

Signed-off-by: stianst <stianst@gmail.com>
@cypress cypress Bot mentioned this pull request Feb 6, 2024
Merged
cavuugroup pushed a commit to cavuugroup/keycloak that referenced this pull request Feb 8, 2024
@stianst @cavuugroup
Ignore empty attribute values when retriveing boolean/int/long (keycl…
eb88b71 
…oak#26729) (keycloak#26737)

Resolves keycloak#26597, resolves keycloak#26665

Signed-off-by: stianst <stianst@gmail.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
@stianst stianst mentioned this pull request May 6, 2024
Merged
@stianst
stianst deleted the fix-empty-attributes-parsing branch July 17, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes
@vmuzikar vmuzikar vmuzikar approved these changes
+5 more reviewers
@jonkoops jonkoops jonkoops left review comments
@sschu sschu sschu approved these changes
@hmlnarik hmlnarik hmlnarik approved these changes
@mhajas mhajas mhajas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

8 participants

@stianst @antikalk @sschu @jonkoops @mposolda @hmlnarik @mhajas @vmuzikar