Skip to content

fix: permissions tab should be only shown with the correct rights - #26034

Merged
jonkoops merged 1 commit into
keycloak:mainfrom
pkeuter:users-permissions-fix
Jan 16, 2024
Merged

jonkoops merged 1 commit into
keycloak:mainfrom
pkeuter:users-permissions-fix

Conversation

@pkeuter

@pkeuter pkeuter commented Jan 9, 2024 •

Copy link
Copy Markdown
Contributor

This PR makes sure the permissions-tab on the Users-page is not shown for users that do not have access to these permissions. I changed this to use the same check as the Groups-tab: https://github.com/keycloak/keycloak/blob/main/js/apps/admin-ui/src/groups/GroupsSection.tsx#L65.

Closes #26039

@pkeuter
pkeuter requested a review from a team as a code owner January 9, 2024 12:51
@ghost ghost added the team/ui label Jan 9, 2024
@pkeuter
pkeuter force-pushed the users-permissions-fix branch from 6e3f929 to 279814d Compare January 9, 2024 13:16

@jonkoops jonkoops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pkeuter

@jonkoops
jonkoops enabled auto-merge (squash) January 10, 2024 12:05
Signed-off-by: Peter Keuter <github@peterkeuter.nl>
@ssilvert
ssilvert force-pushed the users-permissions-fix branch from 279814d to 544a1d8 Compare January 16, 2024 13:00
@cypress

cypress Bot commented Jan 16, 2024

Copy link
Copy Markdown

Passing run #10632 ↗︎

0 553 54 0 Flakiness 0

Details:

Merge 544a1d8 into 33651c3...
Project: Keycloak Admin UI Commit: e1357be0e7 ℹ️
Status: Passed Duration: 07:14 💡
Started: Jan 16, 2024 1:13 PM Ended: Jan 16, 2024 1:20 PM

Review all test suite changes for PR #26034 ↗︎

@jonkoops
jonkoops merged commit 2cd23e2 into keycloak:main Jan 16, 2024
wistefan pushed a commit to wistefan/keycloak that referenced this pull request Jan 17, 2024
…ycloak#26034)

Signed-off-by: Peter Keuter <github@peterkeuter.nl>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
…ycloak#26034)

Signed-off-by: Peter Keuter <github@peterkeuter.nl>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permissions tab on users-page is shown when user has no rights

2 participants