Skip to content

added choose as an option to reset - #26065

Merged
ssilvert merged 1 commit into
keycloak:mainfrom
edewit:issue-25939
Jan 16, 2024
Merged

ssilvert merged 1 commit into
keycloak:mainfrom
edewit:issue-25939

Conversation

@edewit

@edewit edewit commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

fixes: #25939
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

fixes: keycloak#25939
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@edewit
edewit requested a review from a team as a code owner January 10, 2024 08:09
@ghost ghost added the team/ui label Jan 10, 2024
@cypress

cypress Bot commented Jan 10, 2024

Copy link
Copy Markdown

Passing run #10491 ↗︎

0 558 54 0 Flakiness 0

Details:

Merge 8053477 into 3c05c12...
Project: Keycloak Admin UI Commit: 50a3b00d61 ℹ️
Status: Passed Duration: 06:58 💡
Started: Jan 10, 2024 8:17 AM Ended: Jan 10, 2024 8:24 AM

Review all test suite changes for PR #26065 ↗︎

@ssilvert ssilvert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the field is required? In that case, you would want to have a default value and you would not want to allow the field to become unset.

Do we support a default value right now?

@edewit

edewit commented Jan 16, 2024

Copy link
Copy Markdown
Contributor Author

What happens if the field is required? In that case, you would want to have a default value and you would not want to allow the field to become unset.

Do we support a default value right now?

user profile fields don't have default values

@edewit edewit self-assigned this Jan 16, 2024
@edewit
edewit requested a review from ssilvert January 16, 2024 10:05
@ssilvert
ssilvert merged commit 4958d25 into keycloak:main Jan 16, 2024
wistefan pushed a commit to wistefan/keycloak that referenced this pull request Jan 17, 2024
fixes: keycloak#25939

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
@pedroigor

Copy link
Copy Markdown
Contributor

Thanks @ssilvert @edewit !

ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
fixes: keycloak#25939

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Declartive user profile. When multiple attributes with options validator are defined and 1 is selected on UI shown that 2 of them have values.

4 participants