Skip to content

Change test check to fix Firefox flaky failures - #26195

Merged
jonkoops merged 1 commit into
keycloak:mainfrom
Aboullos:client_scopes_test
Jan 16, 2024
Merged

jonkoops merged 1 commit into
keycloak:mainfrom
Aboullos:client_scopes_test

Conversation

@Aboullos

@Aboullos Aboullos commented Jan 15, 2024 •

Copy link
Copy Markdown
Contributor

Solves #26148

@Aboullos
Aboullos requested a review from a team as a code owner January 15, 2024 11:23
@ghost ghost added the team/ui label Jan 15, 2024
@cypress

cypress Bot commented Jan 15, 2024 •

Copy link
Copy Markdown

1 flaky test on run #10629 ↗︎

0 553 54 0 Flakiness 1

Details:

Merge 40fe88d into 33651c3...
Project: Keycloak Admin UI Commit: e5e6cba481 ℹ️
Status: Passed Duration: 07:08 💡
Started: Jan 16, 2024 12:32 PM Ended: Jan 16, 2024 12:39 PM
Flakiness  cypress/e2e/clients_test.spec.ts • 1 flaky test • chrome

View Output

Test Artifacts
Clients test > Mapping tab > Add mapping to openid client Test Replay Screenshots

Review all test suite changes for PR #26195 ↗︎

jonkoops
jonkoops previously approved these changes Jan 15, 2024
hmlnarik
hmlnarik previously approved these changes Jan 16, 2024
@miquelsi

Copy link
Copy Markdown
Contributor

The failure described in the issue was happening on Firefox. However, in the Checks I only see execution for Chrome. How can we be sure it will still work on Firefox? @Aboullos @jonkoops

@Aboullos

Copy link
Copy Markdown
Contributor Author

I am trying to run them in Firefox

@Aboullos
Aboullos dismissed stale reviews from hmlnarik and jonkoops via 59885ef January 16, 2024 11:35
@Aboullos
Aboullos requested a review from a team as a code owner January 16, 2024 11:35
Signed-off-by: Alfredo Moises Boullosa <aboullos@redhat.com>
@jonkoops
jonkoops merged commit af4954a into keycloak:main Jan 16, 2024
wistefan pushed a commit to wistefan/keycloak that referenced this pull request Jan 17, 2024
Closes keycloak#26148

Signed-off-by: Alfredo Moises Boullosa <aboullos@redhat.com>
Signed-off-by: Stefan Wiedemann <wistefan@googlemail.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
Closes keycloak#26148

Signed-off-by: Alfredo Moises Boullosa <aboullos@redhat.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants