Skip to content

Do not use general debug log level for tests #26242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mabartos merged 1 commit into from
Jan 16, 2024
Merged

Do not use general debug log level for tests #26242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/BuildAndStartDistTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ private void assertAdminCreation(KeycloakDistribution dist, LaunchResult result,

dist.setEnvVar("KEYCLOAK_ADMIN", nextUsername);
dist.setEnvVar("KEYCLOAK_ADMIN_PASSWORD", password);
CLIResult cliResult = dist.run("start-dev", "--log-level=debug");
CLIResult cliResult = dist.run("start-dev", "--log-level=org.keycloak.services:debug");

cliResult.assertMessage("Skipping create admin user. Admin already exists in realm 'master'.");
cliResult.assertStartedDevMode();
Expand Down
17 changes: 5 additions & 12 deletions quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/LoggingDistTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,20 +74,13 @@ void testRootAndCategoryLevels(LaunchResult result) {
}

@Test
@Launch({ "start-dev", "--log-level=off,org.keycloak:warn,debug" })
@Launch({ "start-dev", "--log-level=off,org.keycloak:warn,warn" })
void testSetLastRootLevelIfMultipleSet(LaunchResult result) {
CLIResult cliResult = (CLIResult) result;
assertTrue(cliResult.getOutput().contains("DEBUG [io.netty.util.internal"));
assertFalse(cliResult.getOutput().contains("INFO [org.keycloak"));
cliResult.assertStartedDevMode();
}

@Test
@Launch({ "start-dev", "--log-level=off,org.keycloak:warn,debug" })
void testWinSetLastRootLevelIfMultipleSet(LaunchResult result) {
CLIResult cliResult = (CLIResult) result;
assertTrue(cliResult.getOutput().contains("DEBUG [io.netty.util.internal"));
assertFalse(cliResult.getOutput().contains("INFO [org.keycloak"));
assertFalse(cliResult.getOutput().contains("INFO"));
assertFalse(cliResult.getOutput().contains("DEBUG"));
assertFalse(cliResult.getOutput().contains("Listening on:"));
assertTrue(cliResult.getOutput().contains("WARN [org.keycloak"));
cliResult.assertStartedDevMode();
}

Expand Down