Skip to content

Fix: admin GUI not working with 1000s of realms - #32218

Merged
ahus1 merged 2 commits into
keycloak:mainfrom
yelhouti:fix-31956
Aug 21, 2024
Merged

ahus1 merged 2 commits into
keycloak:mainfrom
yelhouti:fix-31956

Conversation

@yelhouti

Copy link
Copy Markdown
Contributor

Search by RealmName is done before loading all realms when filtering

Closes #31956

Search by RealmName is done before loading all realms when filtering

Closes keycloak#31956

Signed-off-by: Youssef El Houti <youssef.elhouti@gmail.com>
@yelhouti
yelhouti requested review from a team as code owners August 19, 2024 01:00
@edewit edewit self-assigned this Aug 20, 2024
edewit
edewit previously approved these changes Aug 20, 2024
@yelhouti

Copy link
Copy Markdown
Contributor Author

@edewit Thanks a lot, would I need to rebase or is it handled automatically by github or the maintainers ?

@ahus1

ahus1 commented Aug 20, 2024

Copy link
Copy Markdown
Member

@yelhouti - there is no need to rebase your PR. This will be done on merge.

Closes keycloak#31956

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ahus1

ahus1 commented Aug 20, 2024

Copy link
Copy Markdown
Member

@edewit - I added a default implementation and release notes. Can you please re-approve? Thanks!

@ahus1
ahus1 enabled auto-merge (squash) August 20, 2024 13:51
@ahus1 ahus1 self-assigned this Aug 20, 2024
@ahus1
ahus1 merged commit e8840df into keycloak:main Aug 21, 2024
return getRealmsStream();
}
TypedQuery<String> query = em.createNamedQuery("getRealmIdsWithNameContaining", String.class);
query.setParameter("search", search);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this worth it?

query.setParameter("limit", limit);
query.setParameter("offset", offset);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is closed. If you think there is the need to optimize it, feel free to open an issue and a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin console not usable when instance has a 1000 realms

6 participants