Repository navigation
Fix: admin GUI not working with 1000s of realms - #32218
Merged
Merged
Conversation
Search by RealmName is done before loading all realms when filtering Closes keycloak#31956 Signed-off-by: Youssef El Houti <youssef.elhouti@gmail.com>
edewit
previously approved these changes
Aug 20, 2024
Contributor
Author
|
@edewit Thanks a lot, would I need to rebase or is it handled automatically by github or the maintainers ? |
Member
|
@yelhouti - there is no need to rebase your PR. This will be done on merge. |
Closes keycloak#31956 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
ahus1
approved these changes
Aug 20, 2024
Member
|
@edewit - I added a default implementation and release notes. Can you please re-approve? Thanks! |
ahus1
enabled auto-merge (squash)
August 20, 2024 13:51
sguilhen
approved these changes
Aug 20, 2024
pedroigor
approved these changes
Aug 21, 2024
1 of 2 tasks
edewit
approved these changes
Aug 21, 2024
indera
reviewed
Aug 21, 2024
indera
reviewed
Aug 21, 2024
indera
reviewed
Aug 21, 2024
| return getRealmsStream(); | ||
| } | ||
| TypedQuery<String> query = em.createNamedQuery("getRealmIdsWithNameContaining", String.class); | ||
| query.setParameter("search", search); |
There was a problem hiding this comment.
Is this worth it?
query.setParameter("limit", limit);
query.setParameter("offset", offset);
Member
There was a problem hiding this comment.
This PR is closed. If you think there is the need to optimize it, feel free to open an issue and a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search by RealmName is done before loading all realms when filtering
Closes #31956