Skip to content

feat: organization authenticator : bypass username form when login_hint is set - #39432

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
olivierboudet:issue/38228
May 5, 2025
Merged

ahus1 merged 1 commit into
keycloak:mainfrom
olivierboudet:issue/38228

Conversation

@olivierboudet

Copy link
Copy Markdown
Contributor

fixes #38228

when using organization authenticator, if login_hint is set, the username form should be auto submitted.

@olivierboudet
olivierboudet requested a review from a team as a code owner May 4, 2025 20:49
@olivierboudet
olivierboudet force-pushed the issue/38228 branch 2 times, most recently from 6d431b0 to 3af30a7 Compare May 4, 2025 21:31
@ahus1

ahus1 commented May 5, 2025

Copy link
Copy Markdown
Member

@olivierboudet - there seems to be a test failure that is related to your changes (at least when looking at the name of the failed test). Please review.

cc: @pedroigor and @sguilhen as this touches organisations.

…nt is set

Signed-off-by: Olivier Boudet <o.boudet@gmail.com>
@olivierboudet

Copy link
Copy Markdown
Contributor Author

@olivierboudet - there seems to be a test failure that is related to your changes (at least when looking at the name of the failed test). Please review.

cc: @pedroigor and @sguilhen as this touches organisations.

Right, I fixed the test

@sguilhen sguilhen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @sguilhen's review.

@ahus1
ahus1 merged commit a39a64e into keycloak:main May 5, 2025
@olivierboudet
olivierboudet deleted the issue/38228 branch May 5, 2025 20:52
@olivierboudet

Copy link
Copy Markdown
Contributor Author

Thank you @ahus1, maybe this can be backported to next 26.2 patch release ?

@ahus1

ahus1 commented May 6, 2025

Copy link
Copy Markdown
Member

We usually don't backport enhancements, still I leave it for @sguilhen to make a judgement on this one.

Without getting ahead on things, it might be good if some people would try out the nightly build with this change and confirm that it is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto submit the "Organization Identity-First Login" form with pre-filled username field

3 participants