Repository navigation
Security/keycloak 11 log4j deser vuln - #39844
Closed
rileyseaburg wants to merge 6 commits into
Closed
rileyseaburg wants to merge 6 commits into
rileyseaburg wants to merge 6 commits into
Conversation
Bumps commons-io:commons-io from 2.7 to 2.14.0. --- updated-dependencies: - dependency-name: commons-io:commons-io dependency-version: 2.14.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…n/tests/commons-io-commons-io-2.14.0 Bump commons-io:commons-io from 2.7 to 2.14.0 in /docs/documentation/tests
Signed-off-by: Riley Seaburg <riley.seaburg@gsa.gov>
Signed-off-by: Riley Seaburg <riley.seaburg@gsa.gov>
* Remove Log4j 1.2.17 from root pom.xml * Migrate all modules to Log4j 2.24.3 * Replace slf4j-reload4j with log4j-slf4j2-impl * Update logging configuration to log4j2.xml format
Author
|
If you all want to merge this you can, I accidentally opened this. It does fix the security issue but I'm not going to resign the commit. Ref: https://github.com/GSA-TTS/keycloak/security/dependabot/11 |
Member
|
IMHO this change would need more updates:
Due to the comment "opened by accident" and "I'm not going to resign the commit", I'm closing this PR. If you want to continue working on it, please reopen it. And we would need a sign-off before merging it. |
Author
|
The CVE still needs to be fixed. Please ensure it's patched. |
Member
|
There is already issue #27932 for that. While this is used in tests, it isn't packaged in Keycloak. |
Author
|
No worries man I patched our fork already. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a security vulnerability in Log4j 1.2.x where the SocketServer class is vulnerable to deserialization of untrusted data. This vulnerability can be exploited to remotely execute arbitrary code when combined with a deserialization gadget when listening to untrusted network traffic for log data.
Changes
pom.xmlslf4j-reload4jwithlog4j-slf4j2-impllog4j.propertiestolog4j2.xmlorg.jboss.logging.providerto uselog4j2Security Impact
This change mitigates a deserialization vulnerability that affects Log4j versions 1.2 up to 1.2.17. The vulnerability has no CVE assigned but was reported in Log4j's issue tracker.
Migration Notes
The change moves from Log4j 1.x to Log4j 2.x which is the recommended logging framework. Log4j 2 provides significant improvements in terms of performance, security, and features over Log4j 1.x.
Testing Done
Related Issues
Fixes #11
Documentation Impact
No documentation changes required as this is an internal dependency update.