Skip to content

Missing comment generated by Liquibase executor in the custom script - #41490

Merged
Pepo48 merged 1 commit into
keycloak:mainfrom
mabartos:KC-41299
Jul 30, 2025
Merged

Missing comment generated by Liquibase executor in the custom script#41490
Pepo48 merged 1 commit into
keycloak:mainfrom
mabartos:KC-41299

Conversation

@mabartos

@mabartos mabartos commented Jul 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

For Liquibase 4.33.0 the databasechangelog table is always created in the database - not part of the custom user's script anymore. More details in the parent issue.

CI for quarkus-next 🆗 :

@mabartos mabartos self-assigned this Jul 29, 2025
@mabartos mabartos mentioned this pull request Jul 29, 2025
Closed
@mabartos
mabartos marked this pull request as ready for review July 29, 2025 13:06
@mabartos
mabartos requested review from a team as code owners July 29, 2025 13:06
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Jul 29, 2025
View reviewed changes

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

keycloak-github-bot Bot commented Jul 29, 2025

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.RealmInvalidationClusterTest#crudWithoutFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

org.keycloak.testsuite.cluster.RealmInvalidationClusterTest#crudWithFailover

Keycloak CI - Store IT (mssql)

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

@mabartos

mabartos commented Jul 29, 2025

Copy link
Copy Markdown
Member Author

Still some failures - need to take a look at it.

@mabartos
mabartos marked this pull request as draft July 29, 2025 14:43
@mabartos
Missing comment generated by Liquibase executor in the custom script
99be211 
Closes keycloak#41299

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
mabartos marked this pull request as ready for review July 30, 2025 10:01
@mabartos

mabartos commented Jul 30, 2025

Copy link
Copy Markdown
Member Author

@keycloak/cloud-native @keycloak/core Should be ready for review. Thanks!

Works with the quarkus-next branch: #41492

@Pepo48
Pepo48 merged commit 7cdb994 into keycloak:main Jul 30, 2025
@mabartos mabartos mentioned this pull request Jul 30, 2025
Closed
1 of 2 tasks
@ryanemerson ryanemerson mentioned this pull request Sep 3, 2025
Merged
This was referenced Aug 14, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pepo48 Pepo48 Pepo48 approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@sguilhen sguilhen sguilhen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mabartos mabartos

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[quarkus-next] Missing comment generated by Liquibase executor in the custom script

3 participants

@mabartos @sguilhen @Pepo48